Skip to content

Commit bced92b

Browse files
author
jantje
committed
Make the test counter part of basic builder
This way the counter continues when running multiple tests
1 parent 1381ada commit bced92b

7 files changed

+15
-12
lines changed

io.sloeber.tests/src/io/sloeber/core/CreateAndCompileArduinoIDEExamplesOnAVRHardwareTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ public void testExample(MCUBoard board) {
8282
if (!board.isExampleSupported(myExample)) {
8383
return;
8484
}
85-
if (!Shared.BuildAndVerify(myBuildCounter, board.getBoardDescriptor(), myCodeDescriptor, null)) {
85+
if (!Shared.BuildAndVerify( board.getBoardDescriptor(), myCodeDescriptor, null)) {
8686
myTotalFails++;
8787
}
8888
}

io.sloeber.tests/src/io/sloeber/core/CreateAndCompileArduinoIDEExamplesOnTeensyTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -88,7 +88,7 @@ public void testExample(MCUBoard board) {
8888
Map<String,String> boardOptions=board.getBoardOptions(myExample);
8989
BoardDescriptor boardDescriptor=board.getBoardDescriptor();
9090
boardDescriptor.setOptions(boardOptions);
91-
if (!Shared.BuildAndVerify(myBuildCounter, boardDescriptor, myCodeDescriptor, null)) {
91+
if (!Shared.BuildAndVerify( boardDescriptor, myCodeDescriptor, null)) {
9292
myTotalFails++;
9393
}
9494
}

io.sloeber.tests/src/io/sloeber/core/CreateAndCompileDefaultInoOnAllBoardsTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -293,7 +293,7 @@ public void testBoard() {
293293
Assume.assumeTrue("To many fails. Stopping test", myTotalFails < maxFails);
294294

295295
IPath templateFolder = Shared.getTemplateFolder("CreateAndCompileTest");
296-
Shared.BuildAndVerify(myBuildCounter, this.mBoard, CodeDescriptor.createCustomTemplate(templateFolder), null);
296+
Shared.BuildAndVerify( this.mBoard, CodeDescriptor.createCustomTemplate(templateFolder), null);
297297

298298
}
299299

io.sloeber.tests/src/io/sloeber/core/CreateAndCompileExamplesTest.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -133,8 +133,9 @@ public void testExamples() {
133133
// failures
134134
Assume.assumeTrue("Skipping first " + mySkipAtStart + " tests", myBuildCounter++ >= mySkipAtStart);
135135
Assume.assumeTrue("To many fails. Stopping test", myTotalFails < maxFails);
136-
// String projectName = String.format("%05d_%s", new Integer(myBuildCounter++), this.myName);
137-
if (!Shared.BuildAndVerify( myBuildCounter++,myBoardDescriptor, myCodeDescriptor)) {
136+
137+
myBuildCounter++;
138+
if (!Shared.BuildAndVerify( myBoardDescriptor, myCodeDescriptor)) {
138139
myTotalFails++;
139140
}
140141

io.sloeber.tests/src/io/sloeber/core/CreateAndCompileJantjesBoardsTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ public void testExample(MCUBoard board) {
107107
if (!board.isExampleSupported(myExample)) {
108108
return;
109109
}
110-
if (!Shared.BuildAndVerify(myBuildCounter, board.getBoardDescriptor(), myCodeDescriptor, null)) {
110+
if (!Shared.BuildAndVerify( board.getBoardDescriptor(), myCodeDescriptor, null)) {
111111
myTotalFails++;
112112
}
113113
}

io.sloeber.tests/src/io/sloeber/core/NightlyBoardPatronTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ public void testExamples() {
8686
Map<String, String> boardOptions = myBoardID.getBoardOptions(myExample);
8787
BoardDescriptor boardDescriptor = myBoardID.getBoardDescriptor();
8888
boardDescriptor.setOptions(boardOptions);
89-
Shared.BuildAndVerify(myBuildCounter,myBoardID.getBoardDescriptor(), codeDescriptor, myCompileOptions);
89+
Shared.BuildAndVerify(myBoardID.getBoardDescriptor(), codeDescriptor, myCompileOptions);
9090

9191
}
9292

io.sloeber.tests/src/io/sloeber/core/Shared.java

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ public class Shared {
4242
public final static String ADAFRUIT_BOARDS_URL = "https://adafruit.github.io/arduino-board-index/package_adafruit_index.json";
4343
public final static String ESP8266_BOARDS_URL = "http://arduino.esp8266.com/stable/package_esp8266com_index.json";
4444
public static boolean deleteProjects=true;
45+
private static int myBuildCounter;
4546

4647

4748
public static boolean hasBuildErrors(IProject project) throws CoreException {
@@ -86,8 +87,8 @@ public static IPath getTemplateFolder(String templateName) {
8687
return new Path(new String());
8788
}
8889

89-
public static boolean BuildAndVerify( int buildCounter, BoardDescriptor boardDescriptor, CodeDescriptor codeDescriptor) {
90-
return BuildAndVerify( buildCounter, boardDescriptor, codeDescriptor, null) ;
90+
public static boolean BuildAndVerify( BoardDescriptor boardDescriptor, CodeDescriptor codeDescriptor) {
91+
return BuildAndVerify( boardDescriptor, codeDescriptor, null) ;
9192
}
9293
/**
9394
* Convenience method to call BuildAndVerify with default project name and null as compile options
@@ -96,10 +97,11 @@ public static boolean BuildAndVerify( int buildCounter, BoardDescriptor boardDes
9697
* @param compileOptions can be null
9798
* @return
9899
*/
99-
public static boolean BuildAndVerify( int buildCounter, BoardDescriptor boardDescriptor, CodeDescriptor codeDescriptor,CompileOptions compileOptions) {
100-
String projectName = String.format("%03d_", new Integer(buildCounter)) + boardDescriptor.getBoardID();
100+
public static boolean BuildAndVerify( BoardDescriptor boardDescriptor, CodeDescriptor codeDescriptor,CompileOptions compileOptions) {
101+
myBuildCounter++;
102+
String projectName = String.format("%05d_%s",new Integer( myBuildCounter), boardDescriptor.getBoardID());
101103
if(codeDescriptor.getExampleName()!=null) {
102-
projectName= String.format("%05d_%s_%s", new Integer(buildCounter),codeDescriptor.getExampleName(), boardDescriptor.getBoardID());
104+
projectName= String.format("%05d_%s_%s",new Integer( myBuildCounter),codeDescriptor.getExampleName(), boardDescriptor.getBoardID());
103105
}
104106
CompileOptions localCompileOptions=compileOptions;
105107
if(compileOptions==null) {

0 commit comments

Comments
 (0)