Skip to content

Commit 0df2089

Browse files
committed
removed retries as a result of server generated exceptions
1 parent 68ac00a commit 0df2089

File tree

1 file changed

+8
-30
lines changed

1 file changed

+8
-30
lines changed

sliderule/sliderule.py

Lines changed: 8 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@
5050
ps_refresh_token = None
5151
ps_access_token = None
5252

53-
max_retries_per_request = 5
53+
max_attempts_per_request = 1
5454

5555
verbose = False
5656

@@ -76,13 +76,6 @@
7676
4: logger.critical
7777
}
7878

79-
handleexcept = {
80-
0: {"name": "ERROR", "fatal": True, "expected": False },
81-
1: {"name": "TIMEOUT", "fatal": False, "expected": True },
82-
2: {"name": "RESOURCE_DOES_NOT_EXIST", "fatal": True, "expected": True },
83-
3: {"name": "EMPTY_SUBSET", "fatal": True, "expected": True }
84-
}
85-
8679
datatypes = {
8780
"TEXT": 0,
8881
"REAL": 1,
@@ -122,14 +115,6 @@
122115
12: "STRING"
123116
}
124117

125-
###############################################################################
126-
# CLASSES
127-
###############################################################################
128-
129-
class TransientError(Exception):
130-
"""Processing exception that can be retried"""
131-
pass
132-
133118
###############################################################################
134119
# UTILITIES
135120
###############################################################################
@@ -317,7 +302,6 @@ def __parse_native(data, callbacks):
317302
return recs
318303

319304
###############################################################################
320-
#
321305
# Default Record Processing
322306
###############################################################################
323307

@@ -332,15 +316,11 @@ def __logeventrec(rec):
332316
# __raiseexceptrec
333317
#
334318
def __raiseexceptrec(rec):
335-
rc = rec["code"]
336-
lvl = rec["level"]
337-
if rc in handleexcept:
338-
if not handleexcept[rc]["expected"]:
339-
logger.critical("%s, unexpected exception <%d>: %s", handleexcept[rc]["name"], rc, rec["text"])
340-
elif verbose:
341-
eventlogger[rec['level']]("%s exception <%d>: %s", handleexcept[rc]["name"], rc, rec["text"])
342-
if not handleexcept[rc]["fatal"]:
343-
raise TransientError()
319+
if verbose:
320+
if rec["code"] >= 0:
321+
eventlogger[rec["level"]]("Exception <%d>: %s", rec["code"], rec["text"])
322+
else:
323+
eventlogger[rec["level"]]("%s", rec["text"])
344324

345325
#
346326
# Globals
@@ -389,8 +369,8 @@ def source (api, parm={}, stream=False, callbacks={}):
389369
>>> print(rsps)
390370
{'time': 1300556199523.0, 'format': 'GPS'}
391371
'''
392-
global service_url, service_org, max_retries_per_request
393-
retries = max_retries_per_request
372+
global service_url, service_org, max_attempts_per_request
373+
retries = max_attempts_per_request
394374
rqst = json.dumps(parm)
395375
rsps = {}
396376
headers = None
@@ -438,8 +418,6 @@ def source (api, parm={}, stream=False, callbacks={}):
438418
logger.error("Server experiencing heavy load, stalling on request to {} ... will retry".format(url))
439419
else:
440420
logger.error("HTTP error {} from endpoint {} ... retrying request".format(e.response.status_code, url))
441-
except TransientError as e:
442-
logger.warning("Recoverable error occurred at {} ... retrying request".format(url))
443421
except:
444422
raise
445423
return rsps

0 commit comments

Comments
 (0)