Merge pull request #1 from SlicingDice/feature/fix_errors_codacy

Feature/fix errors codacy

Author: wesleysimbiose

pyslicer/api.py

@@ -45,7 +45,8 @@ def status_code(self):
     def headers(self):
         return self.__headers
 
-    def _organize_keys(self, master_key, custom_key, read_key, write_key):
+    @staticmethod
+    def _organize_keys(master_key, custom_key, read_key, write_key):
         return {
             "master_key": master_key,
             "custom_key": custom_key,
@@ -130,7 +131,8 @@ def _handler_request(self, req):
                 self._set_properties_values(sd_response)
                 return sd_response.result
 
-    def _check_request(self, request):
+    @staticmethod
+    def _check_request(request):
         """Check if the request was successful
 
         Keyword arguments:

pyslicer/client.py

@@ -125,7 +125,8 @@ def _data_extraction_wrapper(self, url, query):
                 req_type="post",
                 key_level=0)
 
-    def _wrapper_test(self, test):
+    @staticmethod
+    def _wrapper_test(test):
         base_url = SlicingDice.BASE_URL
         if test:
             base_url += "/test"

pyslicer/exceptions.py

@@ -565,7 +565,7 @@ def __init__(self, *args, **kwargs):
 
 class QueryCountInvalidParameterErrorException(SlicingDiceException):
     def __init__(self, *args, **kwargs):
-        super(QueryLevelLimitException, self).__init__(
+        super(QueryCountInvalidParameterErrorException, self).__init__(
             self, *args, **kwargs)
 
 

pyslicer/utils/validators.py

@@ -138,7 +138,7 @@ def __init__(self, queries):
     def _valid_keys(self):
         if "fields" in self.data:
             value = self.data["fields"]
-            if type(value) != list:
+            if not isinstance(value, list):
                 raise exceptions.InvalidQueryException(
                     "The key 'fields' in query has a invalid value.")
             else:
@@ -148,7 +148,7 @@ def _valid_keys(self):
                         "have up to 10 fields.")
         if "limit" in self.data:
             limit = self.data['limit']
-            if type(limit) != int:
+            if not isinstance(limit, int):
                 raise exceptions.InvalidQueryException(
                     "The key 'limit' in query has a invalid value.")
             if limit > 100:
@@ -178,7 +178,7 @@ def _has_empty_field(self):
         if not all(self.data) or not all(self.data.values()):
             raise exceptions.InvalidIndexException(
                 "This index has invalid keys or values.")
-        for id, value in self.data.iteritems():
+        for value in self.data.values():
             # Value is a dictionary when it is an entity being indexed:
             # "my-entity": {"year": 2016}
             # It can also be a parameter, such as "auto-create-fields":

tests_and_examples/examples/aggregation.json

@@ -1664,7 +1664,7 @@
             "result": {
                 "boolean-test-field": [
                     {
-                        "value": "false",
+                        "value": "true",
                         "quantity": 50
                     }
                 ]

tests_and_examples/run_query_tests.py

@@ -137,7 +137,8 @@ def _append_timestamp_to_field_name(self, field):
 
         self.field_translation[old_name] = new_name
 
-    def _get_timestamp(self):
+    @staticmethod
+    def _get_timestamp():
         """Get integer timestamp in string format.
 
         Return:

tests_and_examples/test_name_generator.py

@@ -210,10 +210,8 @@ def main():
             open('examples/{}.json'.format(query_type)),
             object_pairs_hook=collections.OrderedDict)
 
-        for i in range(len(tests)):
-            tests[i]['name'] = generate_name(query_type, tests[i])
-
         for test in tests:
+            test['name'] = generate_name(query_type, test)
             print test['name']
 
         json.dump(tests,