Crash with cesium mod - zstd module packaging error

[ThatMG393]

Bug description

Steps to reproduce

1. Install Neoforge 1.21.1-21.1.173
2. Install AutoModpack and Sinytra with Forgified Fabric API
3. Launch

Expected behavior

Launches normally.

Actual behavior

Crashes.

Relevant logs

No response

Minecraft & Mod Loader versions

Neoforhe 1.21.1-21.1.173

Minecraft launcher

No response

Operating system

Linux

AutoModpack version

4.0.0-beta36

Other information

No response

Check list

• I have verified that the issue persists in the latest version of the mod.
• I have searched the existing issues and confirmed that this is not a duplicate.
• I have provided all the necessary information to reproduce the issue.
• I have verified that the issue does not occur without the AutoModpack - Ignore if you are reporting a mod conflict issue.

[Skidamek]

Launches completely fine for me, tested with https://modrinth.com/mod/connectiblechains mod and everything works.
Could you send logs?

[ThatMG393]

I can't get proper logs, sorry...

But I figured it out! It was Cesium that was causing the error, Cesium also packages Zstd on its jar so that's probably the issue.

This used to work on Forge 1.20.1. Any chance you can fix it?

[Skidamek]

Dev note: I feel like shadow jar is problematic here, i think i need to JiJ all my deps as separate jars and then load them separately with their original module names via a custom classloader similarly to how fabric/forge/connector load other mods. Otherwise it will be problem with any other mod using zstd as well or possibly even any other automodpack dependency. Plus, current way is gross.

[ThatMG393]

Dev note: I feel like shadow jar is problematic here, i think i need to JiJ all my deps as separate jars and then load them separately with their original module names via a custom classloader similarly to how fabric/forge/connector load other mods. Otherwise it will be problem with any other mod using zstd as well or possibly even any other automodpack dependency. Plus, current way is gross.

What if you relocate AutoModpack dependencies into different package names? (If I'm getting the issue correctly)

[Skidamek]

Zstd can't be relocated, since it uses native binaries