Skip to content

Commit eab3ba9

Browse files
committed
Put corrupt test images in a directory to simplify skipping them
1 parent 8a21a38 commit eab3ba9

File tree

4 files changed

+5
-11
lines changed

4 files changed

+5
-11
lines changed

mp4parse/tests/public.rs

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -30,12 +30,12 @@ static VIDEO_EME_CBCS_MP4: &str = "tests/bipbop_cbcs_video_init.mp4";
3030
static VIDEO_AV1_MP4: &str = "tests/tiny_av1.mp4";
3131
static IMAGE_AVIF: &str = "av1-avif/testFiles/Microsoft/Monochrome.avif";
3232
static IMAGE_AVIF_EXTENTS: &str = "tests/kodim-extents.avif";
33-
static IMAGE_AVIF_CORRUPT: &str = "tests/bug-1655846.avif";
34-
static IMAGE_AVIF_CORRUPT_2: &str = "tests/bug-1661347.avif";
35-
static IMAGE_AVIF_CORRUPT_3: &str = "tests/bad-ipma-version.avif";
33+
static IMAGE_AVIF_CORRUPT: &str = "tests/corrupt/bug-1655846.avif";
34+
static IMAGE_AVIF_CORRUPT_2: &str = "tests/corrupt/bug-1661347.avif";
35+
static IMAGE_AVIF_CORRUPT_3: &str = "tests/corrupt/bad-ipma-version.avif";
3636
static IMAGE_AVIF_GRID: &str = "av1-avif/testFiles/Microsoft/Summer_in_Tomsk_720p_5x4_grid.avif";
3737
static AVIF_TEST_DIRS: &[&str] = &["tests", "av1-avif/testFiles"];
38-
static AVIF_CORRUPT_IMAGES: &[&str] = &[IMAGE_AVIF_CORRUPT, IMAGE_AVIF_CORRUPT_2];
38+
static AVIF_CORRUPT_IMAGES: &str = "tests/corrupt";
3939

4040
// Adapted from https://github.com/GuillaumeGomez/audio-video-metadata/blob/9dff40f565af71d5502e03a2e78ae63df95cfd40/src/metadata.rs#L53
4141
#[test]
@@ -674,13 +674,7 @@ fn public_avif_read_samples() {
674674
eprintln!("Skipping {:?}", path);
675675
continue; // Skip directories, ReadMe.txt, etc.
676676
}
677-
if AVIF_CORRUPT_IMAGES
678-
.iter()
679-
.find(|&&corrupt| {
680-
std::fs::canonicalize(corrupt).unwrap() == path.canonicalize().unwrap()
681-
})
682-
.is_some()
683-
{
677+
if path.parent().unwrap() == Path::new(AVIF_CORRUPT_IMAGES) {
684678
eprintln!("Skipping {:?}", path);
685679
continue;
686680
}

0 commit comments

Comments
 (0)