Merge pull request #165 from Shopify/app-owned-metafields

nickwesselman · web-flow · commit 685e522ba5b7 · 2023-02-27T16:01:08.000-04:00
App owned metafields in templates and samples
diff --git a/checkout/rust/delivery-customization/default/input.graphql.liquid b/checkout/rust/delivery-customization/default/input.graphql.liquid
@@ -1,6 +1,6 @@
 query Input {
   deliveryCustomization {
-    metafield(namespace: "{{name | replace: " ", "-" | downcase}}", key: "function-configuration") {
+    metafield(namespace: "$app:{{name | replace: " ", "-" | downcase}}", key: "function-configuration") {
       value
     }
   }
diff --git a/checkout/rust/payment-customization/default/input.graphql.liquid b/checkout/rust/payment-customization/default/input.graphql.liquid
@@ -1,6 +1,6 @@
 query Input {
   paymentCustomization {
-    metafield(namespace: "{{name | replace: " ", "-" | downcase}}", key: "function-configuration") {
+    metafield(namespace: "$app:{{name | replace: " ", "-" | downcase}}", key: "function-configuration") {
       value
     }
   }
diff --git a/checkout/wasm/delivery-customization/default/input.graphql.liquid b/checkout/wasm/delivery-customization/default/input.graphql.liquid
@@ -1,6 +1,6 @@
 query Input {
   deliveryCustomization {
-    metafield(namespace: "{{name | replace: " ", "-" | downcase}}", key: "function-configuration") {
+    metafield(namespace: "$app:{{name | replace: " ", "-" | downcase}}", key: "function-configuration") {
       value
     }
   }
diff --git a/checkout/wasm/payment-customization/default/input.graphql.liquid b/checkout/wasm/payment-customization/default/input.graphql.liquid
@@ -1,6 +1,6 @@
 query Input {
   paymentCustomization {
-    metafield(namespace: "{{name | replace: " ", "-" | downcase}}", key: "function-configuration") {
+    metafield(namespace: "$app:{{name | replace: " ", "-" | downcase}}", key: "function-configuration") {
       value
     }
   }
diff --git a/discounts/javascript/product-discounts/default/input.graphql.liquid b/discounts/javascript/product-discounts/default/input.graphql.liquid
@@ -1,6 +1,6 @@
 query Input {
   discountNode {
-    metafield(namespace: "{{name | replace: " ", "-" | downcase}}", key: "function-configuration") {
+    metafield(namespace: "$app:{{name | replace: " ", "-" | downcase}}", key: "function-configuration") {
       value
     }
   }
diff --git a/discounts/rust/order-discounts/default/input.graphql.liquid b/discounts/rust/order-discounts/default/input.graphql.liquid
@@ -1,6 +1,6 @@
 query Input {
   discountNode {
-    metafield(namespace: "{{name | replace: " ", "-" | downcase}}", key: "function-configuration") {
+    metafield(namespace: "$app:{{name | replace: " ", "-" | downcase}}", key: "function-configuration") {
       value
     }
   }
diff --git a/discounts/rust/product-discounts/default/input.graphql.liquid b/discounts/rust/product-discounts/default/input.graphql.liquid
@@ -1,6 +1,6 @@
 query Input {
   discountNode {
-    metafield(namespace: "{{name | replace: " ", "-" | downcase}}", key: "function-configuration") {
+    metafield(namespace: "$app:{{name | replace: " ", "-" | downcase}}", key: "function-configuration") {
       value
     }
   }
diff --git a/discounts/rust/shipping-discounts/default/input.graphql.liquid b/discounts/rust/shipping-discounts/default/input.graphql.liquid
@@ -1,6 +1,6 @@
 query Input {
   discountNode {
-    metafield(namespace: "{{name | replace: " ", "-" | downcase}}", key: "function-configuration") {
+    metafield(namespace: "$app:{{name | replace: " ", "-" | downcase}}", key: "function-configuration") {
       value
     }
   }
diff --git a/discounts/wasm/order-discounts/default/input.graphql.liquid b/discounts/wasm/order-discounts/default/input.graphql.liquid
@@ -1,6 +1,6 @@
 query Input {
   discountNode {
-    metafield(namespace: "{{name | replace: " ", "-" | downcase}}", key: "function-configuration") {
+    metafield(namespace: "$app:{{name | replace: " ", "-" | downcase}}", key: "function-configuration") {
       value
     }
   }
diff --git a/discounts/wasm/product-discounts/default/input.graphql.liquid b/discounts/wasm/product-discounts/default/input.graphql.liquid
@@ -1,6 +1,6 @@
 query Input {
   discountNode {
-    metafield(namespace: "{{name | replace: " ", "-" | downcase}}", key: "function-configuration") {
+    metafield(namespace: "$app:{{name | replace: " ", "-" | downcase}}", key: "function-configuration") {
       value
     }
   }
diff --git a/discounts/wasm/shipping-discounts/default/input.graphql.liquid b/discounts/wasm/shipping-discounts/default/input.graphql.liquid
@@ -1,6 +1,6 @@
 query Input {
   discountNode {
-    metafield(namespace: "{{name | replace: " ", "-" | downcase}}", key: "function-configuration") {
+    metafield(namespace: "$app:{{name | replace: " ", "-" | downcase}}", key: "function-configuration") {
       value
     }
   }
diff --git a/sample-apps/delivery-customizations/extensions/delivery-customization/input.graphql b/sample-apps/delivery-customizations/extensions/delivery-customization/input.graphql
@@ -11,10 +11,7 @@ query Input {
     }
   }
   deliveryCustomization {
-    metafield(
-      namespace: "{{ app_name | replace: " ", "-" | downcase }}"
-      key: "function-configuration"
-    ) {
+    metafield(namespace: "$app:delivery-customization", key: "function-configuration") {
       value
     }
   }
diff --git a/sample-apps/delivery-customizations/web/metafields.js b/sample-apps/delivery-customizations/web/metafields.js
@@ -0,0 +1,4 @@
+export default {
+  namespace: '$app:delivery-customization',
+  key: "function-configuration",
+};
diff --git a/sample-apps/delivery-customizations/web/metafields.js.liquid b/sample-apps/delivery-customizations/web/metafields.js.liquid
diff --git a/sample-apps/payment-customizations/extensions/payment-customization/input.graphql b/sample-apps/payment-customizations/extensions/payment-customization/input.graphql
@@ -11,10 +11,7 @@ query Input {
     name
   }
   paymentCustomization {
-    metafield(
-      namespace: "{{ app_name | replace: " ", "-" | downcase }}"
-      key: "function-configuration"
-    ) {
+    metafield(namespace: "$app:payment-customization", key: "function-configuration") {
       value
     }
   }
diff --git a/sample-apps/payment-customizations/web/metafields.js b/sample-apps/payment-customizations/web/metafields.js
@@ -0,0 +1,4 @@
+export default {
+  namespace: '$app:payment-customization',
+  key: "function-configuration",
+};
diff --git a/sample-apps/payment-customizations/web/metafields.js.liquid b/sample-apps/payment-customizations/web/metafields.js.liquid

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`query Input {`
`2`	`2`	`deliveryCustomization {`
`3`		`- metafield(namespace: "{{name \| replace: " ", "-" \| downcase}}", key: "function-configuration") {`
	`3`	`+ metafield(namespace: "$app:{{name \| replace: " ", "-" \| downcase}}", key: "function-configuration") {`
`4`	`4`	`value`
`5`	`5`	`}`
`6`	`6`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`query Input {`
`2`	`2`	`paymentCustomization {`
`3`		`- metafield(namespace: "{{name \| replace: " ", "-" \| downcase}}", key: "function-configuration") {`
	`3`	`+ metafield(namespace: "$app:{{name \| replace: " ", "-" \| downcase}}", key: "function-configuration") {`
`4`	`4`	`value`
`5`	`5`	`}`
`6`	`6`	`}`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`query Input {`
`2`	`2`	`discountNode {`
`3`		`- metafield(namespace: "{{name \| replace: " ", "-" \| downcase}}", key: "function-configuration") {`
	`3`	`+ metafield(namespace: "$app:{{name \| replace: " ", "-" \| downcase}}", key: "function-configuration") {`
`4`	`4`	`value`
`5`	`5`	`}`
`6`	`6`	`}`