Merge pull request #57 from ShellyUSA/DanielWinks

Daniel winks

Author: DanielWinks

PackageManifests/ShellyWebhookDrivers/packageManifest.json

@@ -1,8 +1,8 @@
 {
   "packageName": "Shelly Webhook/Websocket Drivers",
   "author": "ShellyUSA, Daniel Winks",
-  "version": "2.3.1",
-  "releaseNotes": "2.3.1 Add Shelly TRV\r\nFixes for inputs on Gen 1 device not properly being created/updated\r\nAdd Shelly Pro Dual Cover PM\r\n Add Shelly Vintage Bulb, minor fixes for Dimmer\r\n Add Shelly Dimmer 1&2 support\r\nAdd Shelly 2.5 (Gen1). Fix missing cover functionality.\r\n2.0.5 Fix overflow issue on setting parent energy totals.\r\nFix null issue on setting parent energy totals\r\n2.0.3 Fix for cover child devices not getting coverId properly from device data\r\n2.0.3 Add drivers for Pro2PM, Pro3, Uni gen1 and gen2 to HPM. \r\n2.0.1 Change logging level on a few things to keep logs from warning about Shelly auth related messages. \r\n2.0.0 Added support for many more devices. Major rewrite of library code. 🥳\r\n1.2.0 Added Shelly Flood, Shelly PM Mini Gen3\r\n1.1.0 Added support for Bluetooth Gateway, Blu devices (button, motion, door/window), H&T (gen 1)\r\n1.0.0 Release of Shelly Plug US, Button 1, Motion 2, Shelly H&T (gen 2 and 3), and Shelly Gas",
+  "version": "2.3.2",
+  "releaseNotes": "2.3.2 Fix open/close commands on TRV\r\nAdd Shelly TRV\r\nFixes for inputs on Gen 1 device not properly being created/updated\r\nAdd Shelly Pro Dual Cover PM\r\n Add Shelly Vintage Bulb, minor fixes for Dimmer\r\n Add Shelly Dimmer 1&2 support\r\nAdd Shelly 2.5 (Gen1). Fix missing cover functionality.\r\n2.0.5 Fix overflow issue on setting parent energy totals.\r\nFix null issue on setting parent energy totals\r\n2.0.3 Fix for cover child devices not getting coverId properly from device data\r\n2.0.3 Add drivers for Pro2PM, Pro3, Uni gen1 and gen2 to HPM. \r\n2.0.1 Change logging level on a few things to keep logs from warning about Shelly auth related messages. \r\n2.0.0 Added support for many more devices. Major rewrite of library code. 🥳\r\n1.2.0 Added Shelly Flood, Shelly PM Mini Gen3\r\n1.1.0 Added support for Bluetooth Gateway, Blu devices (button, motion, door/window), H&T (gen 1)\r\n1.0.0 Release of Shelly Plug US, Button 1, Motion 2, Shelly H&T (gen 2 and 3), and Shelly Gas",
   "minimumHEVersion": "2.3.7.114",
   "dateReleased": "2024-02-10",
   "licenseFile": "https://raw.githubusercontent.com/ShellyUSA/Hubitat-Drivers/master/LICENSE",

ShellyDriverLibrary/ShellyUSA.ShellyUSA_Driver_Library.groovy

@@ -1663,19 +1663,27 @@ void setLastUpdated() {
 //Rollers
 @CompileStatic
 void open() {
-  if(isGen1Device() == true) {
-    parentSendGen1CommandAsync("/roller/${getDeviceDataValue('coverId')}/?go=open")
+  if(hasCapabilityValve() == true) {
+    if(isGen1Device() == true) { parentSendGen1CommandAsync("thermostat/0/?pos=100") }
   } else {
-    parentPostCommandSync(coverOpenCommand(getIntegerDeviceDataValue('coverId')))
+    if(isGen1Device() == true) {
+      parentSendGen1CommandAsync("/roller/${getDeviceDataValue('coverId')}/?go=open")
+    } else {
+      parentPostCommandSync(coverOpenCommand(getIntegerDeviceDataValue('coverId')))
+    }
   }
 }
 
 @CompileStatic
 void close() {
-  if(isGen1Device() == true) {
-    parentSendGen1CommandAsync("/roller/${getDeviceDataValue('coverId')}/?go=close")
+  if(hasCapabilityValve() == true) {
+    if(isGen1Device() == true) { parentSendGen1CommandAsync("thermostat/0/?pos=0")}
   } else {
-    parentPostCommandSync(coverCloseCommand(getIntegerDeviceDataValue('coverId')))
+    if(isGen1Device() == true) {
+      parentSendGen1CommandAsync("/roller/${getDeviceDataValue('coverId')}/?go=close")
+    } else {
+      parentPostCommandSync(coverCloseCommand(getIntegerDeviceDataValue('coverId')))
+    }
   }
 }