Skip to content

Commit 62500df

Browse files
committed
don't hardcode default values
1 parent f9176f3 commit 62500df

File tree

3 files changed

+11
-17
lines changed

3 files changed

+11
-17
lines changed

AiServer.ServiceInterface/Comfy/ComfyExtensions.cs

Lines changed: 8 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -18,21 +18,18 @@ public static ComfyWorkflowRequest ApplyModelDefaults(this ComfyWorkflowRequest
1818
resObject = new ComfyWorkflowRequest
1919
{
2020
Model = request.Model ?? appConfig.DefaultModel?.Filename!,
21-
Width = request.Width is null or 0 ? modelSettings?.Width ?? 1024 : request.Width,
22-
Height = request.Height is null or 0 ? modelSettings?.Height ?? 1024 : request.Height,
21+
Width = request.Width,
22+
Height = request.Height,
2323
BatchSize = request.BatchSize is 0 ? 1 : request.BatchSize,
2424
Seed = request.Seed is null or 0 ? Random.Shared.Next() : request.Seed,
2525
PositivePrompt = request.PositivePrompt,
2626
NegativePrompt = request.NegativePrompt is null or ""
27-
? (modelSettings?.NegativePrompt ?? ",low quality, blurry, noisy, compression artifacts")
28-
: request.NegativePrompt + (modelSettings?.NegativePrompt ??
29-
",low quality, blurry, noisy, compression artifacts"),
30-
Scheduler = request.Scheduler is null or ""
31-
? modelSettings?.Scheduler ?? "normal"
32-
: request.Scheduler,
33-
Steps = request.Steps is null or 0 ? modelSettings?.Steps ?? 25 : request.Steps,
34-
CfgScale = request.CfgScale is null or 0 ? modelSettings?.CfgScale ?? 7 : request.CfgScale,
35-
Sampler = request.Sampler ?? (modelSettings?.Sampler ?? ComfySampler.euler_ancestral),
27+
? "low quality, blurry, noisy, compression artifacts"
28+
: request.NegativePrompt + (",low quality, blurry, noisy, compression artifacts"),
29+
Scheduler = request.Scheduler,
30+
Steps = request.Steps,
31+
CfgScale = request.CfgScale,
32+
Sampler = request.Sampler,
3633
TaskType = ComfyTaskType.TextToImage
3734
};
3835
break;

AiServer.ServiceInterface/Generation/ComfyProvider.cs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -112,8 +112,7 @@ private ComfyClient GetClient(MediaProvider provider)
112112
AiTaskType.SpeechToText => ComfyTaskType.SpeechToText,
113113
_ => throw new ArgumentOutOfRangeException()
114114
};
115-
comfyWorkflowReq =
116-
comfyWorkflowReq.ApplyModelDefaults(AppConfig.Instance, modelSettings.ConvertTo<ComfyApiModelSettings>());
115+
comfyWorkflowReq = comfyWorkflowReq.ApplyModelDefaults(AppConfig.Instance, modelSettings.ConvertTo<ComfyApiModelSettings>());
117116
var response = await comfyClient.PromptGenerationAsync(comfyWorkflowReq, token, waitResult: true);
118117
var status = await comfyClient.GetWorkflowStatusAsync(response.PromptId, token);
119118
var previewQ = GetPreviewQueryStringByTaskType(request.TaskType ?? AiTaskType.TextToImage);

AiServer.ServiceModel/Types/ComfyApi.cs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,19 +38,17 @@ public class ComfyWorkflowRequest
3838
public Stream? MaskInput { get; set; }
3939

4040
public ComfySampler? Sampler { get; set; }
41-
public string? Scheduler { get; set; } = "normal";
41+
public string? Scheduler { get; set; }
4242
public double? CfgScale { get; set; }
4343
public double? Denoise { get; set; }
4444

45-
public string? UpscaleModel { get; set; } = "RealESRGAN_x2.pth";
45+
public string? UpscaleModel { get; set; }
4646

4747
public int? Width { get; set; }
4848
public int? Height { get; set; }
4949

5050
public ComfyTaskType TaskType { get; set; }
5151
public string? Clip { get; set; }
52-
53-
public string? Vae { get; set; }
5452
public double? SampleLength { get; set; }
5553
public ComfyMaskSource MaskChannel { get; set; }
5654
}

0 commit comments

Comments
 (0)