Skip to content

Commit ef9309f

Browse files
committed
Tests: Update TagLib MPEG tests for new behavior
1 parent 28fa0d8 commit ef9309f

File tree

1 file changed

+6
-78
lines changed

1 file changed

+6
-78
lines changed

tests/taglib/test_mpeg.rs

Lines changed: 6 additions & 78 deletions
Original file line numberDiff line numberDiff line change
@@ -283,93 +283,21 @@ fn test_repeated_save_3() {
283283
}
284284

285285
#[test]
286+
#[ignore]
286287
fn test_empty_id3v2() {
287-
let mut file = temp_file!("tests/taglib/data/xing.mp3");
288-
289-
{
290-
let mut f = MPEGFile::read_from(&mut file, ParseOptions::new()).unwrap();
291-
file.rewind().unwrap();
292-
293-
let mut id3v2 = ID3v2Tag::default();
294-
id3v2.set_title(String::from("0123456789"));
295-
f.set_id3v2(id3v2);
296-
f.save_to(&mut file).unwrap();
297-
}
298-
file.rewind().unwrap();
299-
{
300-
let mut f = MPEGFile::read_from(&mut file, ParseOptions::new()).unwrap();
301-
file.rewind().unwrap();
302-
303-
let mut id3v2 = ID3v2Tag::default();
304-
id3v2.set_title(String::new());
305-
f.set_id3v2(id3v2);
306-
f.save_to(&mut file).unwrap();
307-
}
308-
file.rewind().unwrap();
309-
{
310-
let f = MPEGFile::read_from(&mut file, ParseOptions::new()).unwrap();
311-
assert!(f.id3v2().is_none());
312-
}
288+
// Marker test, Lofty accepts empty strings as valid values
313289
}
314290

315291
#[test]
292+
#[ignore]
316293
fn test_empty_id3v1() {
317-
let mut file = temp_file!("tests/taglib/data/xing.mp3");
318-
319-
{
320-
let mut f = MPEGFile::read_from(&mut file, ParseOptions::new()).unwrap();
321-
file.rewind().unwrap();
322-
323-
let mut id3v1 = ID3v1Tag::default();
324-
id3v1.set_title(String::from("0123456789"));
325-
f.set_id3v1(id3v1);
326-
f.save_to(&mut file).unwrap();
327-
}
328-
file.rewind().unwrap();
329-
{
330-
let mut f = MPEGFile::read_from(&mut file, ParseOptions::new()).unwrap();
331-
file.rewind().unwrap();
332-
333-
let mut id3v1 = ID3v1Tag::default();
334-
id3v1.set_title(String::new());
335-
f.set_id3v1(id3v1);
336-
f.save_to(&mut file).unwrap();
337-
}
338-
file.rewind().unwrap();
339-
{
340-
let f = MPEGFile::read_from(&mut file, ParseOptions::new()).unwrap();
341-
assert!(f.id3v1().is_none());
342-
}
294+
// Marker test, Lofty accepts empty strings as valid values
343295
}
344296

345297
#[test]
298+
#[ignore]
346299
fn test_empty_ape() {
347-
let mut file = temp_file!("tests/taglib/data/xing.mp3");
348-
349-
{
350-
let mut f = MPEGFile::read_from(&mut file, ParseOptions::new()).unwrap();
351-
file.rewind().unwrap();
352-
353-
let mut ape = ApeTag::default();
354-
ape.set_title(String::from("0123456789"));
355-
f.set_ape(ape);
356-
f.save_to(&mut file).unwrap();
357-
}
358-
file.rewind().unwrap();
359-
{
360-
let mut f = MPEGFile::read_from(&mut file, ParseOptions::new()).unwrap();
361-
file.rewind().unwrap();
362-
363-
let mut ape = ApeTag::default();
364-
ape.set_title(String::new());
365-
f.set_ape(ape);
366-
f.save_to(&mut file).unwrap();
367-
}
368-
file.rewind().unwrap();
369-
{
370-
let f = MPEGFile::read_from(&mut file, ParseOptions::new()).unwrap();
371-
assert!(f.ape().is_none());
372-
}
300+
// Marker test, Lofty accepts empty strings as valid values
373301
}
374302

375303
#[test]

0 commit comments

Comments
 (0)