Skip to content

Commit d4af653

Browse files
committed
APE: Properly convert track/disk number pairs when writing
This also changes the default track/disk number to `DEFAULT_NUMBER_IN_PAIR`. closes #159
1 parent 1879c46 commit d4af653

File tree

10 files changed

+355
-78
lines changed

10 files changed

+355
-78
lines changed

CHANGELOG.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,13 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
66

77
## [Unreleased]
88

9+
## Changed
10+
- **APE**: The default track/disk number is now `0` to line up with ID3v2.
11+
This is only used when `set_{track, disk}_total` is used without a corresponding `set_{track, disk}`.
12+
13+
## Fixed
14+
- **APE**: Track/Disk number pairs are properly converted when writing ([issue](https://github.com/Serial-ATA/lofty-rs/issues/159)) ([PR](https://github.com/Serial-ATA/lofty-rs/pull/216))
15+
916
## [0.14.0] - 2023-06-08
1017

1118
### Added

Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ byteorder = "1.4.3"
1818
# ID3 compressed frames
1919
flate2 = { version = "1.0.26", optional = true }
2020
# Proc macros
21-
lofty_attr = "0.8.0"
21+
lofty_attr = { path = "lofty_attr" }
2222
# Debug logging
2323
log = "0.4.18"
2424
# OGG Vorbis/Opus

lofty_attr/src/internal.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ pub(crate) fn init_write_lookup(
4646
insert!(map, Ape, {
4747
lofty::ape::tag::ApeTagRef {
4848
read_only: false,
49-
items: lofty::ape::tag::tagitems_into_ape(tag.items()),
49+
items: lofty::ape::tag::tagitems_into_ape(tag),
5050
}
5151
.write_to(data)
5252
});

0 commit comments

Comments
 (0)