Tests: Fix TagLib TestMPEG::testFuzzedFile

Serial-ATA · Serial-ATA · commit 3438c680cb22 · 2023-12-03T16:25:07.000-05:00
The behavior here is weird, the file contains multiple strings that are completely broken. Somehow, TagLib considers the file to be "valid", with it containing no MPEG frames. That doesn't seem correct on their end.
diff --git a/tests/taglib/test_mpeg.rs b/tests/taglib/test_mpeg.rs
@@ -176,7 +176,7 @@ fn test_duplicate_id3v2() {
 #[test]
 fn test_fuzzed_file() {
 	let mut file = File::open("tests/taglib/data/excessive_alloc.mp3").unwrap();
-	let _ = MpegFile::read_from(&mut file, ParseOptions::new()).unwrap();
+	assert!(MpegFile::read_from(&mut file, ParseOptions::new()).is_err())
 }
 
 #[test]

Original file line number	Diff line number	Diff line change
`@@ -176,7 +176,7 @@ fn test_duplicate_id3v2() {`
`176`	`176`	`#[test]`
`177`	`177`	`fn test_fuzzed_file() {`
`178`	`178`	`let mut file = File::open("tests/taglib/data/excessive_alloc.mp3").unwrap();`
`179`		`- let _ = MpegFile::read_from(&mut file, ParseOptions::new()).unwrap();`
	`179`	`+ assert!(MpegFile::read_from(&mut file, ParseOptions::new()).is_err())`
`180`	`180`	`}`
`181`	`181`
`182`	`182`	`#[test]`