Skip to content

Commit 379bf06

Browse files
committed
fix php 7.4 compatibility problems
1 parent b349c65 commit 379bf06

File tree

3 files changed

+30
-2
lines changed

3 files changed

+30
-2
lines changed

.github/workflows/ci.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,10 @@ jobs:
1313
strategy:
1414
matrix:
1515
include:
16+
- mw: 'REL1_39'
17+
php: 7.4
18+
type: normal
19+
experimental: false
1620
- mw: 'REL1_39'
1721
php: 8.0
1822
type: coverage

RELEASE-NOTES.md

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,29 @@
11
This file contains the RELEASE-NOTES of the **Semantic Scribunto** (a.k.a. SSC) extension.
22

3+
## 2.3.2
4+
5+
Released on July 23, 2024
6+
7+
* Fixes PHP 7.3 issue
8+
9+
## 2.3.1
10+
11+
Released on July 16, 2024
12+
13+
* Fixes message registration
14+
15+
## 2.3.0
16+
17+
Released on July 16, 2024
18+
19+
* Raising minimum requirement to MW 1.39 and SMW 4.1
20+
* Switch unit tests from tavis to github
21+
* Add new ci sets for MW > 1.39
22+
* Switch hook registration to default MW schema
23+
* Switch to MW autoloader, abandoning composer autoloader
24+
* Fix unit tests
25+
26+
327
## 2.2.0
428

529
Released on January 19, 2022.

src/ScribuntoLuaLibrary.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -336,7 +336,7 @@ private function getLibraryFactory(): LibraryFactory {
336336
*
337337
* @return bool
338338
*/
339-
private function isAQueryResult( mixed $queryResult ): bool {
339+
private function isAQueryResult( $queryResult ): bool {
340340
return is_a( $queryResult, QueryResult::class );
341341
}
342342

@@ -350,7 +350,7 @@ private function isAQueryResult( mixed $queryResult ): bool {
350350
*
351351
* @return array
352352
*/
353-
private function processLuaArguments( mixed $arguments ) {
353+
private function processLuaArguments( $arguments ) {
354354

355355
if ( empty( $arguments ) ) {
356356
return [];

0 commit comments

Comments
 (0)