From b04648fce19cd388e67f829e577ada7d688289e3 Mon Sep 17 00:00:00 2001 From: Simon Benzer Date: Sat, 3 May 2025 10:44:53 -0400 Subject: [PATCH 1/4] [rb] Linting Updates --- examples/ruby/spec/browsers/safari_spec.rb | 2 +- examples/ruby/spec/drivers/http_client_spec.rb | 2 ++ examples/ruby/spec/hello/hello_selenium.rb | 2 ++ examples/ruby/spec/interactions/browser_spec.rb | 2 ++ examples/ruby/spec/interactions/navigation_spec.rb | 2 ++ 5 files changed, 9 insertions(+), 1 deletion(-) diff --git a/examples/ruby/spec/browsers/safari_spec.rb b/examples/ruby/spec/browsers/safari_spec.rb index a26006070148..e492a5db58b9 100644 --- a/examples/ruby/spec/browsers/safari_spec.rb +++ b/examples/ruby/spec/browsers/safari_spec.rb @@ -39,4 +39,4 @@ local_driver = Selenium::WebDriver.for :safari expect(local_driver.capabilities.browser_name).to eq 'Safari Technology Preview' end -end \ No newline at end of file +end diff --git a/examples/ruby/spec/drivers/http_client_spec.rb b/examples/ruby/spec/drivers/http_client_spec.rb index 4a6b05d3b086..b8fdc6e9a675 100644 --- a/examples/ruby/spec/drivers/http_client_spec.rb +++ b/examples/ruby/spec/drivers/http_client_spec.rb @@ -1,3 +1,5 @@ +# frozen_string_literal: true + require 'spec_helper' RSpec.describe 'HTTP Client' do diff --git a/examples/ruby/spec/hello/hello_selenium.rb b/examples/ruby/spec/hello/hello_selenium.rb index c8078fe08a64..52b2d69d81f8 100644 --- a/examples/ruby/spec/hello/hello_selenium.rb +++ b/examples/ruby/spec/hello/hello_selenium.rb @@ -1,3 +1,5 @@ +# frozen_string_literal: true + require 'selenium-webdriver' driver = Selenium::WebDriver.for :chrome diff --git a/examples/ruby/spec/interactions/browser_spec.rb b/examples/ruby/spec/interactions/browser_spec.rb index 8bc281c163aa..f404a6d9eee4 100644 --- a/examples/ruby/spec/interactions/browser_spec.rb +++ b/examples/ruby/spec/interactions/browser_spec.rb @@ -1,3 +1,5 @@ +# frozen_string_literal: true + require 'spec_helper' RSpec.describe 'Browser' do diff --git a/examples/ruby/spec/interactions/navigation_spec.rb b/examples/ruby/spec/interactions/navigation_spec.rb index 36c60e4ace26..badebb5bc0b6 100644 --- a/examples/ruby/spec/interactions/navigation_spec.rb +++ b/examples/ruby/spec/interactions/navigation_spec.rb @@ -1,3 +1,5 @@ +# frozen_string_literal: true + require 'spec_helper' RSpec.describe 'Browser' do From 9d2fdc87b0a04d41d7f15f6e2b1d514d1b1a4d92 Mon Sep 17 00:00:00 2001 From: Simon Benzer Date: Sat, 3 May 2025 10:54:56 -0400 Subject: [PATCH 2/4] rest of offenses --- examples/ruby/spec/bidi/logging_spec.rb | 2 ++ examples/ruby/spec/browsers/chrome_spec.rb | 3 ++- examples/ruby/spec/browsers/edge_spec.rb | 5 +++-- examples/ruby/spec/browsers/safari_spec.rb | 4 +++- 4 files changed, 10 insertions(+), 4 deletions(-) diff --git a/examples/ruby/spec/bidi/logging_spec.rb b/examples/ruby/spec/bidi/logging_spec.rb index b07b93342628..df010daae8e3 100644 --- a/examples/ruby/spec/bidi/logging_spec.rb +++ b/examples/ruby/spec/bidi/logging_spec.rb @@ -1,3 +1,5 @@ +# frozen_string_literal: true + require 'spec_helper' RSpec.describe 'Logging' do diff --git a/examples/ruby/spec/browsers/chrome_spec.rb b/examples/ruby/spec/browsers/chrome_spec.rb index c15f4d88a978..81fe78c6ed08 100644 --- a/examples/ruby/spec/browsers/chrome_spec.rb +++ b/examples/ruby/spec/browsers/chrome_spec.rb @@ -131,7 +131,8 @@ 'offline' => false, 'latency' => 100, 'download_throughput' => 200, - 'upload_throughput' => 200) + 'upload_throughput' => 200 + ) end it 'gets the browser logs' do diff --git a/examples/ruby/spec/browsers/edge_spec.rb b/examples/ruby/spec/browsers/edge_spec.rb index 225f8c601c40..5820fab3e799 100644 --- a/examples/ruby/spec/browsers/edge_spec.rb +++ b/examples/ruby/spec/browsers/edge_spec.rb @@ -131,7 +131,8 @@ 'offline' => false, 'latency' => 100, 'download_throughput' => 200, - 'upload_throughput' => 200) + 'upload_throughput' => 200 + ) end it 'gets the browser logs' do @@ -164,6 +165,6 @@ def driver_finder def permission(name) @driver.execute_async_script('callback = arguments[arguments.length - 1];' \ - 'callback(navigator.permissions.query({name: arguments[0]}));', name)['state'] + 'callback(navigator.permissions.query({name: arguments[0]}));', name)['state'] end end diff --git a/examples/ruby/spec/browsers/safari_spec.rb b/examples/ruby/spec/browsers/safari_spec.rb index e492a5db58b9..25b4898595da 100644 --- a/examples/ruby/spec/browsers/safari_spec.rb +++ b/examples/ruby/spec/browsers/safari_spec.rb @@ -2,6 +2,7 @@ require 'spec_helper' +# rubocop:disable RSpec/MultipleDescribes RSpec.describe 'Safari', exclusive: {platform: :macosx} do describe 'Options' do it 'basic options' do @@ -33,7 +34,8 @@ end end -RSpec.describe 'Safari Technology Preview', skip: "This test is being skipped as GitHub Actions have no support for Safari Technology Preview" do +RSpec.describe 'Safari Technology Preview', skip: 'This test is being skipped as GitHub Actions ' \ + 'have no support for Safari Technology Preview' do it 'sets the technology preview' do Selenium::WebDriver::Safari.technology_preview! local_driver = Selenium::WebDriver.for :safari From 504811902d40c514c19ac7fa0d2060ca832aaea2 Mon Sep 17 00:00:00 2001 From: Simon Benzer <69980130+shbenzer@users.noreply.github.com> Date: Sat, 3 May 2025 10:58:11 -0400 Subject: [PATCH 3/4] renable RSpec/MultipleDescribes after disabling --- examples/ruby/spec/browsers/safari_spec.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/examples/ruby/spec/browsers/safari_spec.rb b/examples/ruby/spec/browsers/safari_spec.rb index 25b4898595da..f887340bd5a0 100644 --- a/examples/ruby/spec/browsers/safari_spec.rb +++ b/examples/ruby/spec/browsers/safari_spec.rb @@ -42,3 +42,4 @@ expect(local_driver.capabilities.browser_name).to eq 'Safari Technology Preview' end end +# rubocop:disable RSpec/MultipleDescribes From 57554c10a8765a75f6b0f05bf3797a592ea51d46 Mon Sep 17 00:00:00 2001 From: Simon Benzer <69980130+shbenzer@users.noreply.github.com> Date: Sat, 3 May 2025 11:05:18 -0400 Subject: [PATCH 4/4] oops --- examples/ruby/spec/browsers/safari_spec.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/examples/ruby/spec/browsers/safari_spec.rb b/examples/ruby/spec/browsers/safari_spec.rb index f887340bd5a0..64e89ee22926 100644 --- a/examples/ruby/spec/browsers/safari_spec.rb +++ b/examples/ruby/spec/browsers/safari_spec.rb @@ -42,4 +42,4 @@ expect(local_driver.capabilities.browser_name).to eq 'Safari Technology Preview' end end -# rubocop:disable RSpec/MultipleDescribes +# rubocop:enable RSpec/MultipleDescribes