Skip to content

Commit 2a221fb

Browse files
Update dependency selenium to v4.33.0 (#2293)
* Update dependency selenium to v4.33.0 * Bumping versions * Bumping versions * Bumping versions * Starting firefox with flag * Bumping versions * Bumping versions * Disabling test --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Diego Molina <diemol@gmail.com>
1 parent 70ddda9 commit 2a221fb

File tree

20 files changed

+51
-46
lines changed

20 files changed

+51
-46
lines changed

examples/dotnet/SeleniumDocs/BaseTest.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ public class BaseTest
1717
protected IWebDriver driver;
1818
protected Uri GridUrl;
1919
private Process _webserverProcess;
20-
private const string ServerJarName = "selenium-server-4.32.0.jar";
20+
private const string ServerJarName = "selenium-server-4.33.0.jar";
2121
private static readonly string BaseDirectory = AppContext.BaseDirectory;
2222
private const string RelativePathToGrid = "../../../../../";
2323
private readonly string _examplesDirectory = Path.GetFullPath(Path.Combine(BaseDirectory, RelativePathToGrid));
@@ -111,4 +111,4 @@ private async Task EnsureGridIsRunningAsync()
111111
}
112112
}
113113
}
114-
}
114+
}

examples/dotnet/SeleniumDocs/BiDi/CDP/NetworkTest.cs

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,8 +4,8 @@
44
using OpenQA.Selenium;
55
using OpenQA.Selenium.DevTools;
66
using System.Linq;
7-
using OpenQA.Selenium.DevTools.V132.Network;
8-
using OpenQA.Selenium.DevTools.V132.Performance;
7+
using OpenQA.Selenium.DevTools.V137.Network;
8+
using OpenQA.Selenium.DevTools.V137.Performance;
99

1010

1111
namespace SeleniumDocs.BiDi.CDP
@@ -16,7 +16,7 @@ public class NetworkTest : BaseTest
1616
[TestInitialize]
1717
public void Startup()
1818
{
19-
StartDriver("132");
19+
StartDriver("137");
2020
}
2121

2222
[TestMethod]
@@ -109,9 +109,9 @@ public async Task PerformanceMetrics()
109109
driver.Url = "https://www.selenium.dev/selenium/web/frameset.html";
110110

111111
var session = ((IDevTools)driver).GetDevToolsSession();
112-
var domains = session.GetVersionSpecificDomains<OpenQA.Selenium.DevTools.V132.DevToolsSessionDomains>();
112+
var domains = session.GetVersionSpecificDomains<OpenQA.Selenium.DevTools.V137.DevToolsSessionDomains>();
113113

114-
await domains.Performance.Enable(new OpenQA.Selenium.DevTools.V132.Performance.EnableCommandSettings());
114+
await domains.Performance.Enable(new OpenQA.Selenium.DevTools.V137.Performance.EnableCommandSettings());
115115
var metricsResponse =
116116
await session.SendCommand<GetMetricsCommandSettings, GetMetricsCommandResponse>(
117117
new GetMetricsCommandSettings()
@@ -130,8 +130,8 @@ await session.SendCommand<GetMetricsCommandSettings, GetMetricsCommandResponse>(
130130
public async Task SetCookie()
131131
{
132132
var session = ((IDevTools)driver).GetDevToolsSession();
133-
var domains = session.GetVersionSpecificDomains<OpenQA.Selenium.DevTools.V132.DevToolsSessionDomains>();
134-
await domains.Network.Enable(new OpenQA.Selenium.DevTools.V132.Network.EnableCommandSettings());
133+
var domains = session.GetVersionSpecificDomains<OpenQA.Selenium.DevTools.V137.DevToolsSessionDomains>();
134+
await domains.Network.Enable(new OpenQA.Selenium.DevTools.V137.Network.EnableCommandSettings());
135135

136136
var cookieCommandSettings = new SetCookieCommandSettings
137137
{
@@ -148,4 +148,4 @@ public async Task SetCookie()
148148
}
149149

150150
}
151-
}
151+
}

examples/dotnet/SeleniumDocs/SeleniumDocs.csproj

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,8 @@
1010
<PackageReference Include="Microsoft.IdentityModel.Tokens" Version="7.7.1" />
1111
<PackageReference Include="MSTest.TestAdapter" Version="3.6.0" />
1212
<PackageReference Include="MSTest.TestFramework" Version="3.6.0" />
13-
<PackageReference Include="Selenium.Support" Version="4.31.0" />
14-
<PackageReference Include="Selenium.WebDriver" Version="4.31.0" />
13+
<PackageReference Include="Selenium.Support" Version="4.33.0" />
14+
<PackageReference Include="Selenium.WebDriver" Version="4.33.0" />
1515
</ItemGroup>
1616

1717
<ItemGroup>

examples/java/pom.xml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
<maven.compiler.source>17</maven.compiler.source>
1414
<maven.compiler.target>17</maven.compiler.target>
1515
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
16-
<selenium.version>4.31.0</selenium.version>
16+
<selenium.version>4.33.0</selenium.version>
1717
</properties>
1818

1919
<repositories>

examples/java/src/test/java/dev/selenium/bidi/cdp/CdpApiTest.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,9 +16,9 @@
1616
import org.openqa.selenium.chrome.ChromeOptions;
1717
import org.openqa.selenium.devtools.DevTools;
1818
import org.openqa.selenium.devtools.HasDevTools;
19-
import org.openqa.selenium.devtools.v134.browser.Browser;
20-
import org.openqa.selenium.devtools.v134.network.Network;
21-
import org.openqa.selenium.devtools.v134.network.model.Headers;
19+
import org.openqa.selenium.devtools.v137.browser.Browser;
20+
import org.openqa.selenium.devtools.v137.network.Network;
21+
import org.openqa.selenium.devtools.v137.network.model.Headers;
2222
import org.openqa.selenium.support.ui.WebDriverWait;
2323

2424
public class CdpApiTest extends BaseTest {
@@ -27,7 +27,7 @@ public class CdpApiTest extends BaseTest {
2727
@BeforeEach
2828
public void createSession() {
2929
ChromeOptions options = getDefaultChromeOptions();
30-
options.setBrowserVersion("134");
30+
options.setBrowserVersion("136");
3131
driver = new ChromeDriver(options);
3232
wait = new WebDriverWait(driver, Duration.ofSeconds(10));
3333
}

examples/java/src/test/java/dev/selenium/bidi/cdp/NetworkTest.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,10 +21,10 @@
2121
import org.openqa.selenium.devtools.DevTools;
2222
import org.openqa.selenium.devtools.HasDevTools;
2323
import org.openqa.selenium.devtools.NetworkInterceptor;
24-
import org.openqa.selenium.devtools.v134.browser.Browser;
25-
import org.openqa.selenium.devtools.v134.network.Network;
26-
import org.openqa.selenium.devtools.v134.performance.Performance;
27-
import org.openqa.selenium.devtools.v134.performance.model.Metric;
24+
import org.openqa.selenium.devtools.v137.browser.Browser;
25+
import org.openqa.selenium.devtools.v137.network.Network;
26+
import org.openqa.selenium.devtools.v137.performance.Performance;
27+
import org.openqa.selenium.devtools.v137.performance.model.Metric;
2828
import org.openqa.selenium.remote.http.*;
2929
import org.openqa.selenium.support.ui.WebDriverWait;
3030

examples/java/src/test/java/dev/selenium/browsers/FirefoxTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ public void fullPageScreenshot() throws Exception {
192192

193193
@Test
194194
public void setContext() {
195-
driver = startFirefoxDriver();
195+
driver = startFirefoxDriver(new FirefoxOptions().addArguments("-remote-allow-system-access"));
196196

197197
((HasContext) driver).setContext(FirefoxCommandContext.CHROME);
198198
driver.executeScript("console.log('Inside Chrome context');");

examples/java/src/test/java/dev/selenium/selenium_manager/SeleniumManagerUsageDemo.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,14 @@
11
package dev.selenium.selenium_manager;
22

3+
import org.junit.jupiter.api.Disabled;
34
import org.junit.jupiter.api.Test;
45
import org.openqa.selenium.WebDriver;
56
import org.openqa.selenium.chrome.ChromeDriver;
67

78
public class SeleniumManagerUsageDemo {
89

910
@Test
11+
@Disabled("This test is just for demo purposes and should not be run in CI")
1012
public void testSetupWithoutManager() {
1113
System.setProperty("webdriver.chrome.driver", "/path/to/chromedriver");
1214
WebDriver driver = new ChromeDriver();
@@ -20,5 +22,5 @@ public void testSetupWithManager() {
2022
driver.get("https://www.selenium.dev/documentation/selenium_manager/");
2123
driver.quit();
2224
}
23-
25+
2426
}

examples/python/requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
selenium==4.31.0
1+
selenium==4.33.0
22
pytest==8.3.5
33
trio==0.30.0
44
pytest-trio==0.8.0

examples/python/tests/bidi/cdp/test_network.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
import pytest
44
from selenium.webdriver.common.by import By
5-
from selenium.webdriver.common.devtools.v134.network import Headers
5+
from selenium.webdriver.common.devtools.v137.network import Headers
66

77

88
@pytest.mark.trio

0 commit comments

Comments
 (0)