Skip to content

Commit 165e509

Browse files
committed
Fix safari test
1 parent 34cdad7 commit 165e509

File tree

2 files changed

+8
-5
lines changed

2 files changed

+8
-5
lines changed

.github/workflows/ruby-examples.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@ jobs:
3535
if: matrix.os == 'macos-latest'
3636
run: |
3737
brew install --cask safari-technology-preview
38+
sudo safaridriver --enable
3839
- name: Remove driver directories Windows
3940
if: matrix.os == 'windows-latest'
4041
run: |
@@ -55,7 +56,7 @@ jobs:
5556
bundler-cache: true
5657
- name: Install Gems Nightly non-Windows
5758
if: matrix.release == 'nightly' && matrix.os != 'windows-latest'
58-
run:
59+
run:
5960
|
6061
latest_nightly_webdriver=$(./scripts/latest-nightly-version.sh rubygems selenium-webdriver)
6162
cd examples/ruby
@@ -66,7 +67,7 @@ jobs:
6667
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
6768
- name: Install Gems Nightly Windows
6869
if: matrix.release == 'nightly' && matrix.os == 'windows-latest'
69-
run:
70+
run:
7071
|
7172
$latest_nightly_webdriver = ./scripts/latest-nightly-version.ps1 rubygems selenium-webdriver
7273
cd examples/ruby
@@ -88,7 +89,7 @@ jobs:
8889
if: matrix.os == 'macos-latest'
8990
run: |
9091
# Check if safaridriver exists
91-
if [[ ! -f "/Applications/Safari Technology Preview.app/Contents/MacOS/safaridriver" ]]; then
92+
if [[ ! -x "/Applications/Safari Technology Preview.app/Contents/MacOS/safaridriver" ]]; then
9293
echo "safaridriver not found. Exiting."
9394
exit 1
9495
fi

examples/ruby/spec/browsers/safari_spec.rb

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
describe 'Service' do
1414
let(:directory) { "#{Dir.home}/Library/Logs/com.apple.WebDriver/*" }
1515

16-
it 'enable logs' do
16+
it 'enables logs' do
1717
original_count = Dir[directory].length
1818
service = Selenium::WebDriver::Service.safari
1919

@@ -31,10 +31,12 @@
3131
}.to raise_error(Selenium::WebDriver::Error::WebDriverError, /Safari Service does not support setting log output/)
3232
end
3333
end
34+
end
3435

36+
RSpec.describe 'Safari Technology Preview' do
3537
it 'sets the technology preview' do
3638
Selenium::WebDriver::Safari.technology_preview!
3739
local_driver = Selenium::WebDriver.for :safari
3840
expect(local_driver.capabilities.browser_name).to eq 'Safari Technology Preview'
3941
end
40-
end
42+
end

0 commit comments

Comments
 (0)