From 3da347f2c9fa407534e0ed5aacda31a0bd2f55d6 Mon Sep 17 00:00:00 2001
From: Santiago Cecena <santiago.cecena@encora.com>
Date: Wed, 18 Jun 2025 23:56:23 -0700
Subject: [PATCH 1/5] Add visibility check to selectByVisibleText in Select
 class

This change updates the selectByVisibleText method to prevent
selecting <option> elements that are hidden via CSS properties:
"display: none", "visibility: hidden", and "opacity: 0" or "0.0".

It uses the existing hasCssPropertyAndVisible method to ensure
that only visible options can be selected, making this method
consistent with selectByContainsVisibleText, which already has
this behavior.

Fixes #15265
---
 java/src/org/openqa/selenium/support/ui/Select.java | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/java/src/org/openqa/selenium/support/ui/Select.java b/java/src/org/openqa/selenium/support/ui/Select.java
index 264585e5417f6..6c611d55f447d 100644
--- a/java/src/org/openqa/selenium/support/ui/Select.java
+++ b/java/src/org/openqa/selenium/support/ui/Select.java
@@ -123,13 +123,16 @@ public WebElement getFirstSelectedOption() {
   @Override
   public void selectByVisibleText(String text) {
     assertSelectIsEnabled();
-
+    assertSelectIsVisible();
     // try to find the option via XPATH ...
     List<WebElement> options =
         element.findElements(
             By.xpath(".//option[normalize-space(.) = " + Quotes.escape(text) + "]"));
 
     for (WebElement option : options) {
+      if(!hasCssPropertyAndVisible(option)) {
+        throw new NoSuchElementException("Invisible option with text: " + text);
+      }
       setSelected(option, true);
       if (!isMultiple()) {
         return;

From 5d9b5d193d8dfebb1bef1d7af8b0b053efae1bd1 Mon Sep 17 00:00:00 2001
From: Santiago Cecena <santiago.cecena@encora.com>
Date: Thu, 19 Jun 2025 15:43:42 -0700
Subject: [PATCH 2/5] style: format code to follow style guidelines

---
 java/src/org/openqa/selenium/support/ui/Select.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/java/src/org/openqa/selenium/support/ui/Select.java b/java/src/org/openqa/selenium/support/ui/Select.java
index 6c611d55f447d..003d5009497e0 100644
--- a/java/src/org/openqa/selenium/support/ui/Select.java
+++ b/java/src/org/openqa/selenium/support/ui/Select.java
@@ -130,7 +130,7 @@ public void selectByVisibleText(String text) {
             By.xpath(".//option[normalize-space(.) = " + Quotes.escape(text) + "]"));
 
     for (WebElement option : options) {
-      if(!hasCssPropertyAndVisible(option)) {
+      if (!hasCssPropertyAndVisible(option)) {
         throw new NoSuchElementException("Invisible option with text: " + text);
       }
       setSelected(option, true);

From 61d125be8adee8292c2b4aa1d96f12ef77e59779 Mon Sep 17 00:00:00 2001
From: Santiago Cecena <santiago.cecena@encora.com>
Date: Thu, 19 Jun 2025 17:02:48 -0700
Subject: [PATCH 3/5] fix: continue searching for visible optiones before
 throwing in selectByVisibleText

---
 java/src/org/openqa/selenium/support/ui/Select.java | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/java/src/org/openqa/selenium/support/ui/Select.java b/java/src/org/openqa/selenium/support/ui/Select.java
index 003d5009497e0..c4517fdb9242a 100644
--- a/java/src/org/openqa/selenium/support/ui/Select.java
+++ b/java/src/org/openqa/selenium/support/ui/Select.java
@@ -124,11 +124,14 @@ public WebElement getFirstSelectedOption() {
   public void selectByVisibleText(String text) {
     assertSelectIsEnabled();
     assertSelectIsVisible();
+
     // try to find the option via XPATH ...
     List<WebElement> options =
         element.findElements(
             By.xpath(".//option[normalize-space(.) = " + Quotes.escape(text) + "]"));
 
+    boolean selectedAnyVisible = false;
+
     for (WebElement option : options) {
       if (!hasCssPropertyAndVisible(option)) {
         throw new NoSuchElementException("Invisible option with text: " + text);
@@ -139,6 +142,11 @@ public void selectByVisibleText(String text) {
       }
     }
 
+    if (!selectedAnyVisible && !options.isEmpty()) {
+      // if we found options, but none of them was visible, we throw an exception
+      throw new NoSuchElementException("No visible option with text: " + text);
+    }
+
     boolean matched = !options.isEmpty();
     if (!matched && text.contains(" ")) {
       String subStringWithoutSpace = getLongestSubstringWithoutSpace(text);

From 01e619f29cfc3c06a60ccfed9dfbf14e4a72dfb5 Mon Sep 17 00:00:00 2001
From: Santiago Cecena <santiago.cecena@encora.com>
Date: Wed, 25 Jun 2025 13:38:08 -0700
Subject: [PATCH 4/5] feat(java): handle invisible options gracefully in
 selectByVisibleText

Refactored the logic in selectByVisibleText to skip invisible options
instead of failing fast. The method now continues evaluating other
options with matching visible text, ensuring consistent behavior when
multiple matching elements exist but some are hidden via CSS.

This change improves robustness and aligns with cross-language
expectations for Select component behavior.

Relates to #15265
---
 java/src/org/openqa/selenium/support/ui/Select.java | 13 +++++++------
 1 file changed, 7 insertions(+), 6 deletions(-)

diff --git a/java/src/org/openqa/selenium/support/ui/Select.java b/java/src/org/openqa/selenium/support/ui/Select.java
index c4517fdb9242a..1e9a01e289fdd 100644
--- a/java/src/org/openqa/selenium/support/ui/Select.java
+++ b/java/src/org/openqa/selenium/support/ui/Select.java
@@ -133,12 +133,13 @@ public void selectByVisibleText(String text) {
     boolean selectedAnyVisible = false;
 
     for (WebElement option : options) {
-      if (!hasCssPropertyAndVisible(option)) {
-        throw new NoSuchElementException("Invisible option with text: " + text);
-      }
-      setSelected(option, true);
-      if (!isMultiple()) {
-        return;
+      if (hasCssPropertyAndVisible(option)) {
+        // throw new NoSuchElementException("Invisible option with text: " + text);
+        setSelected(option, true);
+        selectedAnyVisible = true;
+        if (!isMultiple()) {
+          return;
+        }
       }
     }
 

From 0a48d4813284c7f51e327106cf7d2c8328a74bc5 Mon Sep 17 00:00:00 2001
From: Santiago Cecena <santiago.cecena@encora.com>
Date: Fri, 27 Jun 2025 18:05:47 -0700
Subject: [PATCH 5/5] refactor(java): remove comment line in
 selectByVisibleText

---
 java/src/org/openqa/selenium/support/ui/Select.java | 1 -
 1 file changed, 1 deletion(-)

diff --git a/java/src/org/openqa/selenium/support/ui/Select.java b/java/src/org/openqa/selenium/support/ui/Select.java
index 1e9a01e289fdd..ed113dba35b48 100644
--- a/java/src/org/openqa/selenium/support/ui/Select.java
+++ b/java/src/org/openqa/selenium/support/ui/Select.java
@@ -134,7 +134,6 @@ public void selectByVisibleText(String text) {
 
     for (WebElement option : options) {
       if (hasCssPropertyAndVisible(option)) {
-        // throw new NoSuchElementException("Invisible option with text: " + text);
         setSelected(option, true);
         selectedAnyVisible = true;
         if (!isMultiple()) {