From ef39df04442c26dfde63c3b62944548d93430ed7 Mon Sep 17 00:00:00 2001 From: Boni Garcia Date: Mon, 19 May 2025 17:06:13 +0200 Subject: [PATCH] [rust] Include flag --selenium-version to specify the Selenium version (#15754) --- rust/src/lib.rs | 1 - rust/src/main.rs | 10 ++++++---- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/rust/src/lib.rs b/rust/src/lib.rs index 318b0ca0e96af..422387501a6bd 100644 --- a/rust/src/lib.rs +++ b/rust/src/lib.rs @@ -111,7 +111,6 @@ pub const NOT_ADMIN_FOR_EDGE_INSTALLER_ERR_MSG: &str = "{} can only be installed in Windows with administrator permissions"; pub const ONLINE_DISCOVERY_ERROR_MESSAGE: &str = "Unable to discover {}{} in online repository"; pub const UNC_PREFIX: &str = r"\\?\"; -pub const SM_BETA_LABEL: &str = "0."; pub trait SeleniumManager { // ---------------------------------------------------------- diff --git a/rust/src/main.rs b/rust/src/main.rs index 300efc532802e..020b81c41f679 100644 --- a/rust/src/main.rs +++ b/rust/src/main.rs @@ -25,11 +25,11 @@ use selenium_manager::grid::GridManager; use selenium_manager::lock::clear_lock_if_required; use selenium_manager::logger::{Logger, BROWSER_PATH, DRIVER_PATH}; use selenium_manager::metadata::clear_metadata; +use selenium_manager::REQUEST_TIMEOUT_SEC; use selenium_manager::TTL_SEC; use selenium_manager::{ clear_cache, get_manager_by_browser, get_manager_by_driver, SeleniumManager, }; -use selenium_manager::{REQUEST_TIMEOUT_SEC, SM_BETA_LABEL}; use std::backtrace::{Backtrace, BacktraceStatus}; use std::path::Path; use std::process::exit; @@ -145,6 +145,10 @@ struct Cli { #[clap(long)] language_binding: Option, + /// Selenium version (to be sent to plausible.io) + #[clap(long, value_parser, default_value = "")] + selenium_version: String, + /// Avoid sends usage statistics to plausible.io #[clap(long)] avoid_stats: bool, @@ -223,9 +227,7 @@ fn main() { selenium_manager.set_cache_path(cache_path.clone()); selenium_manager.set_offline(cli.offline); selenium_manager.set_language_binding(cli.language_binding.unwrap_or_default()); - let sm_version = clap::crate_version!(); - let selenium_version = sm_version.strip_prefix(SM_BETA_LABEL).unwrap_or(sm_version); - selenium_manager.set_selenium_version(selenium_version.to_string()); + selenium_manager.set_selenium_version(cli.selenium_version); selenium_manager.set_avoid_stats(cli.avoid_stats); selenium_manager.set_skip_driver_in_path(cli.skip_driver_in_path); selenium_manager.set_skip_browser_in_path(cli.skip_browser_in_path);