addressing mypy errors

Author: bandophahita

py/selenium/webdriver/chrome/service.py

@@ -33,12 +33,12 @@ class Service(service.ChromiumService):
     :param log_output: (Optional) int representation of STDOUT/DEVNULL, any IO instance or String path to file.
     :param env: (Optional) Mapping of environment variables for the new process, defaults to `os.environ`.
     """
-
+    _service_args: list[str]
     def __init__(
         self,
         executable_path: Optional[str] = None,
         port: int = 0,
-        service_args: Optional[Sequence[str]] = None,
+        service_args: Optional[list[str]] = None,
         log_output: Optional[SubprocessStdAlias] = None,
         env: Optional[Mapping[str, str]] = None,
         **kwargs,
@@ -55,11 +55,11 @@ def __init__(
         )
 
     @property
-    def service_args(self) -> Sequence[str]:
+    def service_args(self) -> list[str]:
         return self._service_args
 
     @service_args.setter
-    def service_args(self, value: Sequence[str]):
+    def service_args(self, value: list[str]):
         if isinstance(value, str) or not isinstance(value, Sequence):
             raise TypeError("service_args must be a sequence")
         self._service_args = list(value)

py/selenium/webdriver/chrome/webdriver.py

@@ -27,6 +27,9 @@
 class WebDriver(ChromiumDriver):
     """Controls the ChromeDriver and allows you to drive the browser."""
 
+    options: Options
+    service: Service
+
     def __init__(
         self,
         options: Optional[Options] = None,

py/selenium/webdriver/chromium/service.py

@@ -17,7 +17,7 @@
 
 from collections.abc import Mapping, Sequence
 from io import IOBase
-from typing import Optional
+from typing import Optional, Union
 
 from selenium.types import SubprocessStdAlias
 from selenium.webdriver.common import service
@@ -34,12 +34,14 @@ class ChromiumService(service.Service):
     :param env: (Optional) Mapping of environment variables for the new process, defaults to `os.environ`.
     :param driver_path_env_key: (Optional) Environment variable to use to get the path to the driver executable.
     """
+    _service_args: list[str]
+    log_output: Union[Optional[IOBase], Optional[Union[int, IOBase]], Optional[SubprocessStdAlias]]
 
     def __init__(
         self,
         executable_path: Optional[str] = None,
         port: int = 0,
-        service_args: Optional[Sequence[str]] = None,
+        service_args: Optional[list[str]] = None,
         log_output: Optional[SubprocessStdAlias] = None,
         env: Optional[Mapping[str, str]] = None,
         driver_path_env_key: Optional[str] = None,
@@ -69,11 +71,11 @@ def command_line_args(self) -> list[str]:
         return [f"--port={self.port}"] + self._service_args
 
     @property
-    def service_args(self) -> Sequence[str]:
+    def service_args(self) -> list[str]:
         return self._service_args
 
     @service_args.setter
-    def service_args(self, value: Sequence[str]):
+    def service_args(self, value: list[str]):
         if isinstance(value, str) or not isinstance(value, Sequence):
             raise TypeError("service_args must be a sequence")
         self._service_args = list(value)

py/selenium/webdriver/chromium/webdriver.py

@@ -15,12 +15,11 @@
 # specific language governing permissions and limitations
 # under the License.
 
-from typing import Optional
 
+from selenium.webdriver.chromium.options import ChromiumOptions
 from selenium.webdriver.chromium.remote_connection import ChromiumRemoteConnection
+from selenium.webdriver.chromium.service import ChromiumService
 from selenium.webdriver.common.driver_finder import DriverFinder
-from selenium.webdriver.common.options import ArgOptions
-from selenium.webdriver.common.service import Service
 from selenium.webdriver.remote.command import Command
 from selenium.webdriver.remote.webdriver import WebDriver as RemoteWebDriver
 
@@ -31,10 +30,10 @@ class ChromiumDriver(RemoteWebDriver):
 
     def __init__(
         self,
-        browser_name: Optional[str] = None,
-        vendor_prefix: Optional[str] = None,
-        options: ArgOptions = ArgOptions(),
-        service: Optional[Service] = None,
+        browser_name: str,
+        vendor_prefix: str,
+        options: ChromiumOptions = ChromiumOptions(),
+        service: ChromiumService = ChromiumService(),
         keep_alive: bool = True,
     ) -> None:
         """Creates a new WebDriver instance of the ChromiumDriver. Starts the

py/selenium/webdriver/common/service.py

@@ -48,6 +48,8 @@ class Service(ABC):
     :param driver_path_env_key: (Optional) Environment variable to use to get the path to the driver executable.
     """
 
+    log_output: Union[Optional[IOBase], Optional[Union[int, IOBase]], Optional[SubprocessStdAlias]]
+
     def __init__(
         self,
         executable_path: Optional[str] = None,

py/selenium/webdriver/edge/service.py

@@ -39,7 +39,7 @@ def __init__(
         executable_path: Optional[str] = None,
         port: int = 0,
         log_output: Optional[SubprocessStdAlias] = None,
-        service_args: Optional[Sequence[str]] = None,
+        service_args: Optional[list[str]] = None,
         env: Optional[Mapping[str, str]] = None,
         driver_path_env_key: Optional[str] = None,
         **kwargs,
@@ -58,11 +58,11 @@ def __init__(
         )
 
     @property
-    def service_args(self) -> Sequence[str]:
+    def service_args(self) -> list[str]:
         return self._service_args
 
     @service_args.setter
-    def service_args(self, value: Sequence[str]):
+    def service_args(self, value: list[str]):
         if isinstance(value, str) or not isinstance(value, Sequence):
             raise TypeError("service_args must be a sequence")
         self._service_args = list(value)

py/selenium/webdriver/edge/webdriver.py

@@ -27,6 +27,9 @@
 class WebDriver(ChromiumDriver):
     """Controls the MSEdgeDriver and allows you to drive the browser."""
 
+    options: Options
+    service: Service
+
     def __init__(
         self,
         options: Optional[Options] = None,