Skip to content

Commit 9687595

Browse files
committed
reverting argument annotation since we convert anything passed in to a list.
1 parent d3cc86a commit 9687595

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

py/selenium/webdriver/chrome/service.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,17 +33,19 @@ class Service(service.ChromiumService):
3333
:param log_output: (Optional) int representation of STDOUT/DEVNULL, any IO instance or String path to file.
3434
:param env: (Optional) Mapping of environment variables for the new process, defaults to `os.environ`.
3535
"""
36+
3637
_service_args: list[str]
38+
3739
def __init__(
3840
self,
3941
executable_path: Optional[str] = None,
4042
port: int = 0,
41-
service_args: Optional[list[str]] = None,
43+
service_args: Optional[Sequence[str]] = None,
4244
log_output: Optional[SubprocessStdAlias] = None,
4345
env: Optional[Mapping[str, str]] = None,
4446
**kwargs,
4547
) -> None:
46-
self._service_args = service_args or []
48+
self._service_args = list(service_args or [])
4749

4850
super().__init__(
4951
executable_path=executable_path,

py/selenium/webdriver/chromium/service.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ def __init__(
4242
self,
4343
executable_path: Optional[str] = None,
4444
port: int = 0,
45-
service_args: Optional[list[str]] = None,
45+
service_args: Optional[Sequence[str]] = None,
4646
log_output: Optional[SubprocessStdAlias] = None,
4747
env: Optional[Mapping[str, str]] = None,
4848
driver_path_env_key: Optional[str] = None,

py/selenium/webdriver/edge/service.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ def __init__(
3939
executable_path: Optional[str] = None,
4040
port: int = 0,
4141
log_output: Optional[SubprocessStdAlias] = None,
42-
service_args: Optional[list[str]] = None,
42+
service_args: Optional[Sequence[str]] = None,
4343
env: Optional[Mapping[str, str]] = None,
4444
driver_path_env_key: Optional[str] = None,
4545
**kwargs,

0 commit comments

Comments
 (0)