Skip to content

Commit 8ae6bea

Browse files
committed
[build] explicitly pass version from github workflow to rake task
1 parent c52751c commit 8ae6bea

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

.github/workflows/pre-release.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,10 +80,10 @@ jobs:
8080
run: git reset HEAD~1
8181
- name: Update everything including early release CDP
8282
if: ${{ github.event.inputs.chrome_channel == 'early-stable' }}
83-
run: ./go all:prepare['Beta']
83+
run: ./go all:prepare[${{ github.event.inputs.version }},Beta]
8484
- name: Update everything including released CDP
8585
if: ${{ github.event.inputs.chrome_channel == 'stable' }}
86-
run: ./go "all:prepare[Stable]"
86+
run: ./go "all:prepare[${{ github.event.inputs.version }},Stable]"
8787
- name: Create Pull Request
8888
uses: peter-evans/create-pull-request@v6
8989
with:

Rakefile

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1071,8 +1071,9 @@ namespace :all do
10711071
end
10721072

10731073
desc 'Update everything in preparation for a release'
1074-
task :prepare, [:channel] do |_task, arguments|
1074+
task :prepare, [:version, :channel] do |_task, arguments|
10751075
chrome_channel = arguments[:channel] || 'Stable'
1076+
version = arguments[:version]
10761077
args = Array(chrome_channel) ? ['--', "--chrome_channel=#{chrome_channel.capitalize}"] : []
10771078
Bazel.execute('run', args, '//scripts:pinned_browsers')
10781079
commit!('Update pinned browser versions', ['common/repositories.bzl'])
@@ -1102,7 +1103,7 @@ namespace :all do
11021103
commit!('Update authors file', ['AUTHORS'])
11031104

11041105
# Note that this does not include Rust version changes that are handled in separate rake:version task
1105-
Rake::Task['all:version'].invoke
1106+
Rake::Task['all:version'].invoke(version)
11061107
commit!("FIX CHANGELOGS BEFORE MERGING!\n\nUpdate versions and change logs to release Selenium #{java_version}",
11071108
['dotnet/CHANGELOG',
11081109
'dotnet/selenium-dotnet-version.bzl',

0 commit comments

Comments
 (0)