Follow up PRs after merging cms-sw/cmssw#45117

# Priority: Soon after merging 

## Integrate accumulated algorithm developments held back during integration PR review
- [x] Progress tracked in #117.

### Update LST README, printouts and minor fixes.
<details><summary>Links to specific comments</summary>

- [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1681737544
- [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1681741075
- [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1833259595
- [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1833261173
- [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1844301482
- [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1844313384

</details>

Covered partially by #55. A follow up to accommodate the developments made in #72 will be needed.

### Deal with the configurability of the pT threshold
- [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1749245650

Covered by #39.

## LST in HLT
- [x] Rebase and merge #107.

## Changes in LST conditions data
- [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1749249842:
I would prefer if the possibility of overriding the conditions data setting `LST_BASE` or `TRACKLOOPERDIR` would be disabled when building this code inside CMSSW.
- [x] Remove lst_INF
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1625114981
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1749241840
- [x] https://github.com/cms-sw/cmssw/pull/45117#issuecomment-2479912047:
`LSTESData::geometryDataDir` needs a check that `getenv("CMSSW_SEARCH_PATH")` is not null.

## LST workflow
- [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1664589679:
Respect new relval_2026.py structure.
- [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1682593922:
Decide if we want different workflows for different backends.
- [ ] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1682597612:
Implement a "GPU vs CPU" workflow.
- [x] https://github.com/cms-sw/cmssw/pull/45117#issuecomment-2479912047:
Fill seed stop info when LST runs (expected by DQM/validation).

## Make general-purpose functions widely available in CMSSW
- [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1674782508
- [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1749143439

The plan would be to move all general-purpose functions (work started in #71):
 - Follow up PR with general functions.
 - Follow up PR moving LST to use those and delete custom implementations.

---

# Priority: Short-term plan

## Rewrite the loops in the kernels using uniform_elements, independent_groups, independent_group_elements, etc.
- [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1749244105:
Experiment with `make_workdiv`.
- [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1682849644:
No need to set the grid size to 1, the alpaka execution will run the blocks one after the other automatically. You can set the grid size to 1 - the difference will be in how the kernel are executed over the elements. Either way, I think whatever approach you choose should be documented.
- [x] https://github.com/cms-sw/cmssw/pull/45117#pullrequestreview-2286131239
  <details><summary>Links to specific comments</summary>

  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1747147790
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1747148816
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1747157117
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1747159610
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1747160439
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1747161690
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1747492866
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1747493175
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1747493376
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1747497128
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1747501157
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1747514758
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1747514956
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1747515175
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1747519657
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1747520652
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1748006364
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1748008415
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1748008598
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1748008657
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1748008802
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1748009215
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1748009259
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1748009459
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1748009869
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1748010016
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1748010582
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1748010837
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1748015075
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1748015269
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1748058899
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1749143810
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1749144167
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1749163618
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1749163821
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1749164934
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1749165613
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1749236516
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1749236618
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1749236663
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1749237704
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1749237801
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1749238020
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1749238089
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1749238179
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1749238234
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1749238443
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1749238487

  </details>

## Rewrite kernels with proper, concrete dimensions instead of templated types
- [x] https://github.com/cms-sw/cmssw/pull/45117#pullrequestreview-2286131239:
  <details><summary>Links to specific comments</summary>

  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1747146697
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1747161172
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1747493770
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1747495326
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1747501517
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1747519297
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1747520469
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1748005531
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1748005961
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1748006364
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1748008415
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1748008961
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1748009215
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1748009259
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1748009395
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1748009581
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1748009869
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1748010016
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1748010483
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1748010582
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1748010772
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1748013396
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1748058899
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1749143631
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1749143810
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1749143984
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1749144167
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1749163156
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1749163618
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1749163821
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1749164831
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1749165439
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1749236366
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1749237268
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1749237704
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1749237801
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1749237960
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1749238020
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1749238089
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1749238179
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1749238234
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1749238303
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1749238386
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1749238443
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1749238487
  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1833303542

  </details>

---

# Priority: Long-term plan

## Improvements to the data format interface between LST and CMSSW
- [ ] https://github.com/cms-sw/cmssw/pull/45117#pullrequestreview-2289657004:
Define the LST inputs and output as PortableCollections, and pass them (or their Views) to the LST algorithm.
  <details><summary>Links to specific comments</summary>

  - [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1682835338:
Fill a host SoA directly in `LSTPhase2OTHitsInputProducer`, copy it to device, and avoid the 6 intermediate copies of the `std::vector`s.
  - [ ] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1718975196:
Performance-wise best would be to move them in `LSTProducer::produce()`, that would require the `LST::hits()` etc to either return a mutable reference, or a value that was moved-from in the `hits()` method itself.
  - [ ] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1718978133:
Eventually (or ideally) we'd want to issue the `alpaka::memcpy()` calls to copy the data from device to host in `acquire()`, and have the destination host memory accessed only in `produce()`.

  </details>

## Construct LST condition data from the existing EventSetup info
- [ ] https://github.com/cms-sw/cmssw/pull/45117#pullrequestreview-2286131239:
  - [ ] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1749373735
  - [ ] https://github.com/cms-sw/cmssw/pull/45117#issuecomment-2480475750

## Improvements in storing and using "magic numbers
- [ ] https://github.com/cms-sw/cmssw/pull/45117#pullrequestreview-2286131239:
  <details><summary>Links to specific comments</summary>

  - [ ] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1747431534
  - [ ] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1747438638
  - [ ] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1748017178
  - [ ] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1748057472
  - [ ] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1748057673
  - [ ] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1748057925

</details>

## Miscellaneous improvements
- [x] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1749139063:
Try std::binary_search(data, data + ndata, search_val) from C++20.
- [ ] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1749241199:
Review uint4 usage.

## Improvements to ESProducer
- [ ] https://github.com/cms-sw/cmssw/pull/45117#discussion_r1699051274:
Make it more clear which members are on the device memory and which are on the host memory. Suggest to consider moving all data that are used only in host code into a separate ES data product.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Follow up PRs after merging cms-sw/cmssw#45117 #75

Priority: Soon after merging

Integrate accumulated algorithm developments held back during integration PR review

Update LST README, printouts and minor fixes.

Deal with the configurability of the pT threshold

LST in HLT

Changes in LST conditions data

LST workflow

Make general-purpose functions widely available in CMSSW

Priority: Short-term plan

Rewrite the loops in the kernels using uniform_elements, independent_groups, independent_group_elements, etc.

Rewrite kernels with proper, concrete dimensions instead of templated types

Priority: Long-term plan

Improvements to the data format interface between LST and CMSSW

Construct LST condition data from the existing EventSetup info

Improvements in storing and using "magic numbers

Miscellaneous improvements

Improvements to ESProducer

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Follow up PRs after merging cms-sw/cmssw#45117 #75

Description

Priority: Soon after merging

Integrate accumulated algorithm developments held back during integration PR review

Update LST README, printouts and minor fixes.

Deal with the configurability of the pT threshold

LST in HLT

Changes in LST conditions data

LST workflow

Make general-purpose functions widely available in CMSSW

Priority: Short-term plan

Rewrite the loops in the kernels using uniform_elements, independent_groups, independent_group_elements, etc.

Rewrite kernels with proper, concrete dimensions instead of templated types

Priority: Long-term plan

Improvements to the data format interface between LST and CMSSW

Construct LST condition data from the existing EventSetup info

Improvements in storing and using "magic numbers

Miscellaneous improvements

Improvements to ESProducer

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions