From 49ea30201b1eb2d30f2178e8fd25275b57c96282 Mon Sep 17 00:00:00 2001
From: Andre Turner <andre_turner@tsco.org>
Date: Wed, 22 May 2024 15:16:06 -0500
Subject: [PATCH 1/2] revised to load different subjects based on project type

---
 .../project-step-changed.template.tsx         | 25 +++++++++++--------
 1 file changed, 15 insertions(+), 10 deletions(-)

diff --git a/src/core/email/templates/project-step-changed.template.tsx b/src/core/email/templates/project-step-changed.template.tsx
index 9a08cd4543..2ec850ee63 100644
--- a/src/core/email/templates/project-step-changed.template.tsx
+++ b/src/core/email/templates/project-step-changed.template.tsx
@@ -7,6 +7,7 @@ import {
 } from '@seedcompany/nestjs-email/templates';
 import { startCase } from 'lodash';
 import { EmailNotification as StepChangeNotification } from '../../../components/project';
+import { ProjectType } from '../../../components/project/dto/project-type.enum';
 import { EmailTemplate, Heading } from './base';
 import { FormattedDateTime } from './formatted-date-time';
 import { useFrontendUrl } from './frontend-url';
@@ -21,16 +22,26 @@ export function ProjectStepChanged({
 }: StepChangeNotification) {
   const projectUrl = useFrontendUrl(`/projects/${project.id}`);
   const projectName = project.name.value;
-
+  const projectType = project.type;
   const oldStep = startCase(oldStepVal) || undefined;
   const newStep = startCase(project.step.value) || undefined;
+  const multiplicationTitle =
+    projectName && newStep && primaryPartnerName
+      ? `${projectType} - ${projectName} - ${primaryPartnerName} - is pending ${newStep} approval`
+      : projectName && newStep
+      ? `${projectType} - ${projectName} - is pending ${newStep} approval`
+      : `${projectType} - Project Status Change`;
+  const momentumTitle =
+    projectName && oldStep && newStep
+      ? `${projectName} changed from ${oldStep} to ${newStep}`
+      : 'Project Status Change';
 
   return (
     <EmailTemplate
       title={
-        projectName && oldStep && newStep
-          ? `${projectName} changed from ${oldStep} to ${newStep}`
-          : 'Project Status Change'
+        projectType === ProjectType.MultiplicationTranslation
+          ? multiplicationTitle
+          : momentumTitle
       }
     >
       <Heading>
@@ -64,12 +75,6 @@ export function ProjectStepChanged({
               value={project.modifiedAt}
               timezone={recipient.timezone.value}
             />
-            <br />
-            Project Type: {project.type}
-            <br />
-            {primaryPartnerName ? (
-              <>Primary Partner: {primaryPartnerName}</>
-            ) : null}
           </Text>
           <HideInText>
             <Button href={projectUrl} paddingTop={16}>

From 92f7527d206d9e0054975c35439a86dcc02dce8f Mon Sep 17 00:00:00 2001
From: Carson Full <carson_full@tsco.org>
Date: Wed, 29 May 2024 18:33:00 -0500
Subject: [PATCH 2/2] Refactor to use enum labels & somewhat unify across types

---
 .../project-step-changed.template.tsx         | 41 +++++++++----------
 1 file changed, 19 insertions(+), 22 deletions(-)

diff --git a/src/core/email/templates/project-step-changed.template.tsx b/src/core/email/templates/project-step-changed.template.tsx
index 2ec850ee63..26274fda94 100644
--- a/src/core/email/templates/project-step-changed.template.tsx
+++ b/src/core/email/templates/project-step-changed.template.tsx
@@ -1,3 +1,4 @@
+import { cleanJoin } from '@seedcompany/common';
 import {
   Button,
   Column,
@@ -5,9 +6,11 @@ import {
   Section,
   Text,
 } from '@seedcompany/nestjs-email/templates';
-import { startCase } from 'lodash';
 import { EmailNotification as StepChangeNotification } from '../../../components/project';
-import { ProjectType } from '../../../components/project/dto/project-type.enum';
+import {
+  ProjectStep as Step,
+  ProjectType as Type,
+} from '../../../components/project/dto';
 import { EmailTemplate, Heading } from './base';
 import { FormattedDateTime } from './formatted-date-time';
 import { useFrontendUrl } from './frontend-url';
@@ -22,28 +25,22 @@ export function ProjectStepChanged({
 }: StepChangeNotification) {
   const projectUrl = useFrontendUrl(`/projects/${project.id}`);
   const projectName = project.name.value;
-  const projectType = project.type;
-  const oldStep = startCase(oldStepVal) || undefined;
-  const newStep = startCase(project.step.value) || undefined;
-  const multiplicationTitle =
-    projectName && newStep && primaryPartnerName
-      ? `${projectType} - ${projectName} - ${primaryPartnerName} - is pending ${newStep} approval`
-      : projectName && newStep
-      ? `${projectType} - ${projectName} - is pending ${newStep} approval`
-      : `${projectType} - Project Status Change`;
-  const momentumTitle =
-    projectName && oldStep && newStep
-      ? `${projectName} changed from ${oldStep} to ${newStep}`
-      : 'Project Status Change';
+  const projectType = Type.entry(project.type);
+  const oldStep = oldStepVal ? Step.entry(oldStepVal).label : undefined;
+  const newStep = project.step.value
+    ? Step.entry(project.step.value).label
+    : undefined;
+
+  const isMultiplication = projectType.value === Type.MultiplicationTranslation;
+  const title = cleanJoin(' - ', [
+    isMultiplication && projectType.label,
+    projectName ?? 'Project',
+    isMultiplication && primaryPartnerName,
+    newStep ? `is ${newStep}` : 'Status Change',
+  ]);
 
   return (
-    <EmailTemplate
-      title={
-        projectType === ProjectType.MultiplicationTranslation
-          ? multiplicationTitle
-          : momentumTitle
-      }
-    >
+    <EmailTemplate title={title}>
       <Heading>
         {projectName && newStep ? (
           <>