Bug fix for ACM records

Script47 · Script47 · commit e6cc0923a10f · 2024-12-01T23:38:21.000Z
diff --git a/static-site/acm.tf b/static-site/acm.tf
@@ -7,5 +7,5 @@ resource "aws_acm_certificate" "cloudfront_cert" {
 
 resource "aws_acm_certificate_validation" "cert_validation" {
   certificate_arn         = aws_acm_certificate.cloudfront_cert.arn
-  validation_record_fqdns = [for record in aws_route53_zone.hosted_zone : record.fqdn]
+  validation_record_fqdns = [for record in aws_route53_record.acm_records : record.fqdn]
 }
diff --git a/static-site/data.tf b/static-site/data.tf
@@ -62,6 +62,7 @@ data "aws_iam_policy_document" "deploy_web" {
 
 data "aws_route53_zone" "hosted_zone" {
   name = var.domain_name
+  private_zone = false
 }
 
 data "aws_iam_openid_connect_provider" "github" {
diff --git a/static-site/route53.tf b/static-site/route53.tf
@@ -16,7 +16,7 @@ resource "aws_route53_record" "acm_records" {
   records         = [each.value.record]
   ttl             = 60
   type            = each.value.type
-  zone_id         = aws_route53_zone.hosted_zone.zone_id
+  zone_id         = data.aws_route53_zone.hosted_zone.zone_id
 }
 
 #############################################

Original file line number	Diff line number	Diff line change
`@@ -7,5 +7,5 @@ resource "aws_acm_certificate" "cloudfront_cert" {`
`7`	`7`
`8`	`8`	`resource "aws_acm_certificate_validation" "cert_validation" {`
`9`	`9`	`certificate_arn = aws_acm_certificate.cloudfront_cert.arn`
`10`		`- validation_record_fqdns = [for record in aws_route53_zone.hosted_zone : record.fqdn]`
	`10`	`+ validation_record_fqdns = [for record in aws_route53_record.acm_records : record.fqdn]`
`11`	`11`	`}`
Original file line number	Diff line number	Diff line change
`@@ -62,6 +62,7 @@ data "aws_iam_policy_document" "deploy_web" {`
`62`	`62`
`63`	`63`	`data "aws_route53_zone" "hosted_zone" {`
`64`	`64`	`name = var.domain_name`
	`65`	`+ private_zone = false`
`65`	`66`	`}`
`66`	`67`
`67`	`68`	`data "aws_iam_openid_connect_provider" "github" {`
Original file line number	Diff line number	Diff line change
`@@ -16,7 +16,7 @@ resource "aws_route53_record" "acm_records" {`
`16`	`16`	`records = [each.value.record]`
`17`	`17`	`ttl = 60`
`18`	`18`	`type = each.value.type`
`19`		`- zone_id = aws_route53_zone.hosted_zone.zone_id`
	`19`	`+ zone_id = data.aws_route53_zone.hosted_zone.zone_id`
`20`	`20`	`}`
`21`	`21`
`22`	`22`	`#############################################`