Fix some pylint problems.

Author: HolonProduction

gdtoolkit/common/ast.py

@@ -6,6 +6,7 @@
 from ..formatter.annotation import STANDALONE_ANNOTATIONS
 
 from .utils import find_name_token_among_children, find_tree_among_children
+from .exceptions import GDToolkitError
 
 
 # pylint: disable-next=too-few-public-methods
@@ -113,7 +114,7 @@ def __init__(self, parse_tree: Tree):
         elif parse_tree.data == "class_def":
             self._load_data_from_class_def(parse_tree)
         else:
-            raise Exception("Cannot load class from that node")
+            raise GDToolkitError("Cannot load class from that node")
 
     def _load_data_from_node_children(self, node: Tree) -> None:
         offset = 1 if node.data == "class_def" else 0

gdtoolkit/common/exceptions.py

@@ -1,6 +1,10 @@
 import lark
 
 
+class GDToolkitError(Exception):
+    pass
+
+
 def lark_unexpected_input_to_str(exception: lark.exceptions.UnexpectedInput):
     return str(exception).strip()
 

gdtoolkit/formatter/exceptions.py

@@ -1,24 +1,26 @@
 from dataclasses import dataclass
 
+from ..common.exceptions import GDToolkitError
+
 
 @dataclass
-class TreeInvariantViolation(Exception):
+class TreeInvariantViolation(GDToolkitError):
     diff: str
 
     def __str__(self):
         return '{}(diff="{}")'.format("TreeInvariantViolation", self.diff)
 
 
 @dataclass
-class FormattingStabilityViolation(Exception):
+class FormattingStabilityViolation(GDToolkitError):
     diff: str
 
     def __str__(self):
         return '{}(diff="{}")'.format("FormattingStabilityViolation", self.diff)
 
 
 @dataclass
-class CommentPersistenceViolation(Exception):
+class CommentPersistenceViolation(GDToolkitError):
     missing_comment: str
 
     def __str__(self):

tests/parser/test_parser.py

@@ -58,7 +58,7 @@ def test_parsing_failure(gdscript_nok_path):
             parser.parse(code)
         except:  # pylint: disable=bare-except
             return
-        raise Exception("shall fail")
+        assert True, "shall fail"
 
 
 @pytest.mark.skipif(shutil.which(GODOT_SERVER) is None, reason="requires godot server")