Fix linter problem reports when global scope used, fixes #343

Author: Scony

CHANGELOG.md

@@ -1,5 +1,10 @@
 # Changelog
 
+## [master]
+
+### Changed
+ - Fixed linter problem reports when global scope is used
+
 ## [4.3.3] 2024-11-02
 
 ### Changed

gdtoolkit/common/ast.py

@@ -114,6 +114,7 @@ def __init__(self, parse_tree: Tree):
         if parse_tree.data == "start":
             start = parse_tree
             self._load_data_from_node_children(start)
+            self.name = "global scope"
         elif parse_tree.data == "class_def":
             self._load_data_from_class_def(parse_tree)
         else:

tests/linter/test_executable.py

@@ -48,3 +48,12 @@ def test_pretty_printing_unexpected_token(tmp_path):
     assert len(outcome.stdout.decode().splitlines()) == 0
     assert len(outcome.stderr.decode().splitlines()) > 0
     assert "Traceback" not in outcome.stderr.decode()
+
+
+def test_linter_problem_report_in_global_scope(tmp_path):
+    dummy_file = write_file(tmp_path, "script.gd", "var foo = 1\nconst X = 1")
+    outcome = subprocess.run(["gdlint", dummy_file], check=False, capture_output=True)
+    assert outcome.returncode == 1
+    assert len(outcome.stdout.decode().splitlines()) == 0
+    assert len(outcome.stderr.decode().splitlines()) >= 0
+    assert "Definition out of order in global scope" in outcome.stderr.decode()