Skip to content

Commit 75b187f

Browse files
Align signal_args with func_args.
1 parent 8f7502a commit 75b187f

File tree

5 files changed

+7
-1
lines changed

5 files changed

+7
-1
lines changed

gdtoolkit/formatter/expression_to_str.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -102,6 +102,7 @@ def expression_to_str(expression: Node) -> str:
102102
"enum_body": _enum_body_to_str,
103103
"enum_element": _enum_element_to_str,
104104
"signal_args": _args_to_str,
105+
"signal_arg_regular": lambda e: e.children[0].value,
105106
"signal_arg_typed": lambda e: "{}: {}".format(
106107
e.children[0].value,
107108
e.children[1].value,

gdtoolkit/formatter/expression_utils.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@ def is_foldable(expression: Node) -> bool:
2525
"string_name",
2626
"unique_node_path",
2727
"signal_arg_typed",
28+
"signal_arg_regular",
2829
"non_foldable_dot_chain",
2930
]
3031
and not expression.data.endswith("_pattern")

gdtoolkit/parser/gdscript.lark

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ enum_body: "{" [enum_element ("," enum_element)* [trailing_comma]] "}"
2929
enum_element: NAME ["=" type_cast]
3030
signal_stmt: "signal" NAME [signal_args]
3131
signal_args: "(" [signal_arg ("," signal_arg)* [trailing_comma]] ")"
32-
?signal_arg: NAME
32+
?signal_arg: NAME -> signal_arg_regular
3333
| NAME ":" TYPE_HINT -> signal_arg_typed
3434
extends_stmt: "extends" (NAME | string) ("." NAME)*
3535
classname_stmt: "class_name" NAME

tests/formatter/input-output-pairs/complex-signal-statements.in.gd

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,3 +6,4 @@ class X:
66
signal e(x,y:float)
77
signal f(x:int,aaaaaaaa, bbbbbbbbb, ccccccccc, dddddddd, eeeeeeee, ffffffff, ggggggggg, hhhhhhhh, iiiiiiii, jjjjjjjjjjj,y:float)
88
signal g(xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx: int)
9+
signal h(xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx)

tests/formatter/input-output-pairs/complex-signal-statements.out.gd

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,3 +37,6 @@ class X:
3737
signal g(
3838
xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx: int
3939
)
40+
signal h(
41+
xxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxxx
42+
)

0 commit comments

Comments
 (0)