Skip to content

Commit 5aa98be

Browse files
committed
Bump static checks - pylint and flake8
1 parent d5a7204 commit 5aa98be

File tree

5 files changed

+14
-14
lines changed

5 files changed

+14
-14
lines changed

gdtoolkit/formatter/__init__.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@
2020

2121

2222
# pylint: disable-next=too-many-arguments
23+
# pylint: disable=too-many-positional-arguments
24+
# pylint: disable=too-many-arguments
2325
def check_formatting_safety(
2426
given_code: str,
2527
formatted_code: str,

gdtoolkit/formatter/context.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88
# pylint: disable=too-many-arguments
99
# pylint: disable=too-many-instance-attributes
1010
# pylint: disable=too-few-public-methods
11+
# pylint: disable=too-many-positional-arguments
1112
class Context:
1213
def __init__(
1314
self,

gdtoolkit/linter/__init__.py

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -180,8 +180,7 @@ def _fetch_problem_inactivity_ranges(gdscript_code: str) -> Dict[str, List[Range
180180
for problem, range_ends in problem_range_ends.items():
181181
for range_end in range_ends:
182182
for a_range in problem_inactivity_ranges[problem]:
183-
if range_end < a_range.end:
184-
a_range.end = range_end
183+
a_range.end = min(a_range.end, range_end)
185184

186185
return problem_inactivity_ranges
187186

gdtoolkit/parser/gdscript_indenter.py

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,9 @@ def handle_NL(self, token: Token) -> Iterator[Token]:
2525
indent = indent_str.count(" ") + indent_str.count("\t") * self.tab_len
2626

2727
if self.paren_level > 0:
28-
for new_token in self._handle_lambdas_on_newline_token_in_parens(
28+
yield from self._handle_lambdas_on_newline_token_in_parens(
2929
token, indent, indent_str
30-
):
31-
yield new_token
30+
)
3231
# special handling for lambdas
3332
return
3433

@@ -64,14 +63,12 @@ def _process(self, stream):
6463
self.paren_level += 1
6564
elif token.type in self.CLOSE_PAREN_types:
6665
while self.undedented_lambdas_at_paren_level[self.paren_level] > 0:
67-
for new_token in self._dedent_lambda_at_token(token):
68-
yield new_token
66+
yield from self._dedent_lambda_at_token(token)
6967
self.paren_level -= 1
7068
assert self.paren_level >= 0
7169
elif token.type in self.LAMBDA_SEPARATOR_types:
7270
if self.undedented_lambdas_at_paren_level[self.paren_level] > 0:
73-
for new_token in self._dedent_lambda_at_token(token):
74-
yield new_token
71+
yield from self._dedent_lambda_at_token(token)
7572

7673
if token.type != self.NL_type:
7774
yield token

tox.ini

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,10 @@ commands =
1212
deps =
1313
pytest > 5
1414
hypothesis == 6.15.0
15-
pylint == 3.0.3
15+
pylint == 3.3.1
1616
typing-extensions
1717
mccabe
18-
flake8 == 5.0.4
18+
flake8 == 7.1.1
1919
flake8-comprehensions
2020
flake8-bugbear
2121
commands =
@@ -78,9 +78,10 @@ commands =
7878

7979
[flake8]
8080
ignore =
81-
E121,E123,E126,E226,E24,E704,W503,W504 # defaults
82-
, E203 # whitespace before ':'
83-
, E231,E702,E275 # false-positives in Python 3.12
81+
E121,E123,E126,E226,E24,E704,W503,W504
82+
, E203
83+
, E231,E702,E275
84+
, F401
8485
max-line-length = 100
8586

8687
[mypy-hypothesis]

0 commit comments

Comments
 (0)