Skip to content

Commit 2b6d998

Browse files
Merge pull request #12 from SciML/docstinrg
Fix docstrings
2 parents 92f092c + f7fa59a commit 2b6d998

File tree

5 files changed

+22
-24
lines changed

5 files changed

+22
-24
lines changed

LICENSE.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,3 @@
1-
21
The MIT License (MIT)
32

43
Copyright (c) 2023 Christopher Rackauckas

docs/make.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ cp("./docs/Project.toml", "./docs/src/assets/Project.toml", force = true)
66
pages = [
77
"Home" => "index.md",
88
"interface.md",
9-
"api.md",
9+
"api.md"
1010
]
1111

1212
ENV["GKSwstype"] = "100"

docs/src/index.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ Pkg.add("SciMLStructures")
2121

2222
- See the [SciML Style Guide](https://github.com/SciML/SciMLStyle) for common coding practices and other style decisions.
2323
- There are a few community forums:
24-
24+
2525
+ The #diffeq-bridged and #sciml-bridged channels in the
2626
[Julia Slack](https://julialang.org/slack/)
2727
+ The #diffeq-bridged and #sciml-bridged channels in the

docs/src/interface.md

Lines changed: 18 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -28,22 +28,24 @@ to the solver how to represent the given "portion" in a standard `AbstractVector
2828
interfacing with standard tools like linear algebra in an efficient manner. The type of portions which
2929
are defined are:
3030

31-
* Tunable: the tunable values/parameters, i.e. the values of the structure which are supposed to be considered
32-
non-constant when used in the context of an inverse problem solve. For example, this is the set of
33-
parameters to be optimized during a parameter estimation of an ODE.
34-
* Tunable parameters are expected to return an `AbstractVector` of unitless values.
35-
* Tunable parameters are expected to be constant during the solution of the ODE.
36-
* Constants: the values which are to be considered constant by the solver, i.e. values which are not estimated
37-
in an inverse problem and which are unchanged in any operation by the user as part of the solver's usage.
38-
* Caches: the stored cache values of the struct, i.e. the values of the structure which are used as intermediates
39-
within other computations in order to avoid extra allocations.
40-
* Discrete: the discrete portions of the state captured inside of the structure. For example, discrete values
41-
stored outside of the `u` in the parameters to be modified in the callbacks of an ODE.
42-
* Any parameter that is modified inside of callbacks should be considered Discrete.
31+
- Tunable: the tunable values/parameters, i.e. the values of the structure which are supposed to be considered
32+
non-constant when used in the context of an inverse problem solve. For example, this is the set of
33+
parameters to be optimized during a parameter estimation of an ODE.
34+
35+
+ Tunable parameters are expected to return an `AbstractVector` of unitless values.
36+
+ Tunable parameters are expected to be constant during the solution of the ODE.
37+
- Constants: the values which are to be considered constant by the solver, i.e. values which are not estimated
38+
in an inverse problem and which are unchanged in any operation by the user as part of the solver's usage.
39+
- Caches: the stored cache values of the struct, i.e. the values of the structure which are used as intermediates
40+
within other computations in order to avoid extra allocations.
41+
- Discrete: the discrete portions of the state captured inside of the structure. For example, discrete values
42+
stored outside of the `u` in the parameters to be modified in the callbacks of an ODE.
43+
44+
+ Any parameter that is modified inside of callbacks should be considered Discrete.
4345

4446
## Definitions for Base Objects
4547

46-
* `Vector`: returns an aliased version of itself as `Tunable`, and an empty vector matching type for `Constants`,
47-
`Caches`, and `Discrete`.
48-
* `Array`: returns the `vec(p)` aliased version of itself as `Tunable`, and an empty vector matching type for `Constants`,
49-
`Caches`, and `Discrete`.
48+
- `Vector`: returns an aliased version of itself as `Tunable`, and an empty vector matching type for `Constants`,
49+
`Caches`, and `Discrete`.
50+
- `Array`: returns the `vec(p)` aliased version of itself as `Tunable`, and an empty vector matching type for `Constants`,
51+
`Caches`, and `Discrete`.

src/interface.jl

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -31,17 +31,14 @@ are defined are:
3131
non-constant when used in the context of an inverse problem solve. For example, this is the set of
3232
parameters to be optimized during a parameter estimation of an ODE.
3333
* Tunable parameters are expected to return an `AbstractVector` of unitless values.
34+
* Tunable parameters are expected to be constant during the solution of the ODE.
3435
* Constants: the values which are to be considered constant by the solver, i.e. values which are not estimated
3536
in an inverse problem and which are unchanged in any operation by the user as part of the solver's usage.
3637
* Caches: the stored cache values of the struct, i.e. the values of the structure which are used as intermediates
3738
within other computations in order to avoid extra allocations.
3839
* Discrete: the discrete portions of the state captured inside of the structure. For example, discrete values
3940
stored outside of the `u` in the parameters to be modified in the callbacks of an ODE.
40-
41-
## Structural Emptiness
42-
43-
If `hasportion(::AbstractPortion, p) == false`, then the canonical return is
44-
`nothing, nothing, nothing`.
41+
* Any parameter that is modified inside of callbacks should be considered Discrete.
4542
4643
## Definitions for Base Objects
4744

0 commit comments

Comments
 (0)