revert incorrect fixes

Author: oscardssmith

lib/OrdinaryDiffEqNonlinearSolve/src/newton.jl

@@ -81,7 +81,7 @@ end
     @unpack tstep, invγdt = cache
 
     nlcache = nlsolver.cache.cache
-    step!(nlcache)
+    step!(nlcache, recompute_jacobian=false)
     nlsolver.ztmp = nlcache.u
 
     ustep = compute_ustep(tmp, γ, z, method)
@@ -103,7 +103,7 @@ end
     @unpack tstep, invγdt, atmp, ustep = cache
 
     nlcache = nlsolver.cache.cache
-    step!(nlcache)
+    step!(nlcache, recompute_jacobian=false)
     @.. broadcast=false ztmp=nlcache.u
 
     ustep = compute_ustep!(ustep, tmp, γ, z, method)

lib/OrdinaryDiffEqRosenbrock/src/rosenbrock_caches.jl

@@ -705,7 +705,6 @@ struct Rodas4ConstantCache{TF, UF, Tab, JType, WType, F, AD, rateType} <: Rosenb
     W::WType
     linsolve::F
     autodiff::AD
-    du::rateType
     ks::Vector{rateType}
 end
 
@@ -724,11 +723,10 @@ function alg_cache(alg::Union{Rodas4, Rodas42, Rodas4P, Rodas4P2}, u, rate_proto
     linprob = nothing #LinearProblem(W,copy(u); u0=copy(u))
     linsolve = nothing #init(linprob,alg.linsolve,alias_A=true,alias_b=true)
     ks = Vector{typeof(rate_prototype)}(undef, 6)
-    du = zero(rate_prototype)
     Rodas4ConstantCache(tf, uf,
         tabtype(alg)(constvalue(uBottomEltypeNoUnits),
             constvalue(tTypeNoUnits)), J, W, linsolve,
-        alg_autodiff(alg), du, ks)
+        alg_autodiff(alg), ks)
 end
 
 function alg_cache(alg::Union{Rodas4, Rodas42, Rodas4P, Rodas4P2}, u, rate_prototype, ::Type{uEltypeNoUnits},

lib/OrdinaryDiffEqRosenbrock/src/rosenbrock_perform_step.jl

@@ -1208,7 +1208,7 @@ end
 
 @muladd function perform_step!(integrator, cache::Rodas4ConstantCache, repeat_step = false)
     (;t, dt, uprev, u, f, p) = integrator
-    (;tf, uf, du, ks) = cache
+    (;tf, uf, ks) = cache
     (;A, C, gamma, c, d, H) = cache.tab
 
     # Precalculations

lib/OrdinaryDiffEqRosenbrock/src/stiff_addsteps.jl

@@ -291,7 +291,7 @@ function _ode_addsteps!(k, t, uprev, u, dt, f, p, cache::Rodas4ConstantCache,
         always_calc_begin = false, allow_calc_end = true,
         force_calc_end = false)
     if length(k) < 2 || always_calc_begin
-        (;tf, uf, du, ks) = cache
+        (;tf, uf, ks) = cache
         (;A, C, gamma, c, d, H) = cache.tab
 
         # Precalculations
@@ -344,8 +344,8 @@ function _ode_addsteps!(k, t, uprev, u, dt, f, p, cache::Rodas4ConstantCache,
             ks[stage] = _reshape(W \ -_vec(linsolve_tmp), axes(uprev))
         end
 
-        k1 = zero(du)
-        k2 = zero(du)
+        k1 = zero(ks[1])
+        k2 = zero(ks[1])
         H = cache.tab.H
         for i in 1:length(ks)
             k1 = @.. k1 + H[1, i] * ks[i]