Skip to content

Commit c81e278

Browse files
Hotfix precompilation with initialization movement
It's supposed to be a non-specific fallback that's only called if OrdinaryDiffEqNonlinearSolve is not loaded, which works because that always sets the Val{inplace} dispatch. This accidentally added the restriction as well.
1 parent 5bb0876 commit c81e278

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

lib/OrdinaryDiffEqCore/src/initialize_dae.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -120,11 +120,11 @@ function default_nlsolve(
120120
nothing
121121
end
122122

123-
function OrdinaryDiffEqCore.default_nlsolve(::Nothing, isinplace::Val{true}, u, ::NonlinearProblem, autodiff = false)
123+
function OrdinaryDiffEqCore.default_nlsolve(::Nothing, isinplace, u, ::NonlinearProblem, autodiff = false)
124124
error("This ODE requires a DAE initialization and thus a nonlinear solve but no nonlinear solve has been loaded. To solve this problem, do `using OrdinaryDiffEqNonlinearSolve` or pass a custom `nlsolve` choice into the `initializealg`.")
125125
end
126126

127-
function OrdinaryDiffEqCore.default_nlsolve(::Nothing, isinplace::Val{true}, u, ::NonlinearLeastSquaresProblem, autodiff = false)
127+
function OrdinaryDiffEqCore.default_nlsolve(::Nothing, isinplace, u, ::NonlinearLeastSquaresProblem, autodiff = false)
128128
error("This ODE requires a DAE initialization and thus a nonlinear solve but no nonlinear solve has been loaded. To solve this problem, do `using OrdinaryDiffEqNonlinearSolve` or pass a custom `nlsolve` choice into the `initializealg`.")
129129
end
130130

lib/OrdinaryDiffEqRosenbrock/Project.toml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,9 +53,10 @@ ForwardDiff = "f6369f11-7733-5829-9624-2563aa707210"
5353
LinearAlgebra = "37e2e46d-f89d-539d-b4ee-838fcccc9c8e"
5454
LinearSolve = "7ed4a6bd-45f5-4d41-b270-4a48e9bafcae"
5555
ODEProblemLibrary = "fdc4e326-1af4-4b90-96e7-779fcce2daa5"
56+
OrdinaryDiffEqNonlinearSolve = "127b3ac7-2247-4354-8eb6-78cf4e7c58e8"
5657
Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"
5758
SafeTestsets = "1bc83da4-3b8d-516f-aca4-4fe02f6d838f"
5859
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
5960

6061
[targets]
61-
test = ["DiffEqDevTools", "Random", "SafeTestsets", "Test", "LinearAlgebra", "LinearSolve", "ForwardDiff", "ODEProblemLibrary"]
62+
test = ["DiffEqDevTools", "Random", "OrdinaryDiffEqNonlinearSolve", "SafeTestsets", "Test", "LinearAlgebra", "LinearSolve", "ForwardDiff", "ODEProblemLibrary"]

0 commit comments

Comments
 (0)