Merge pull request #2627 from SciML/ranocha-patch-1

fix deprecated HSLDDRK64 constructor

Author: ChrisRackauckas

lib/OrdinaryDiffEqLowStorageRK/src/algorithms.jl

@@ -1000,10 +1000,9 @@ struct HSLDDRK64{StageLimiter, StepLimiter, Thread} <: OrdinaryDiffEqAlgorithm
     thread::Thread
     williamson_condition::Bool
     function HSLDDRK64(stage_limiter! = trivial_limiter!, step_limiter! = trivial_limiter!;
-            williamson_condition = true)
+            williamson_condition = true, thread = False())
         Base.depwarn("HSLDDRK64 is deprecated, use SHLDDRK64 instead.", :HSLDDRK64)
-        SHLDDRK64(stage_limiter!, step_limiter!, thread;
-            williamson_condition = williamson_condition)
+        SHLDDRK64(; stage_limiter!, step_limiter!, thread, williamson_condition)
     end
 end
 

lib/OrdinaryDiffEqLowStorageRK/test/ode_low_storage_rk_tests.jl

@@ -165,6 +165,12 @@ end
     @test sol_old[end] ≈ sol_new[end]
 end
 
+@testset "HSLDDRK64" begin
+    # this method is deprecated
+    alg = HSLDDRK64()
+    @test alg isa SHLDDRK64
+end
+
 @testset "SHLDDRK64" begin
     alg = SHLDDRK64()
     alg2 = SHLDDRK64(; williamson_condition = true)