Skip to content

Commit fff42ce

Browse files
committed
Fix issues in comments
Signed-off-by: ErikQQY <2283984853@qq.com>
1 parent 37732aa commit fff42ce

File tree

2 files changed

+5
-4
lines changed

2 files changed

+5
-4
lines changed

ext/NonlinearSolveSIAMFANLEquationsExt.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,8 +68,8 @@ function SciMLBase.__solve(prob::NonlinearProblem, alg::SIAMFANLEquationsJL, arg
6868
# Jacobian free Newton Krylov
6969
if linsolve !== nothing
7070
JVS = linsolve == :gmres ? zeros(eltype(u), N, 3) : zeros(eltype(u), N)
71-
# `linsolve` as a Symbol to keep unified interface with other EXTs, SIAMFANLEquations directly use String to choose between linear solvers
72-
linsolve_alg = strip(repr(linsolve), ':')
71+
# `linsolve` as a Symbol to keep unified interface with other EXTs, SIAMFANLEquations directly use String to choose between different linear solvers
72+
linsolve_alg = String(linsolve)
7373

7474
if method == :newton
7575
res = nsoli(f!, u, FS, JVS; lsolver = linsolve_alg, maxit = maxiters, atol = abstol, rtol = reltol, printerr = show_trace)

src/extension_algs.jl

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -208,7 +208,7 @@ function NLsolveJL(; method = :trust_region, autodiff = :central, store_trace =
208208
end
209209

210210
"""
211-
SIAMFANLEquationsJL(; method = :newton, autodiff = :central)
211+
SIAMFANLEquationsJL(; method = :newton, autodiff = :central, show_trace = false, delta = 1e-3, linsolve = nothing)
212212
213213
### Keyword Arguments
214214
@@ -222,7 +222,8 @@ end
222222
### Submethod Choice
223223
224224
- `:newton`: Classical Newton method.
225-
- `:pseudotransient`:
225+
- `:pseudotransient`: Pseudo transient method.
226+
- `:secant`: Secant method for scalar equations.
226227
"""
227228
@concrete struct SIAMFANLEquationsJL <: AbstractNonlinearAlgorithm
228229
method::Symbol

0 commit comments

Comments
 (0)