Use tags

Author: avik-pal

.buildkite/pipeline.yml

@@ -18,7 +18,7 @@ steps:
     if: build.message !~ /\[skip tests\]/
 
 env:
-  GROUP: GPU
+  GROUP: CUDA
   JULIA_PKG_SERVER: "" # it often struggles with our large artifacts
   RETESTITEMS_NWORKERS: 4
   RETESTITEMS_NWORKER_THREADS: 2

.github/workflows/CI.yml

@@ -20,6 +20,8 @@ jobs:
         group:
           - Core
           - Downstream
+          - Misc
+          - Wrappers
         version:
           - "1"
         os:

Project.toml

@@ -76,9 +76,10 @@ LazyArrays = "1.8.2"
 LeastSquaresOptim = "0.8.5"
 LineSearches = "7.2"
 LinearAlgebra = "1.10"
-LinearSolve = "2.29"
+LinearSolve = "2.30"
 MINPACK = "1.2"
 MaybeInplace = "0.1.1"
+ModelingToolkit = "9.13.0"
 NLSolvers = "0.5"
 NLsolve = "4.5"
 NaNMath = "1"
@@ -89,11 +90,10 @@ PrecompileTools = "1.2"
 Preferences = "1.4"
 Printf = "1.10"
 Random = "1.91"
-ReTestItems = "1"
+ReTestItems = "1.24"
 RecursiveArrayTools = "3.8"
 Reexport = "1.2"
 SIAMFANLEquations = "1.0.1"
-SafeTestsets = "0.1"
 SciMLBase = "2.34.0"
 SimpleNonlinearSolve = "1.8"
 SparseArrays = "1.10"
@@ -104,7 +104,7 @@ StaticArrays = "1.9"
 StaticArraysCore = "1.4"
 Sundials = "4.23.1"
 SymbolicIndexingInterface = "0.3.15"
-Symbolics = "5.13"
+Symbolics = "5.26"
 Test = "1.10"
 TimerOutputs = "0.5.23"
 Zygote = "0.6.69"
@@ -130,7 +130,6 @@ Pkg = "44cfe95a-1eb2-52ea-b672-e2afdf69b78f"
 Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"
 ReTestItems = "817f1d60-ba6b-4fd5-9520-3cf149f6a823"
 SIAMFANLEquations = "084e46ad-d928-497d-ad5e-07fa361a48c4"
-SafeTestsets = "1bc83da4-3b8d-516f-aca4-4fe02f6d838f"
 SpeedMapping = "f1835b91-879b-4a3f-a438-e4baacf14412"
 StableRNGs = "860ef19b-820b-49d6-a774-d7a799459cd3"
 StaticArrays = "90137ffa-7385-5640-81b9-e52037218182"
@@ -140,4 +139,4 @@ Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
 Zygote = "e88e6eb3-aa80-5325-afca-941959d7151f"
 
 [targets]
-test = ["Aqua", "BandedMatrices", "BenchmarkTools", "CUDA", "Enzyme", "FastLevenbergMarquardt", "FixedPointAcceleration", "LeastSquaresOptim", "MINPACK", "ModelingToolkit", "NLSolvers", "NLsolve", "NaNMath", "NonlinearProblemLibrary", "OrdinaryDiffEq", "Pkg", "Random", "ReTestItems", "SIAMFANLEquations", "SafeTestsets", "SparseDiffTools", "SpeedMapping", "StableRNGs", "StaticArrays", "Sundials", "Symbolics", "Test", "Zygote"]
+test = ["Aqua", "BandedMatrices", "BenchmarkTools", "CUDA", "Enzyme", "FastLevenbergMarquardt", "FixedPointAcceleration", "LeastSquaresOptim", "MINPACK", "ModelingToolkit", "NLSolvers", "NLsolve", "NaNMath", "NonlinearProblemLibrary", "OrdinaryDiffEq", "Pkg", "Random", "ReTestItems", "SIAMFANLEquations", "SpeedMapping", "StableRNGs", "StaticArrays", "Sundials", "Symbolics", "Test", "Zygote"]

test/core/23_test_problems_tests.jl

@@ -40,7 +40,7 @@ end
 export test_on_library, problems, dicts
 end
 
-@testitem "PolyAlgorithms" setup=[RobustnessTesting] begin
+@testitem "PolyAlgorithms" setup=[RobustnessTesting] tags=[:core] begin
     alg_ops = (RobustMultiNewton(), FastShortcutNonlinearPolyalg())
 
     broken_tests = Dict(alg => Int[] for alg in alg_ops)
@@ -50,7 +50,7 @@ end
     test_on_library(problems, dicts, alg_ops, broken_tests)
 end
 
-@testitem "NewtonRaphson" setup=[RobustnessTesting] begin
+@testitem "NewtonRaphson" setup=[RobustnessTesting] tags=[:core] begin
     alg_ops = (NewtonRaphson(),)
 
     broken_tests = Dict(alg => Int[] for alg in alg_ops)
@@ -59,7 +59,7 @@ end
     test_on_library(problems, dicts, alg_ops, broken_tests)
 end
 
-@testitem "TrustRegion" setup=[RobustnessTesting] begin
+@testitem "TrustRegion" setup=[RobustnessTesting] tags=[:core] begin
     alg_ops = (TrustRegion(; radius_update_scheme = RadiusUpdateSchemes.Simple),
         TrustRegion(; radius_update_scheme = RadiusUpdateSchemes.Fan),
         TrustRegion(; radius_update_scheme = RadiusUpdateSchemes.Hei),
@@ -78,7 +78,7 @@ end
     test_on_library(problems, dicts, alg_ops, broken_tests)
 end
 
-@testitem "LevenbergMarquardt" setup=[RobustnessTesting] begin
+@testitem "LevenbergMarquardt" setup=[RobustnessTesting] tags=[:core] begin
     using LinearSolve
 
     alg_ops = (LevenbergMarquardt(), LevenbergMarquardt(; α_geodesic = 0.1),
@@ -92,7 +92,7 @@ end
     test_on_library(problems, dicts, alg_ops, broken_tests)
 end
 
-@testitem "DFSane" setup=[RobustnessTesting] begin
+@testitem "DFSane" setup=[RobustnessTesting] tags=[:core] begin
     alg_ops = (DFSane(),)
 
     broken_tests = Dict(alg => Int[] for alg in alg_ops)
@@ -101,21 +101,28 @@ end
     test_on_library(problems, dicts, alg_ops, broken_tests)
 end
 
-@testitem "Broyden" setup=[RobustnessTesting] begin
+@testitem "Broyden" setup=[RobustnessTesting] tags=[:core] begin
     alg_ops = (Broyden(), Broyden(; init_jacobian = Val(:true_jacobian)),
         Broyden(; update_rule = Val(:bad_broyden)),
         Broyden(; init_jacobian = Val(:true_jacobian), update_rule = Val(:bad_broyden)))
 
     broken_tests = Dict(alg => Int[] for alg in alg_ops)
-    broken_tests[alg_ops[1]] = [1, 5, 11, 15]
-    broken_tests[alg_ops[2]] = [1, 5, 8, 11, 18]
-    broken_tests[alg_ops[3]] = [1, 5, 9, 11]
-    broken_tests[alg_ops[4]] = [5, 6, 8, 11]
+    if Sys.isapple()
+        broken_tests[alg_ops[1]] = [1, 5, 11]
+        broken_tests[alg_ops[2]] = [1, 5, 8, 11, 18]
+        broken_tests[alg_ops[3]] = [1, 5, 6, 9, 11]
+        broken_tests[alg_ops[4]] = [5, 6, 8, 11]
+    else
+        broken_tests[alg_ops[1]] = [1, 5, 11, 15]
+        broken_tests[alg_ops[2]] = [1, 5, 8, 11, 18]
+        broken_tests[alg_ops[3]] = [1, 5, 9, 11]
+        broken_tests[alg_ops[4]] = [5, 6, 8, 11]
+    end
 
-    test_on_library(problems, dicts, alg_ops, broken_tests)
+    test_on_library(problems, dicts, alg_ops, broken_tests, Sys.isapple() ? 1e-3 : 1e-4)
 end
 
-@testitem "Klement" retries=5 setup=[RobustnessTesting] begin
+@testitem "Klement" retries=5 setup=[RobustnessTesting] tags=[:core] begin
     alg_ops = (Klement(), Klement(; init_jacobian = Val(:true_jacobian_diagonal)))
 
     broken_tests = Dict(alg => Int[] for alg in alg_ops)
@@ -125,7 +132,7 @@ end
     test_on_library(problems, dicts, alg_ops, broken_tests)
 end
 
-@testitem "PseudoTransient" setup=[RobustnessTesting] begin
+@testitem "PseudoTransient" setup=[RobustnessTesting] tags=[:core] begin
     # PT relies on the root being a stable equilibrium for convergence, so it won't work on
     # most problems
     alg_ops = (PseudoTransient(),)

test/core/forward_ad_tests.jl

@@ -62,12 +62,14 @@ __compatible(::KINSOL, ::Val{:oop_cache}) = false
 export test_f!, test_f, jacobian_f, solve_with, __compatible
 end
 
-@testitem "ForwardDiff.jl Integration" setup=[ForwardADTesting] begin
+@testitem "ForwardDiff.jl Integration" setup=[ForwardADTesting] tags=[:core] begin
     for alg in (NewtonRaphson(), TrustRegion(), LevenbergMarquardt(),
         PseudoTransient(; alpha_initial = 10.0), Broyden(), Klement(), DFSane(),
         nothing, NLsolveJL(), CMINPACK(), KINSOL(; globalization_strategy = :LineSearch))
         us = (2.0, @SVector[1.0, 1.0], [1.0, 1.0], ones(2, 2), @SArray ones(2, 2))
 
+        alg isa CMINPACK && Sys.isapple() && continue
+
         @testset "Scalar AD" begin
             for p in 1.0:0.1:100.0, u0 in us, mode in (:iip, :oop, :iip_cache, :oop_cache)
                 __compatible(u0, alg) || continue

test/core/nlls_tests.jl

@@ -48,7 +48,7 @@ end
 export solvers, θ_init, x, y_target, true_function, θ_true, loss_function
 end
 
-@testitem "General NLLS Solvers" setup=[CoreNLLSTesting] begin
+@testitem "General NLLS Solvers" setup=[CoreNLLSTesting] tags=[:core] begin
     prob_oop = NonlinearLeastSquaresProblem{false}(loss_function, θ_init, x)
     prob_iip = NonlinearLeastSquaresProblem(
         NonlinearFunction(loss_function; resid_prototype = zero(y_target)), θ_init, x)
@@ -62,7 +62,7 @@ end
     end
 end
 
-@testitem "Custom VJP" setup=[CoreNLLSTesting] begin
+@testitem "Custom VJP" setup=[CoreNLLSTesting] tags=[:core] begin
     # This is just for testing that we can use vjp provided by the user
     function vjp(v, θ, p)
         resid = zeros(length(p))
@@ -96,7 +96,7 @@ end
     end
 end
 
-@testitem "NLLS Analytic Jacobian" begin
+@testitem "NLLS Analytic Jacobian" tags=[:core] begin
     dataIn = 1:10
     f(x, p) = x[1] * dataIn .^ 2 .+ x[2] * dataIn .+ x[3]
     dataOut = f([1, 2, 3], nothing) + 0.1 * randn(10, 1)

test/core/rootfind_tests.jl

@@ -20,7 +20,6 @@ function newton_fails(u, p)
 end
 
 const TERMINATION_CONDITIONS = [
-    SteadyStateDiffEqTerminationMode(), SimpleNonlinearSolveTerminationMode(),
     NormTerminationMode(), RelTerminationMode(), RelNormTerminationMode(),
     AbsTerminationMode(), AbsNormTerminationMode(), RelSafeTerminationMode(),
     AbsSafeTerminationMode(), RelSafeBestTerminationMode(), AbsSafeBestTerminationMode()]
@@ -53,7 +52,7 @@ end
 
 # --- NewtonRaphson tests ---
 
-@testitem "NewtonRaphson" setup=[CoreRootfindTesting] begin
+@testitem "NewtonRaphson" setup=[CoreRootfindTesting] tags=[:core] timeout=3600 begin
     @testset "LineSearch: $(_nameof(lsmethod)) LineSearch AD: $(_nameof(ad))" for lsmethod in (
             Static(), StrongWolfe(), BackTracking(), HagerZhang(), MoreThuente()),
         ad in (AutoFiniteDiff(), AutoZygote())
@@ -119,7 +118,7 @@ end
 
 # --- TrustRegion tests ---
 
-@testitem "TrustRegion" setup=[CoreRootfindTesting] begin
+@testitem "TrustRegion" setup=[CoreRootfindTesting] tags=[:core] timeout=3600 begin
     radius_update_schemes = [RadiusUpdateSchemes.Simple, RadiusUpdateSchemes.NocedalWright,
         RadiusUpdateSchemes.NLsolve, RadiusUpdateSchemes.Hei,
         RadiusUpdateSchemes.Yuan, RadiusUpdateSchemes.Fan, RadiusUpdateSchemes.Bastin]
@@ -237,7 +236,7 @@ end
 
 # --- LevenbergMarquardt tests ---
 
-@testitem "LevenbergMarquardt" setup=[CoreRootfindTesting] begin
+@testitem "LevenbergMarquardt" setup=[CoreRootfindTesting] tags=[:core] timeout=3600 begin
     u0s = ([1.0, 1.0], @SVector[1.0, 1.0], 1.0)
     @testset "[OOP] u0: $(typeof(u0))" for u0 in u0s
         sol = benchmark_nlsolve_oop(quadratic_f, u0; solver = LevenbergMarquardt())
@@ -323,7 +322,7 @@ end
 
 # --- DFSane tests ---
 
-@testitem "DFSane" setup=[CoreRootfindTesting] begin
+@testitem "DFSane" setup=[CoreRootfindTesting] tags=[:core] timeout=3600 begin
     u0s = ([1.0, 1.0], @SVector[1.0, 1.0], 1.0)
 
     @testset "[OOP] u0: $(typeof(u0))" for u0 in u0s
@@ -394,7 +393,7 @@ end
 
 # --- PseudoTransient tests ---
 
-@testitem "PseudoTransient" setup=[CoreRootfindTesting] begin
+@testitem "PseudoTransient" setup=[CoreRootfindTesting] tags=[:core] timeout=3600 begin
     # These are tests for NewtonRaphson so we should set alpha_initial to be high so that we
     # converge quickly
     @testset "PT: alpha_initial = 10.0 PT AD: $(ad)" for ad in (
@@ -463,7 +462,7 @@ end
 
 # --- Broyden tests ---
 
-@testitem "Broyden" setup=[CoreRootfindTesting] begin
+@testitem "Broyden" setup=[CoreRootfindTesting] tags=[:core] timeout=3600 begin
     @testset "LineSearch: $(_nameof(lsmethod)) LineSearch AD: $(_nameof(ad)) Init Jacobian: $(init_jacobian) Update Rule: $(update_rule)" for lsmethod in (
             Static(), StrongWolfe(), BackTracking(),
             HagerZhang(), MoreThuente(), LiFukushimaLineSearch()),
@@ -513,7 +512,7 @@ end
 
 # --- Klement tests ---
 
-@testitem "Klement" setup=[CoreRootfindTesting] begin
+@testitem "Klement" setup=[CoreRootfindTesting] tags=[:core] timeout=3600 begin
     @testset "LineSearch: $(_nameof(lsmethod)) LineSearch AD: $(_nameof(ad)) Init Jacobian: $(init_jacobian)" for lsmethod in (
             Static(), StrongWolfe(), BackTracking(), HagerZhang(), MoreThuente()),
         ad in (AutoFiniteDiff(), AutoZygote()),
@@ -562,7 +561,7 @@ end
 
 # --- LimitedMemoryBroyden tests ---
 
-@testitem "LimitedMemoryBroyden" setup=[CoreRootfindTesting] begin
+@testitem "LimitedMemoryBroyden" setup=[CoreRootfindTesting] tags=[:core] timeout=3600 begin
     @testset "LineSearch: $(_nameof(lsmethod)) LineSearch AD: $(_nameof(ad))" for lsmethod in (
             Static(), StrongWolfe(), BackTracking(),
             HagerZhang(), MoreThuente(), LiFukushimaLineSearch()),
@@ -612,7 +611,7 @@ end
 end
 
 # Miscellaneous Tests
-@testitem "Custom JVP" setup=[CoreRootfindTesting] begin
+@testitem "Custom JVP" setup=[CoreRootfindTesting] tags=[:core] timeout=3600 begin
     function F(u::Vector{Float64}, p::Vector{Float64})
         Δ = Tridiagonal(-ones(99), 2 * ones(100), -ones(99))
         return u + 0.1 * u .* Δ * u - p

test/downstream/mtk_cache_indexing_tests.jl

@@ -1,46 +1,48 @@
-using ModelingToolkit, NonlinearSolve
-using ModelingToolkit: t_nounits as t
-
-@parameters p d
-@variables X(t)
-eqs = [0 ~ sin(X + p) - d * sqrt(X + 1)]
-@mtkbuild nlsys = NonlinearSystem(eqs, [X], [p, d])
-
-# Creates an integrator.
-nlprob = NonlinearProblem(nlsys, [X => 1.0], [p => 2.0, d => 3.0])
-
-@testset "GeneralizedFirstOrderAlgorithmCache" begin
-    nint = init(nlprob, NewtonRaphson())
-    @test nint isa NonlinearSolve.GeneralizedFirstOrderAlgorithmCache
-
-    @test nint[X] == 1.0
-    @test nint[nlsys.X] == 1.0
-    @test nint[:X] == 1.0
-    @test nint.ps[p] == 2.0
-    @test nint.ps[nlsys.p] == 2.0
-    @test nint.ps[:p] == 2.0
-end
-
-@testset "NonlinearSolvePolyAlgorithmCache" begin
-    nint = init(nlprob, FastShortcutNonlinearPolyalg())
-    @test nint isa NonlinearSolve.NonlinearSolvePolyAlgorithmCache
-
-    @test nint[X] == 1.0
-    @test nint[nlsys.X] == 1.0
-    @test nint[:X] == 1.0
-    @test nint.ps[p] == 2.0
-    @test nint.ps[nlsys.p] == 2.0
-    @test nint.ps[:p] == 2.0
-end
-
-@testset "NonlinearSolveNoInitCache" begin
-    nint = init(nlprob, SimpleNewtonRaphson())
-    @test nint isa NonlinearSolve.NonlinearSolveNoInitCache
-
-    @test nint[X] == 1.0
-    @test nint[nlsys.X] == 1.0
-    @test nint[:X] == 1.0
-    @test nint.ps[p] == 2.0
-    @test nint.ps[nlsys.p] == 2.0
-    @test nint.ps[:p] == 2.0
+@testitem "Modeling Toolkit Cache Indexing" tags=[:downstream] begin
+    using ModelingToolkit
+    using ModelingToolkit: t_nounits as t
+
+    @parameters p d
+    @variables X(t)
+    eqs = [0 ~ sin(X + p) - d * sqrt(X + 1)]
+    @mtkbuild nlsys = NonlinearSystem(eqs, [X], [p, d])
+
+    # Creates an integrator.
+    nlprob = NonlinearProblem(nlsys, [X => 1.0], [p => 2.0, d => 3.0])
+
+    @testset "GeneralizedFirstOrderAlgorithmCache" begin
+        nint = init(nlprob, NewtonRaphson())
+        @test nint isa NonlinearSolve.GeneralizedFirstOrderAlgorithmCache
+
+        @test nint[X] == 1.0
+        @test nint[nlsys.X] == 1.0
+        @test nint[:X] == 1.0
+        @test nint.ps[p] == 2.0
+        @test nint.ps[nlsys.p] == 2.0
+        @test nint.ps[:p] == 2.0
+    end
+
+    @testset "NonlinearSolvePolyAlgorithmCache" begin
+        nint = init(nlprob, FastShortcutNonlinearPolyalg())
+        @test nint isa NonlinearSolve.NonlinearSolvePolyAlgorithmCache
+
+        @test nint[X] == 1.0
+        @test nint[nlsys.X] == 1.0
+        @test nint[:X] == 1.0
+        @test nint.ps[p] == 2.0
+        @test nint.ps[nlsys.p] == 2.0
+        @test nint.ps[:p] == 2.0
+    end
+
+    @testset "NonlinearSolveNoInitCache" begin
+        nint = init(nlprob, SimpleNewtonRaphson())
+        @test nint isa NonlinearSolve.NonlinearSolveNoInitCache
+
+        @test nint[X] == 1.0
+        @test nint[nlsys.X] == 1.0
+        @test nint[:X] == 1.0
+        @test nint.ps[p] == 2.0
+        @test nint.ps[nlsys.p] == 2.0
+        @test nint.ps[:p] == 2.0
+    end
 end

test/gpu/core_tests.jl

@@ -1,4 +1,4 @@
-@testitem "CUDA Tests" begin
+@testitem "CUDA Tests" tags=[:cuda] skip=:(using CUDA; !CUDA.functional()) begin
     using CUDA, NonlinearSolve, LinearSolve, StableRNGs
 
     CUDA.allowscalar(false)

test/misc/aliasing_tests.jl

@@ -1,4 +1,4 @@
-@testitem "PolyAlgorithm Aliasing" begin
+@testitem "PolyAlgorithm Aliasing" tags=[:misc] begin
     using NonlinearProblemLibrary
 
     # Use a problem that the initial solvers cannot solve and cause the initial value to