Fix UMFPACK for zero init safety

Author: ChrisRackauckas

src/factorization.jl

@@ -78,6 +78,7 @@ end
 function init_cacheval(alg::UMFPACKFactorization, A, b, u, Pl, Pr, maxiters, abstol, reltol,
                        verbose)
     A = convert(AbstractMatrix, A)
+    #=
     zerobased = SparseArrays.getcolptr(A)[1] == 0
     res = SuiteSparse.UMFPACK.UmfpackLU(C_NULL, C_NULL, size(A, 1), size(A, 2),
                                         zerobased ? copy(SparseArrays.getcolptr(A)) :
@@ -86,6 +87,9 @@ function init_cacheval(alg::UMFPACKFactorization, A, b, u, Pl, Pr, maxiters, abs
                                         SuiteSparse.decrement(rowvals(A)),
                                         copy(nonzeros(A)), 0)
     finalizer(SuiteSparse.UMFPACK.umfpack_free_symbolic, res)
+    =#
+    res = lu(A; check = false)
+    @assert res isa SuiteSparse.UMFPACK.UmfpackLU
     res
 end
 

test/runtests.jl

@@ -20,6 +20,7 @@ end
 
 if GROUP == "All" || GROUP == "Core"
     @time @safetestset "Basic Tests" begin include("basictests.jl") end
+    @time @safetestset "Zero Initialization Tests" begin include("zeroinittests.jl") end
 end
 
 if GROUP == "LinearSolveCUDA"

test/zeroinittests.jl

@@ -0,0 +1,23 @@
+using LinearSolve, LinearAlgebra, SparseArrays, Test
+
+A = Diagonal(ones(4))
+b = rand(4)
+A = sparse(A)
+Anz = deepcopy(A)
+A.nzval .= 0
+cache_kwargs = (; verbose = true, abstol = 1e-8, reltol = 1e-8, maxiter = 30)
+
+
+function test_nonzero_init(alg=nothing)
+    linprob = LinearProblem(A,b)
+
+    cache = init(linprob)
+    cache = LinearSolve.set_A(cache, Anz)
+    @show cache.A
+    sol = solve(cache,nothing;cache_kwargs...)
+    @test sol.u == b
+end
+
+test_nonzero_init()
+test_nonzero_init(KLUFactorization())
+test_nonzero_init(UMFPACKFactorization())