Updated sendOTP logic

Author: Amruth-Vamshi

src/api/api.controller.ts

@@ -102,11 +102,15 @@ export class ApiController {
       }
     }
 
-    let status: any, isWhatsApp = false;
+    let status: any, isWhatsApp = false, countryCode, number;
      // Check if phone number contains country code (e.g. 91-1234567890)
-     if (params.phone.includes('-')) {
+     if (params.deliveryType=='WA') {
       isWhatsApp = true;
-      const [countryCode, number] = params.phone.split('-');
+      if (params.phone.includes('-')) {
+        [countryCode, number] = params.phone.split('-');
+      } else {
+        number = params.phone;
+      }
       params.phone = number;
       status = await this.gupshupWhatsappService.sendWhatsappOTP({
         phone: number,
@@ -136,6 +140,15 @@ export class ApiController {
     return { status };
   }
 
+  @Post('login/otp')
+  @UsePipes(new ValidationPipe({ transform: true }))
+  async loginWithOtp(
+    @Body() user: LoginDto,
+    @Headers('authorization') authHeader,
+  ): Promise<any> {
+    return await this.apiService.loginWithOtp(user, authHeader);
+  }
+
   @Get('verifyOTP')
   @UsePipes(new ValidationPipe({ transform: true }))
   async verifyOTP(@Query() params: VerifyOtpDto): Promise<any> {
@@ -400,15 +413,6 @@ export class ApiController {
     );
   }
 
-  @Post('login/otp')
-  @UsePipes(new ValidationPipe({ transform: true }))
-  async loginWithOtp(
-    @Body() user: LoginDto,
-    @Headers('authorization') authHeader,
-  ): Promise<any> {
-    return await this.apiService.loginWithOtp(user, authHeader);
-  }
-
   @Post('login-with-unique-id')
   @UsePipes(new ValidationPipe({ transform: true }))
   async loginWithUniqueId(

src/api/api.service.ts

@@ -564,6 +564,7 @@ export class ApiService {
      */
     let otp = loginDto.password;
     let phone = loginDto.loginId;
+    let countryCode, number;
     const salt = this.configResolverService.getSalt(loginDto.applicationId);
     let verifyOTPResult;
     if(
@@ -575,8 +576,12 @@ export class ApiService {
         verifyOTPResult = {status: SMSResponseStatus.success}
         else
         verifyOTPResult = {status: SMSResponseStatus.failure}
-      } else if (phone.includes('-')) {
-        const [countryCode, number] = phone.split('-');
+      } else if (loginDto.deliveryType=='WA') {
+        if(phone.includes('-')){
+          [countryCode, number] = phone.split('-');
+        } else {
+          number = phone
+        }
         loginDto.loginId = number;
         const status: any = await this.gupshupWhatsappService.verifyWhatsappOTP(loginDto.loginId, loginDto.password);
         if(status.status == 'success') {

src/api/dto/login.dto.ts

@@ -1,5 +1,5 @@
 import {
-  IsNotEmpty, IsString, IsUUID, MaxLength,
+  IsNotEmpty, IsOptional, IsString, IsUUID, MaxLength,
 } from 'class-validator';
 
 export class LoginDto {
@@ -16,6 +16,10 @@ export class LoginDto {
   @IsUUID()
   @IsNotEmpty()
   applicationId: string;
+
+  @IsString()
+  @IsOptional()
+  deliveryType?: string;
 }
 
 

src/api/dto/send-otp.dto.ts

@@ -19,4 +19,8 @@ export class SendOtpDto {
   @IsString()
   @IsOptional()
   orgId?: string;
+
+  @IsString()
+  @IsOptional()
+  deliveryType?: string;
 }

src/user/dto/login.dto.ts

@@ -7,4 +7,5 @@ export class LoginDto {
   roles?: Array<string>;
   fingerprint?: string;
   timestamp?: string;
+  deliveryType?: string;
 }