fix(proxmox): add domain name suffix if needed (#533)

Author: n-rodriguez

README.md

@@ -93,6 +93,7 @@ Example configuration can be found [here](#example-config).
 | `source.ignoreAssetTags`                 | Don't sync asset tags of devices.                                                                                                                                                      | all                        | bool     | [true, false]                            | false      | No       |
 | `source.ignoreSerialNumbers`             | Don't sync serial numbers of devices.                                                                                                                                                  | all                        | bool     | [true, false]                            | false      | No       |
 | `source.ignoreVMTemplates`               | Don't sync vm templates.                                                                                                                                                               | [**vmware**,**Proxmox**]   | bool     | [true, false]                            | false      | No       |
+| `source.AssignDomainName`                | Suffix node name with `AssignDomainName`.                                                                                                                                              | [**proxmox**]              | str      | any                                      | ""         | No       |
 | `source.datacenterClusterGroupRelations` | Regex relations in format `regex = clusterGroupName`, that map each datacenter that satisfies regex to clusterGroupname. | [**vmware**, **ovirt**]    | []string | any                                      | []         | No       |
 | `source.hostSiteRelations`               | Regex relations in format `regex = siteName`, that map each host that satisfies regex to site.                                                                                         | all                        | []string | any                                      | []         | No       |
 | `source.clusterSiteRelations`            | Regex relations in format `regex = siteName`, that map each cluster that satisfies regex to site.                                                                                      | all                        | []string | any                                      | []         | No       |

internal/parser/parser.go

@@ -132,6 +132,7 @@ type SourceConfig struct {
 	IgnoreAssetTags     bool                 `yaml:"ignoreAssetTags"`
 	IgnoreSerialNumbers bool                 `yaml:"ignoreSerialNumbers"`
 	IgnoreVMTemplates   bool                 `yaml:"ignoreVMTemplates"`
+	AssignDomainName    string               `yaml:"assignDomainName"`
 
 	// Relations
 	DatacenterClusterGroupRelations map[string]string `yaml:"datacenterClusterGroupRelations"`
@@ -165,6 +166,7 @@ func (sc *SourceConfig) UnmarshalYAML(unmarshal func(interface{}) error) error {
 		ValidateCert                    bool                 `yaml:"validateCert"`
 		Tag                             string               `yaml:"tag"`
 		TagColor                        string               `yaml:"tagColor"`
+		AssignDomainName                string               `yaml:"assignDomainName"`
 		IgnoredSubnets                  []string             `yaml:"ignoredSubnets"`
 		PermittedSubnets                []string             `yaml:"permittedSubnets"`
 		InterfaceFilter                 string               `yaml:"interfaceFilter"`
@@ -203,6 +205,7 @@ func (sc *SourceConfig) UnmarshalYAML(unmarshal func(interface{}) error) error {
 	sc.ValidateCert = rawMarshal.ValidateCert
 	sc.Tag = rawMarshal.Tag
 	sc.TagColor = rawMarshal.TagColor
+	sc.AssignDomainName = rawMarshal.AssignDomainName
 	sc.IgnoredSubnets = rawMarshal.IgnoredSubnets
 	sc.PermittedSubnets = rawMarshal.PermittedSubnets
 	sc.InterfaceFilter = rawMarshal.InterfaceFilter
@@ -323,7 +326,7 @@ func (sc SourceConfig) String() string {
 	return fmt.Sprintf(
 		"SourceConfig{Name: %s, Type: %s, HTTPScheme: %s, Hostname: %s, Port: %d, "+
 			"Username: %s, Password: %s, PermittedSubnets: %v, ValidateCert: %t, "+
-			"Tag: %s, TagColor: %s, DatacenterClusterGroupRelations: %s, "+
+			"Tag: %s, TagColor: %s, AssignDomainName: %s, DatacenterClusterGroupRelations: %s, "+
 			"HostSiteRelations: %v, ClusterSiteRelations: %v, ClusterTenantRelations: %v, "+
 			"HostTenantRelations: %v, VmTenantRelations: %v, VlanGroupRelations: %v, "+
 			"VlanTenantRelations: %v, WlanTenantRelations: %v}",
@@ -338,6 +341,7 @@ func (sc SourceConfig) String() string {
 		sc.ValidateCert,
 		sc.Tag,
 		sc.TagColor,
+		sc.AssignDomainName,
 		sc.DatacenterClusterGroupRelations,
 		sc.HostSiteRelations,
 		sc.ClusterSiteRelations,

internal/source/proxmox/proxmox_sync.go

@@ -78,6 +78,12 @@ func (ps *ProxmoxSource) syncNodes(nbi *inventory.NetboxInventory) error {
 	ps.NetboxNodes = make(map[string]*objects.Device, len(ps.Nodes))
 	for _, node := range ps.Nodes {
 		var hostSite *objects.Site
+
+		// Add domain name suffix if needed
+		if ps.SourceConfig.AssignDomainName != "" {
+			node.Name += ps.SourceConfig.AssignDomainName
+		}
+
 		if ps.NetboxCluster.ScopeType == constants.ContentTypeDcimSite {
 			hostSite = nbi.GetSiteByID(ps.NetboxCluster.ScopeID)
 		}
@@ -227,6 +233,11 @@ func (ps *ProxmoxSource) syncVMs(nbi *inventory.NetboxInventory) error {
 	var wg sync.WaitGroup
 
 	for nodeName, vms := range ps.Vms {
+		// Add domain name suffix if needed
+		if ps.SourceConfig.AssignDomainName != "" {
+			nodeName += ps.SourceConfig.AssignDomainName
+		}
+
 		nbHost := ps.NetboxNodes[nodeName]
 		for _, vm := range vms {
 			guard <- struct{}{} // Block if maxGoroutines are running
@@ -463,6 +474,11 @@ func (ps *ProxmoxSource) syncContainers(nbi *inventory.NetboxInventory) error {
 			return fmt.Errorf("create container role: %s", err)
 		}
 		for nodeName, containers := range ps.Containers {
+			// Add domain name suffix if needed
+			if ps.SourceConfig.AssignDomainName != "" {
+				nodeName += ps.SourceConfig.AssignDomainName
+			}
+
 			nbHost := ps.NetboxNodes[nodeName]
 			for _, container := range containers {
 				// Determine Container status