Skip to content

Commit 5b32315

Browse files
committed
updating security context
1 parent f3a6387 commit 5b32315

File tree

4 files changed

+11
-3
lines changed

4 files changed

+11
-3
lines changed

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,11 @@
11
## Changelog
22

3+
### V2.4.0
4+
5+
#### Potentially Breaking Changes
6+
7+
- Removing the chown of the data directory initialization and instead switching the security context to use the factorio user specified in [factorio docker](https://github.com/factoriotools/factorio-docker/blob/master/docker/Dockerfile). This will fix the nfs permissions but could potentially cause issues elsewhere if you were setting the security context.
8+
39
### V2.3.0
410

511
#### Non-Breaking Changes

charts/factorio-server-charts/Chart.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ sources:
2020
# This is the chart version. This version number should be incremented each time you make changes
2121
# to the chart and its templates, including the app version.
2222
# Versions are expected to follow Semantic Versioning (https://semver.org/)
23-
version: 2.3.0
23+
version: 2.4.0
2424

2525
# This is the version number of the application being deployed. This version number should be
2626
# incremented each time you make changes to the application. Versions are not expected to

charts/factorio-server-charts/templates/deployment.yaml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,6 @@ spec:
5353
jq -M --rawfile game_password /gamePassword/game_password '.game_password=($game_password|gsub("[\\n\\t]"; ""))' /factorio/configs/server-settings.json > /tmp/server-settings.json && mv /tmp/server-settings.json /factorio/configs/server-settings.json
5454
fi
5555
#sleep 100
56-
chown -vR factorio:factorio /factorio
5756
chmod -vR 777 /factorio/configs
5857
ls -alth /factorio
5958
{{- with .Values.securityContext }}

charts/factorio-server-charts/values.yaml

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,11 @@ replicaCount: 1
1414

1515
hostNetworkEnabled: true
1616

17+
# https://github.com/factoriotools/factorio-docker/blob/master/docker/Dockerfile
1718
securityContext:
18-
runAsUser: 0
19+
runAsUser: 845
20+
runAsGroup: 845
21+
fsGroup: 845
1922

2023
#### Image Configuration ####
2124
## @section Image Parameters

0 commit comments

Comments
 (0)