Fix harrass strength calculation issue #518

Author: SMUnlimited

CHANGELOG.md

@@ -19,6 +19,8 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
 - Fixed some consistency and edge case issues when checking if expansions are claimed. (jzy-chitong56)
 - Improvements to the chinese language translations (jzy-chitong56)
 - Fixes to random hero mode not being responsive enough in detecting the hero.
+- Fixed minor memory leak in harass (jzy-chitong56)
+- Fixed mistake in harass strength calculation (jzy-chitong56)
 - (DevTools) Strategy Manager will strip whitespace when extracting or importing new strategies and profiles correctly. (jzy-chitong56)
 
 ## [3.4.2b] - 2025-04-05

common.eai

@@ -10086,8 +10086,8 @@ endfunction
 function StartHarass takes integer groupnum, integer harass_target, boolean avoid_towers, real strength_limit, real flee_percent, integer flee_number, real lx, real ly returns nothing
   local integer i = 0
   local integer t = 0
-  local group harasser = CreateGroup()
-  local group g = CreateGroup()
+  local group harasser = null
+  local group g = null
   local integer key = groupnum
   local real strength = 0
   local integer qty = 0
@@ -10097,6 +10097,9 @@ function StartHarass takes integer groupnum, integer harass_target, boolean avoi
     // This harass is still running
     return
   endif
+
+  set harasser = CreateGroup()
+  set g = CreateGroup()
 
   call GroupEnumUnitsOfPlayer(g, ai_player, null)
   set g = SelectByHidden(g, false)
@@ -10154,8 +10157,8 @@ function GetHarassGroupStrength takes integer groupnum returns real
   local integer t = 0
   loop
     exitwhen i >= harass_size[groupnum] or t >= 12
-    set id = LoadInteger(harass_groups, groupnum, i)
-    set qty = LoadInteger(harass_groups, groupnum, i + 1)
+    set qty = LoadInteger(harass_groups, groupnum, i)
+    set id = LoadInteger(harass_groups, groupnum, i + 1)
     set t = t + qty 
     if t + qty > 12 then
       set qty = 12 - t