Skip to content

Add topological queries #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 2, 2025
Merged

Conversation

CKegel
Copy link

@CKegel CKegel commented Jun 26, 2025

Adds topological queries to the Model2D Class by:

  • Making the Model2D Fields private, and providing inline "getter" functions
  • Reworking the Model2D loading routine. It now utilizes private helper functions to populate the Model2D Fields
  • Adding documentation with oxygen.

This PR also bumps the maximum version of Simmetrix to 2025.1.250507.

@CKegel CKegel marked this pull request as draft June 26, 2025 18:22
Stores topological data in private fields and provides a "getter" api to access topological data. Also adds in code doxygen documentation.
@CKegel CKegel force-pushed the ck/model2dSim branch 3 times, most recently from 7eaba70 to afd6331 Compare July 2, 2025 16:17
@CKegel CKegel marked this pull request as ready for review July 2, 2025 17:26
@CKegel CKegel requested a review from cwsmith July 2, 2025 17:26
@cwsmith
Copy link

cwsmith commented Jul 2, 2025

/runtests

Copy link

github-actions bot commented Jul 2, 2025

Test Result: success (details)

Copy link

@cwsmith cwsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you.

@cwsmith cwsmith merged commit 24c76b9 into SCOREC:cws/model2dSim Jul 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants