Skip to content

feat(cli): Add 'quiet' option to report errors only #629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 27, 2025

Conversation

marianfoo
Copy link
Contributor

@marianfoo marianfoo commented Apr 15, 2025

UI5 linter reports findings declared as warnings and errors. There are scenarios where only findings declared as an error should be reported. ESLint offers also an CLI option "quiet" to achieve this.

JIRA: CPOUI5FOUNDATION-837

@marianfoo
Copy link
Contributor Author

had some trouble with exitCode in the test, don´t know if this was correctly handled

@flovogt flovogt self-assigned this Apr 16, 2025
@flovogt
Copy link
Member

flovogt commented Apr 16, 2025

Thanks a lot for your contribution @marianfoo. We will take care of this PR in backlog item CPOUI5FOUNDATION-837.

@flovogt flovogt added the configuration An issue related to configuration capabilities label Apr 16, 2025
@marianfoo marianfoo force-pushed the feat/option-quiet branch from 521fcbc to b10be3d Compare May 15, 2025 09:09
@marianfoo marianfoo requested a review from RandomByte May 15, 2025 09:09
@CLAassistant
Copy link

CLAassistant commented Jun 23, 2025

CLA assistant check
All committers have signed the CLA.

@RandomByte RandomByte changed the title feat: Add option quiet to hide warnings in output feat(cli): Add 'quiet' option to report errors only Jun 26, 2025
@RandomByte
Copy link
Member

Rebased, snapshots updated (using npm run unit-update-snapshots), commit message and eslint errors resolved + minor readme update 👍

Let's get a review from UA and from another developer of the team.

@RandomByte RandomByte requested review from KlattG and a team June 26, 2025 15:06
@RandomByte
Copy link
Member

Sorry to bother you @marianfoo, but since we moved the repository to a new organization, you'll need to sign the CLA again (see comment above)

@coveralls
Copy link

Coverage Status

coverage: 86.555% (+0.2%) from 86.382%
when pulling 78d3731 on marianfoo:feat/option-quiet
into 156a02c on UI5:main.

@RandomByte RandomByte dismissed their stale review June 27, 2025 08:21

Outdated

Copy link
Contributor

@KlattG KlattG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RandomByte RandomByte merged commit 6c94b01 into UI5:main Jun 27, 2025
31 of 34 checks passed
@openui5bot openui5bot mentioned this pull request Jun 27, 2025
@marianfoo
Copy link
Contributor Author

Thank you @RandomByte for the final changes and the team for approving and merging my PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
configuration An issue related to configuration capabilities
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants