feat: Add option quiet to hide warnings in output #629
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
had some trouble with |
|
Thanks a lot for your contribution @marianfoo. We will take care of this PR in backlog item CPOUI5FOUNDATION-837. |
RandomByte
requested changes
May 8, 2025
| fixableWarningCount: 0, | ||
| })); | ||
| }; | ||
|
|
There was a problem hiding this comment.
Why not overwrite res here once so it affects all the cases below?
| @@ -28,7 +28,7 @@ export class Json { | |||
| filePath: oLintedFile.filePath, | |||
| messages: aFileMessages, | |||
| errorCount: oLintedFile.errorCount, | |||
| warningCount: oLintedFile.warningCount, | |||
| warningCount: quiet ? 0 : oLintedFile.warningCount, | |||
There was a problem hiding this comment.
Is this necessary? warningCount should be set to 0 in the filter function?
Comment on lines
+68
to
+76
| if (quiet) { | ||
| summary += | ||
| `> ${totalErrorCount} ${totalErrorCount === 1 ? "problem" : "problems"} ` + | ||
| `(${totalErrorCount} ${totalErrorCount === 1 ? "error" : "errors"}) \n`; | ||
| } else { | ||
| summary += | ||
| `> ${totalErrorCount + totalWarningCount} problems ` + | ||
| `(${totalErrorCount} errors, ${totalWarningCount} warnings) \n`; | ||
| } |
There was a problem hiding this comment.
Ideally both outputs behave the same. So If we make a distinction for singular/plural in quite mode, I would expect the same in regular mode.
Maybe something like this?
Suggested change
| if (quiet) { | |
| summary += | |
| `> ${totalErrorCount} ${totalErrorCount === 1 ? "problem" : "problems"} ` + | |
| `(${totalErrorCount} ${totalErrorCount === 1 ? "error" : "errors"}) \n`; | |
| } else { | |
| summary += | |
| `> ${totalErrorCount + totalWarningCount} problems ` + | |
| `(${totalErrorCount} errors, ${totalWarningCount} warnings) \n`; | |
| } | |
| const errorsText = `${totalErrorCount} ${totalErrorCount === 1 ? "error" : "errors"}`; | |
| let warningsText = ""; | |
| if (!quiet) { | |
| warningsText = `, ${totalWarningCount} ${totalWarningCount === 1 ? "warning" : "warnings"}`; | |
| } | |
| summary += | |
| `> ${totalErrorCount + totalWarningCount} problems ` + | |
| `(${errorsText}${warningsText}) \n`; |
| if (quiet) { | ||
| this.#writeln( | ||
| summaryColor( | ||
| `${totalErrorCount} ${totalErrorCount === 1 ? "problem" : "problems"} ` + |
|
|
||
| t.is(consoleLogStub.callCount, 0, "console.log should not be used"); | ||
| t.true(processCwdStub.callCount > 0, "process.cwd was called"); | ||
| t.is(processStdoutWriteStub.callCount, 2, "process.stdout.write was called twice"); | ||
| t.is(processExitStub.callCount, 0, "process.exit got never called"); | ||
| t.is(process.exitCode, 1, "process.exitCode was set to 1"); |
There was a problem hiding this comment.
What was the problem with the old exitCode handling in this test?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for your contribution! 🙌
To get it merged faster, kindly review the checklist below:
Pull Request Checklist