Skip to content

Commit c8bb0ec

Browse files
feat: ui5 language assistant logo (#746)
* feat: ui5 language assistant logo * chore: changeset * fix: ui5 version * fix: change set * fix: failing test * fix: add change set * fix: update to `sonarcube-scan-action` in release.yaml * fix: version typo `sonarcube-scan-action` --------- Co-authored-by: Maruf Rasully <maruf.rasully@sap.com>
1 parent 29cc303 commit c8bb0ec

File tree

9 files changed

+25
-40
lines changed

9 files changed

+25
-40
lines changed

.changeset/calm-shrimps-give.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@ui5-language-assistant/context": patch
3+
---
4+
5+
feat: new logo

.changeset/eleven-yaks-hang.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"vscode-ui5-language-assistant": patch
3+
---
4+
5+
feat: new logo

.changeset/quick-jobs-approve.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
---
2+
"@ui5-language-assistant/test-utils": patch
3+
"@ui5-language-assistant/constant": patch
4+
"@ui5-language-assistant/vscode-ui5-language-assistant-bas-ext": patch
5+
---
6+
7+
feat: new logo

.github/workflows/release.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ jobs:
3333

3434
- name: Run SonarCloud scan
3535
if: matrix.os == 'ubuntu-latest' && matrix.node-version == '14.x'
36-
uses: sonarsource/sonarcloud-github-action@master
36+
uses: SonarSource/sonarqube-scan-action@v5.2.0
3737
env:
3838
GITHUB_TOKEN: ${{ secrets.ACCESS_PAT }}
3939
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}

packages/constant/src/constant.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@ export const OPEN_FRAMEWORK = "OpenUI5";
22
export const DEFAULT_UI5_FRAMEWORK = "SAPUI5";
33

44
//https://ui5.sap.com/version.json
5-
export const DEFAULT_UI5_VERSION = "1.71.73";
5+
export const DEFAULT_UI5_VERSION = "1.71.75";
66
// https://sdk.openui5.org/version.json
7-
export const DEFAULT_OPEN_UI5_VERSION = "1.71.69";
7+
export const DEFAULT_OPEN_UI5_VERSION = "1.71.71";
88

99
export const DEFAULT_UI5_VERSION_BASE = "1.71";
1010

packages/context/test/unit/ui5-model.test.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -578,10 +578,10 @@ describe("the UI5 language assistant ui5 model", () => {
578578
expected: () => getExpectedVersion("SAPUI5", "1.104"),
579579
},
580580
{
581-
// supported version
582-
version: () => Object.keys(currentVersionMaps.SAPUI5)[1],
581+
// supported version - take second entry which is supported version (now it ias latest and active entry)
582+
version: () => Object.keys(currentVersionMaps.SAPUI5)[2],
583583
expected: () =>
584-
currentVersionMaps.SAPUI5[Object.keys(currentVersionMaps.SAPUI5)[1]]
584+
currentVersionMaps.SAPUI5[Object.keys(currentVersionMaps.SAPUI5)[2]]
585585
.version,
586586
},
587587
{
Loading

packages/vscode-ui5-language-assistant/resources/ui5-language-assistant.svg

Lines changed: 0 additions & 32 deletions
This file was deleted.

test-packages/test-utils/src/utils/semantic-model-provider.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ const MODEL_CACHE: Record<TestModelVersion, UI5SemanticModel> =
1414
Object.create(null);
1515

1616
const fixes: Record<TestModelVersion, TypeNameFix> = {
17-
"1.71.73": {
17+
"1.71.75": {
1818
array: "any[]",
1919
Array: "any[]",
2020
bloolean: undefined,
@@ -258,7 +258,7 @@ type LibraryFix = (content: Json) => void;
258258

259259
// Library version -> library name -> fix function
260260
const libraryFixes: Record<TestModelVersion, Record<string, LibraryFix[]>> = {
261-
"1.71.73": {},
261+
"1.71.75": {},
262262
"1.84.51": {},
263263
"1.96.27": {
264264
"sap.ui.mdc": [

0 commit comments

Comments
 (0)