[INTERNAL] lib/processors/jsdoc: prefer strict comparison over type coercion

Cherry-picked from UI5/openui5@e38626c0a.

Author: codeworrior

lib/processors/jsdoc/lib/ui5/plugin.js

@@ -49,8 +49,10 @@
  *   newDoclet
  *
  *   parseComplete
- *     remove undocumented/ignored/private doclets or duplicate doclets
+ *     merge collected class info, DataType info and enum values into doclets
  *
+ *   processingComplete
+ *     remove undocumented/ignored/private doclets or duplicate doclets
  *
  * Last but not least, it implements an astNodeVisitor to detect UI5 specific "extend" calls and to create
  * documentation for the properties, aggregations etc. that are created with the "extend" call.
@@ -232,7 +234,7 @@ function resolveModuleName(base, name) {
 	let stack = base.split('/');
 	stack.pop();
 	name.split('/').forEach((segment, i) => {
-		if ( segment == '..' ) {
+		if ( segment === '..' ) {
 			stack.pop();
 		} else if ( segment === '.' ) {
 			// ignore
@@ -456,14 +458,14 @@ function createPropertyMap(node, defaultKey) {
 			return result;
 		}
 
-		if ( node.type != Syntax.ObjectExpression ) {
+		if ( node.type !== Syntax.ObjectExpression ) {
 			// something went wrong, it's not an object literal
 			warning(`not an object literal: ${node.type}: ${node.value}`);
 			// console.log(node.toSource());
 			return undefined;
 		}
 
-		// invariant: node.type == Syntax.ObjectExpression
+		// invariant: node.type === Syntax.ObjectExpression
 		result = {};
 		for (let i = 0; i < node.properties.length; i++) {
 			const prop = node.properties[i];
@@ -1170,7 +1172,7 @@ function collectVisibilityInfo(settings, doclet, className, n) {
 			access = "restricted";
 		}
 
-		if (visibility == "public" && (access === "restricted" || access === "protected")) {
+		if (visibility === "public" && (access === "restricted" || access === "protected")) {
 			visibility = access;
 		}
 	}
@@ -1869,7 +1871,7 @@ function createAutoDoc(oClassInfo, classComment, doclet, node, parser, filename,
 					lines.push("<li>Properties");
 					lines.push("<ul>");
 					for (let n in oClassInfo.properties) {
-						lines.push("<li>{@link " + rname("get", n) + " " + n + "} : " + oClassInfo.properties[n].type + (oClassInfo.properties[n].defaultValue !== null && oClassInfo.properties[n].defaultValue.value !== null ? " (default: " + oClassInfo.properties[n].defaultValue.raw + ")" : "") + (oClassInfo.defaultProperty == n ? " (default)" : "") + "</li>");
+						lines.push("<li>{@link " + rname("get", n) + " " + n + "} : " + oClassInfo.properties[n].type + (oClassInfo.properties[n].defaultValue !== null && oClassInfo.properties[n].defaultValue.value !== null ? " (default: " + oClassInfo.properties[n].defaultValue.raw + ")" : "") + (oClassInfo.defaultProperty === n ? " (default)" : "") + "</li>");
 					}
 					lines.push("</ul>");
 					lines.push("</li>");
@@ -1879,7 +1881,7 @@ function createAutoDoc(oClassInfo, classComment, doclet, node, parser, filename,
 					lines.push("<ul>");
 					for (let n in oClassInfo.aggregations) {
 						if ( oClassInfo.aggregations[n].visibility !== "hidden" ) {
-							lines.push("<li>{@link " + rname("get", n) + " " + n + "} : " + makeTypeString(oClassInfo.aggregations[n]) + (oClassInfo.defaultAggregation == n ? " (default)" : "") + "</li>");
+							lines.push("<li>{@link " + rname("get", n) + " " + n + "} : " + makeTypeString(oClassInfo.aggregations[n]) + (oClassInfo.defaultAggregation === n ? " (default)" : "") + "</li>");
 						}
 					}
 					lines.push("</ul>");
@@ -2067,7 +2069,7 @@ function createAutoDoc(oClassInfo, classComment, doclet, node, parser, filename,
 			"@name " + name("get", n),
 			"@function"
 		]);
-		if ( info.cardinality == "0..n" ) {
+		if ( info.cardinality === "0..n" ) {
 			const n1 = info.singularName;
 			newJSDoc([
 				"Inserts a " + n1 + " into the aggregation " + link + ".",
@@ -3045,7 +3047,7 @@ exports.handlers = {
 		doclets.sort((a, b) => {
 			if ( a.longname === b.longname ) {
 				if ( a.synthetic === b.synthetic ) {
-					if ( a.meta && b.meta && a.meta.filename == b.meta.filename ) {
+					if ( a.meta && b.meta && a.meta.filename === b.meta.filename ) {
 						if ( a.meta.lineno !== b.meta.lineno ) {
 							return a.meta.lineno < b.meta.lineno ? -1 : 1;
 						}

lib/processors/jsdoc/lib/ui5/template/publish.js

@@ -3526,7 +3526,7 @@ function createAPIXML(symbols, filename, options = {}) {
 						}
 
 						if ( !legacyContent ) {
-							if ( hasSettings && j == 1 && /setting/i.test(param.name) && /object/i.test(param.type) ) {
+							if ( hasSettings && j === 1 && /setting/i.test(param.name) && /object/i.test(param.type) ) {
 								if ( addRedundancy ) {
 									tag("parameterProperties");
 									writeParameterPropertiesForMSettings(symbolAPI);