Skip to content

Commit 78e2a22

Browse files
matz3tobiasso85
authored andcommitted
[FIX] Update JSDoc to 3.6.3 (#346)
* Node 12 now supported * Update SDK scripts with versions from other repositories * Skip undefined inherited symbols introduced with JSDoc 3.6.3 * Remove CLI execution part from SDK scripts
1 parent 1742b9c commit 78e2a22

File tree

8 files changed

+570
-342
lines changed

8 files changed

+570
-342
lines changed

lib/processors/jsdoc/apiIndexGenerator.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
const resourceFactory = require("@ui5/fs").resourceFactory;
2-
const createIndex = require("./lib/create-api-index");
2+
const createIndex = require("./lib/createIndexFiles");
33

44
/**
55
* Compiles API index resources from all <code>api.json</code> resources available in the given test resources directory

lib/processors/jsdoc/lib/create-api-index.js renamed to lib/processors/jsdoc/lib/createIndexFiles.js

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ const log = (function() {
2424
}
2525
}());
2626

27-
function process(versionInfoFile, unpackedTestresourcesRoot, targetFile, targetFileDeprecated, targetFileExperimental, targetFileSince, options) {
27+
function createIndexFiles(versionInfoFile, unpackedTestresourcesRoot, targetFile, targetFileDeprecated, targetFileExperimental, targetFileSince, options) {
2828
const fs = options && options.fs || require("fs");
2929
const returnOutputFiles = options && !!options.returnOutputFiles;
3030

@@ -269,6 +269,7 @@ function process(versionInfoFile, unpackedTestresourcesRoot, targetFile, targetF
269269
displayName: sPart,
270270
lib: oSymbol.lib,
271271
kind: "namespace",
272+
visibility: "public", // Virtual namespace are always public
272273
bIsDeprecated: false // Virtual namespace can't be deprecated
273274
});
274275
}
@@ -329,8 +330,8 @@ function process(versionInfoFile, unpackedTestresourcesRoot, targetFile, targetF
329330
function cleanTree (oSymbol) {
330331
delete oSymbol.treeName;
331332
delete oSymbol.parent;
332-
if (oSymbol.children) {
333-
oSymbol.children.forEach(o => cleanTree(o));
333+
if (oSymbol.nodes) {
334+
oSymbol.nodes.forEach(o => cleanTree(o));
334335
}
335336
}
336337
aTree.forEach(o => cleanTree(o));
@@ -449,4 +450,4 @@ function process(versionInfoFile, unpackedTestresourcesRoot, targetFile, targetF
449450

450451
}
451452

452-
module.exports = process;
453+
module.exports = createIndexFiles;

0 commit comments

Comments
 (0)