Skip to content

Commit e4a1c86

Browse files
committed
[BREAKING] Remove support for import over http(s)
BREAKING CHANGE: Import over http(s) is not supported anymore. Use the Builder 'fs' option to provide an interface that also handles http(s) resources.
1 parent b6ed6e9 commit e4a1c86

File tree

1 file changed

+9
-27
lines changed

1 file changed

+9
-27
lines changed

lib/thirdparty/less/index.js

Lines changed: 9 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -153,36 +153,18 @@ less.Parser.fileLoader = function (file, currentFileInfo, callback, env) {
153153

154154
callback(null, data, pathname, newFileInfo);
155155
}
156-
156+
157157
var isUrl = isUrlRe.test( file );
158158
if (isUrl || isUrlRe.test(currentFileInfo.currentDirectory)) {
159-
if (request === undefined) {
160-
try { request = require('request'); }
161-
catch(e) { request = null; }
162-
}
163-
if (!request) {
164-
callback({ type: 'File', message: "optional dependency 'request' required to import over http(s)\n" });
165-
return;
166-
}
167-
168-
var urlStr = isUrl ? file : url.resolve(currentFileInfo.currentDirectory, file),
169-
urlObj = url.parse(urlStr);
170-
171-
request.get({uri: urlStr, strictSSL: !env.insecure }, function (error, res, body) {
172-
if (res.statusCode === 404) {
173-
callback({ type: 'File', message: "resource '" + urlStr + "' was not found\n" });
174-
return;
175-
}
176-
if (!body) {
177-
console.error( 'Warning: Empty body (HTTP '+ res.statusCode + ') returned by "' + urlStr +'"' );
178-
}
179-
if (error) {
180-
callback({ type: 'File', message: "resource '" + urlStr + "' gave this Error:\n "+ error +"\n" });
181-
}
182-
pathname = urlStr;
183-
dirname = urlObj.protocol +'//'+ urlObj.host + urlObj.pathname.replace(/[^\/]*$/, '');
184-
handleDataAndCallCallback(body);
159+
/* BEGIN MODIFICATION */
160+
// Removed support for import over http(s) to get rid of 'request' dependency
161+
callback({
162+
type: 'File',
163+
message: 'Import over http(s) is not supported anymore since less-openui5 v0.9.0\n' +
164+
'Use the Builder \'fs\' option to provide an interface that also handles http(s) resources.\n'
185165
});
166+
return;
167+
/* END MODIFICATION */
186168
} else {
187169

188170
var paths = [currentFileInfo.currentDirectory].concat(env.paths);

0 commit comments

Comments
 (0)