[INTERNAL] Add missing tests for Compiler.js

Author: matz3

lib/Compiler.js

@@ -41,18 +41,12 @@ class Compiler {
 					console.log("File not found: " + pathname);
 					callback({type: "File", message: "Could not find file at path '" + pathname + "'"});
 				} else {
-					try {
-						// Save import mapping to calculate full import paths later on
-						this.mFileMappings[currentFileInfo.rootFilename] =
-							this.mFileMappings[currentFileInfo.rootFilename] || {};
-						this.mFileMappings[currentFileInfo.rootFilename][pathname] = result.path;
-
-						handleDataAndCallCallback(pathname, result.content);
-					} catch (e) {
-						// eslint-disable-next-line no-console
-						console.log(e);
-						callback(e);
-					}
+					// Save import mapping to calculate full import paths later on
+					this.mFileMappings[currentFileInfo.rootFilename] =
+						this.mFileMappings[currentFileInfo.rootFilename] || {};
+					this.mFileMappings[currentFileInfo.rootFilename][pathname] = result.path;
+
+					handleDataAndCallCallback(pathname, result.content);
 				}
 			} catch (err) {
 				// eslint-disable-next-line no-console

package.json

@@ -23,8 +23,8 @@
 	},
 	"scripts": {
 		"lint": "eslint ./",
-		"unit": "mocha test/*.js test/lib/**/*.js",
-		"unit-debug": "mocha --inspect --inspect-brk test/*.js test/lib/**/*.js",
+		"unit": "mocha test/*.js test/lib/**",
+		"unit-debug": "mocha --inspect --inspect-brk test/*.js test/lib/**",
 		"coverage": "nyc npm run unit",
 		"test": "npm run lint && npm run coverage && npm run depcheck",
 		"preversion": "npm test",

test/lib/Compiler.js

@@ -0,0 +1,97 @@
+/* eslint-env mocha */
+
+const assert = require("assert");
+const sinon = require("sinon");
+
+// tested module
+const Compiler = require("../../lib/Compiler");
+
+describe("Compiler#createFileHandler", function() {
+	before(() => {
+		sinon.stub(console, "log");
+	});
+	after(() => {
+		sinon.restore();
+	});
+
+	it("should propagate errors via callback function (TypeError)", async function() {
+		const compiler = new Compiler({
+			options: {
+				rootPaths: ["foo"]
+			},
+			fileUtils: {},
+		});
+
+		const file = "someFile";
+		const currentFileInfo = {
+			currentDirectory: undefined // This will cause a TypeError when calling path.join
+		};
+		const handleDataAndCallCallback = sinon.stub();
+		const callback = sinon.stub();
+
+		await compiler.fnFileHandler(file, currentFileInfo, handleDataAndCallCallback, callback);
+
+		assert.equal(handleDataAndCallCallback.callCount, 0);
+		assert.equal(callback.callCount, 1);
+		assert.equal(callback.getCall(0).args.length, 1);
+		assert.equal(callback.getCall(0).args[0].name, "TypeError");
+		assert.equal(callback.getCall(0).args[0].message,
+			`The "path" argument must be of type string. Received undefined`
+		);
+	});
+	it("should propagate errors via callback function (File not found)", async function() {
+		const compiler = new Compiler({
+			options: {
+				rootPaths: ["foo"]
+			},
+			fileUtils: {
+				readFile: sinon.stub().resolves(null)
+			},
+		});
+
+		const file = "someFile";
+		const currentFileInfo = {
+			currentDirectory: "someFolder"
+		};
+		const handleDataAndCallCallback = sinon.stub();
+		const callback = sinon.stub();
+
+		await compiler.fnFileHandler(file, currentFileInfo, handleDataAndCallCallback, callback);
+
+		assert.equal(handleDataAndCallCallback.callCount, 0);
+		assert.equal(callback.callCount, 1);
+		assert.equal(callback.getCall(0).args.length, 1);
+		assert.equal(callback.getCall(0).args[0].type, "File");
+		assert.equal(callback.getCall(0).args[0].message,
+			`Could not find file at path 'someFolder/someFile'`
+		);
+	});
+	it("should propagate errors via callback function (error within handleDataAndCallCallback)", async function() {
+		const compiler = new Compiler({
+			options: {
+				rootPaths: ["foo"]
+			},
+			fileUtils: {
+				readFile: sinon.stub().resolves({
+					path: "", content: ""
+				})
+			},
+		});
+
+		const file = "someFile";
+		const currentFileInfo = {
+			currentDirectory: "someFolder"
+		};
+		const handleDataAndCallCallback = sinon.stub().throws(new Error("Error from handleDataAndCallCallback"));
+		const callback = sinon.stub();
+
+		await compiler.fnFileHandler(file, currentFileInfo, handleDataAndCallCallback, callback);
+
+		assert.equal(handleDataAndCallCallback.callCount, 1);
+		assert.equal(callback.callCount, 1);
+		assert.equal(callback.getCall(0).args.length, 1);
+		assert.equal(callback.getCall(0).args[0].message,
+			`Error from handleDataAndCallCallback`
+		);
+	});
+});

test/lib/themingParameters/dataUri.js

@@ -1,7 +1,6 @@
 /* eslint-env mocha */
 
 const assert = require("assert");
-// const sinon = require("sinon");
 
 // tested module
 const themingParametersDataUri = require("../../../lib/themingParameters/dataUri");