Skip to content

Commit 338b601

Browse files
Bump eslint from 8.57.0 to 9.8.0 (#359)
* Bump eslint from 8.57.0 to 9.8.0 Bumps [eslint](https://github.com/eslint/eslint) from 8.57.0 to 9.8.0. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v8.57.0...v9.8.0) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Migrate ESlint to flat config * Fix ESlint inconsistencies * Remove ambiguous flattening code * Remove unused module * fix: Resolve conflicts * Resolve conflicts * Fix tests --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Yavor Ivanov <yavor.ivanov@sap.com>
1 parent e31fcbd commit 338b601

File tree

7 files changed

+423
-267
lines changed

7 files changed

+423
-267
lines changed

.eslintignore

Lines changed: 0 additions & 1 deletion
This file was deleted.

.eslintrc.js

Lines changed: 0 additions & 56 deletions
This file was deleted.

eslint.config.mjs

Lines changed: 87 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,87 @@
1+
import jsdoc from "eslint-plugin-jsdoc";
2+
import globals from "globals";
3+
import js from "@eslint/js";
4+
import google from "eslint-config-google";
5+
6+
7+
export default [
8+
js.configs.recommended,
9+
google,
10+
{
11+
ignores: ["lib/thirdparty/"],
12+
},
13+
{
14+
plugins: {
15+
jsdoc,
16+
},
17+
18+
languageOptions: {
19+
globals: {
20+
...globals.node,
21+
...globals.mocha,
22+
},
23+
24+
ecmaVersion: 8,
25+
sourceType: "commonjs",
26+
},
27+
28+
settings: {
29+
jsdoc: {
30+
tagNamePreference: {
31+
return: "returns",
32+
},
33+
},
34+
},
35+
36+
rules: {
37+
"indent": ["error", "tab"],
38+
"linebreak-style": ["error", "unix"],
39+
40+
"quotes": [
41+
"error",
42+
"double",
43+
{
44+
allowTemplateLiterals: true,
45+
},
46+
],
47+
48+
"semi": ["error", "always"],
49+
"no-negated-condition": "off",
50+
"require-jsdoc": "off",
51+
"no-mixed-requires": "off",
52+
53+
"max-len": [
54+
"warn", // TODO: set to "error" and fix all findings
55+
{
56+
code: 120,
57+
ignoreUrls: true,
58+
ignoreRegExpLiterals: true,
59+
},
60+
],
61+
62+
"no-implicit-coercion": [
63+
2,
64+
{
65+
allow: ["!!"],
66+
},
67+
],
68+
69+
"comma-dangle": "off",
70+
"no-tabs": "off",
71+
// This rule must be disabled as of ESLint 9. It's removed and causes issues when present.
72+
// https://eslint.org/docs/latest/rules/valid-jsdoc
73+
"valid-jsdoc": 0,
74+
"jsdoc/require-param-description": 0,
75+
"jsdoc/require-returns-description": 0,
76+
"jsdoc/require-returns": 0,
77+
},
78+
},
79+
{
80+
files: ["**/*.mjs"],
81+
82+
languageOptions: {
83+
ecmaVersion: 2022,
84+
sourceType: "module",
85+
},
86+
},
87+
];

lib/plugin/variable-collector.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ VariableCollector.prototype = {
3939
filename: node.currentFileInfo.filename,
4040
rootFilename: node.currentFileInfo.rootFilename
4141
};
42+
// eslint-disable-next-line no-unused-vars
4243
} catch (err) {
4344
// Errors might occur within mixins.
4445
// But as we only collect global variables, this doesn't matter...

0 commit comments

Comments
 (0)