From f3a50cf997b437881e3acb054df35c6241ec2b07 Mon Sep 17 00:00:00 2001 From: Markus Balsam Date: Tue, 23 Jul 2024 11:54:00 +0200 Subject: [PATCH 1/4] Add output to mission 3248 --- .../discovery_center/mission_3248_trial/step2/outputs.tf | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/released/discovery_center/mission_3248_trial/step2/outputs.tf b/released/discovery_center/mission_3248_trial/step2/outputs.tf index d936e454..dd8762cf 100644 --- a/released/discovery_center/mission_3248_trial/step2/outputs.tf +++ b/released/discovery_center/mission_3248_trial/step2/outputs.tf @@ -3,6 +3,11 @@ output "abab_trial_service_instance_id" { description = "The ID of the ABAP service instance." } +output "abap_trial_dashboard_url" { + value = cloudfoundry_service_instance.abap_trial.dashboard_url + description = "The URL of the ABAP Trial dashboard." +} + output "abab_trial_service_key_id" { value = cloudfoundry_service_credential_binding.abap_trial_service_key.id description = "The ID of the ABAP service key." From 7709c84870af5087c3cf8e1dc34f98b826ff484c Mon Sep 17 00:00:00 2001 From: Markus Balsam Date: Tue, 23 Jul 2024 12:05:29 +0200 Subject: [PATCH 2/4] Output values for ABAP missions (3061, 3248) --- .../mission_3061/step2/main.tf | 8 ++++---- .../mission_3061/step2/outputs.tf | 19 +++++++++++++++++++ 2 files changed, 23 insertions(+), 4 deletions(-) create mode 100644 released/discovery_center/mission_3061/step2/outputs.tf diff --git a/released/discovery_center/mission_3061/step2/main.tf b/released/discovery_center/mission_3061/step2/main.tf index 5c121359..e28d76cc 100644 --- a/released/discovery_center/mission_3061/step2/main.tf +++ b/released/discovery_center/mission_3061/step2/main.tf @@ -102,18 +102,18 @@ resource "cloudfoundry_service_instance" "abap_si" { ### # Creation of service key for ABAP Development Tools (ADT) ### -resource "cloudfoundry_service_credential_binding" "scb1" { +resource "cloudfoundry_service_credential_binding" "abap_adt_key" { type = "key" - name = "${var.abap_sid}_adtkey" + name = "${var.abap_sid}_adt_key" service_instance = cloudfoundry_service_instance.abap_si.id } ### # Creation of service key for COMM Arrangement ### -resource "cloudfoundry_service_credential_binding" "abap_ipskey" { +resource "cloudfoundry_service_credential_binding" "abap_ips_key" { type = "key" - name = "${var.abap_sid}_ipskey" + name = "${var.abap_sid}_ips_key" service_instance = cloudfoundry_service_instance.abap_si.id parameters = jsonencode({ scenario_id = "SAP_COM_0193" diff --git a/released/discovery_center/mission_3061/step2/outputs.tf b/released/discovery_center/mission_3061/step2/outputs.tf new file mode 100644 index 00000000..aec6cbc6 --- /dev/null +++ b/released/discovery_center/mission_3061/step2/outputs.tf @@ -0,0 +1,19 @@ +output "abab_service_instance_id" { + value = cloudfoundry_service_instance.abap_si.id + description = "The ID of the ABAP service instance." +} + +output "abap_dashboard_url" { + value = cloudfoundry_service_instance.abap_si.dashboard_url + description = "The URL of the ABAP service instance dashboard." +} + +output "abab_adt_key_id" { + value = cloudfoundry_service_credential_binding.abap_adt_key.id + description = "The ID of the ABAP service key for ADT." +} + +output "abab_ips_key_id" { + value = cloudfoundry_service_credential_binding.abap_ips_key.id + description = "The ID of the ABAP service key for COMM Arrangement." +} From 411cb4a332ca7bf1a2dffe3f51bde037c7147cda Mon Sep 17 00:00:00 2001 From: Markus Balsam Date: Tue, 23 Jul 2024 12:11:17 +0200 Subject: [PATCH 3/4] fix format --- released/discovery_center/mission_3061/step2/outputs.tf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/released/discovery_center/mission_3061/step2/outputs.tf b/released/discovery_center/mission_3061/step2/outputs.tf index aec6cbc6..411cc48b 100644 --- a/released/discovery_center/mission_3061/step2/outputs.tf +++ b/released/discovery_center/mission_3061/step2/outputs.tf @@ -4,7 +4,7 @@ output "abab_service_instance_id" { } output "abap_dashboard_url" { - value = cloudfoundry_service_instance.abap_si.dashboard_url + value = cloudfoundry_service_instance.abap_si.dashboard_url description = "The URL of the ABAP service instance dashboard." } From f361110206d62feaeb170cdf83220b784c33e869 Mon Sep 17 00:00:00 2001 From: Markus Balsam Date: Tue, 23 Jul 2024 12:12:33 +0200 Subject: [PATCH 4/4] fix fmt --- released/discovery_center/mission_3248_trial/step2/outputs.tf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/released/discovery_center/mission_3248_trial/step2/outputs.tf b/released/discovery_center/mission_3248_trial/step2/outputs.tf index dd8762cf..1c37d5e7 100644 --- a/released/discovery_center/mission_3248_trial/step2/outputs.tf +++ b/released/discovery_center/mission_3248_trial/step2/outputs.tf @@ -4,7 +4,7 @@ output "abab_trial_service_instance_id" { } output "abap_trial_dashboard_url" { - value = cloudfoundry_service_instance.abap_trial.dashboard_url + value = cloudfoundry_service_instance.abap_trial.dashboard_url description = "The URL of the ABAP Trial dashboard." }