Skip to content

Commit 2838e8c

Browse files
authored
πŸ› Marks RxViewModel as open (#51)
* πŸ› Marks `RxViewModel` as `open` When `RxViewModel` was created `Swift` only had 3 access levels; and thus marking it as `public` would suffice for subclassing; with `Swift` 3 this changed and we never got around modifying the access level on the class to be `open` as reported on #50. * πŸ”§ Fixes Codecov config
1 parent 69b9277 commit 2838e8c

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

β€ŽSource/RxViewModel.swift

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ import RxSwift
1616
Implements behaviors that drive the UI, and/or adapts a domain model to be
1717
user-presentable.
1818
*/
19-
public class RxViewModel: NSObject {
19+
open class RxViewModel: NSObject {
2020
// MARK: Constants
2121
let throttleTime: TimeInterval = 2
2222

β€Žcodecov.yml

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,9 @@
11
codecov:
2-
branch: master
2+
notify:
3+
require_ci_to_pass: yes
34
comment:
45
layout: "header, changes, diff, sunburst"
6+
57
coverage:
68
ignore:
79
- Pods/.*
@@ -12,12 +14,10 @@ coverage:
1214
- .*Tests.swift
1315
- '# Add the folders containing your unit tests'
1416
- '# This ensures any test utility classes you create are also ignored'
15-
- Demo/Tests/*
16-
- Demo/Pods/*
17-
- Demo/Build/*
17+
- Demo/Demo/Tests/*
18+
- Demo/Demo/Pods/*
19+
- Demo/Demo/Build/*
20+
- Demo/Demo/*
1821
status:
1922
patch: false
20-
notify:
21-
webhook:
22-
default:
23-
url: https://codecov.io/webhooks/github
23+

0 commit comments

Comments
Β (0)