Skip to content

Commit cee7946

Browse files
authored
zeroize: add #[ignore] to flaky CString test (#776)
This test relies on UB and is flaking out in certain cases: #774 It's unclear if the test failure indicates a genuine bug in the implementation, or is the result of a test with UB. However, in the meantime it shouldn't block users who would just like the test suite to run reliably.
1 parent a511710 commit cee7946

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

zeroize/tests/zeroize.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -166,7 +166,9 @@ fn zeroize_string_entire_capacity() {
166166
assert!(as_vec.iter().all(|byte| *byte == 0));
167167
}
168168

169+
// TODO(tarcieri): debug flaky test (with potential UB?) See: RustCrypto/utils#774
169170
#[cfg(feature = "std")]
171+
#[ignore]
170172
#[test]
171173
fn zeroize_c_string() {
172174
let mut cstring = CString::new("Hello, world!").expect("CString::new failed");

0 commit comments

Comments
 (0)