x509-cert: impl hash for name (#1764)

* der: impl `Hash` for `SetOf`

Fixes #1763

* x509-cert: impl `Hash` for `Name`

Fixes #1763

Author: baloo

der/src/arrayvec.rs

@@ -5,7 +5,7 @@
 use crate::{ErrorKind, Result};
 
 /// Array-backed append-only vector type.
-#[derive(Clone, Debug, Eq, PartialEq, PartialOrd, Ord)]
+#[derive(Clone, Debug, Eq, PartialEq, PartialOrd, Ord, Hash)]
 pub(crate) struct ArrayVec<T, const N: usize> {
     /// Elements of the set.
     elements: [Option<T>; N],

der/src/asn1/set_of.rs

@@ -25,7 +25,7 @@ use {alloc::vec::Vec, core::slice};
 /// and does not depend on `alloc` support.
 // TODO(tarcieri): use `ArrayVec` when/if it's merged into `core`
 // See: https://github.com/rust-lang/rfcs/pull/2990
-#[derive(Clone, Debug, Eq, PartialEq, PartialOrd, Ord)]
+#[derive(Clone, Debug, Eq, PartialEq, PartialOrd, Ord, Hash)]
 pub struct SetOf<T, const N: usize>
 where
     T: DerOrd,
@@ -200,7 +200,7 @@ impl<T> ExactSizeIterator for SetOfIter<'_, T> {}
 /// This type implements an append-only `SET OF` type which is heap-backed
 /// and depends on `alloc` support.
 #[cfg(feature = "alloc")]
-#[derive(Clone, Debug, Eq, PartialEq, PartialOrd, Ord)]
+#[derive(Clone, Debug, Eq, PartialEq, PartialOrd, Ord, Hash)]
 pub struct SetOfVec<T>
 where
     T: DerOrd,

x509-cert/src/attr.rs

@@ -85,7 +85,7 @@ pub type Attributes = SetOfVec<Attribute>;
 ///
 /// [RFC 5280 Appendix A.1]: https://datatracker.ietf.org/doc/html/rfc5280#appendix-A.1
 #[cfg_attr(feature = "arbitrary", derive(arbitrary::Arbitrary))]
-#[derive(Clone, Debug, Eq, PartialEq, PartialOrd, Ord, Sequence, ValueOrd)]
+#[derive(Clone, Debug, Eq, PartialEq, PartialOrd, Ord, Sequence, ValueOrd, Hash)]
 #[allow(missing_docs)]
 pub struct AttributeTypeAndValue {
     pub oid: AttributeType,

x509-cert/src/name.rs

@@ -57,7 +57,7 @@ use der::{
 /// [RFC 4514 Section 3]: https://www.rfc-editor.org/rfc/rfc4514#section-3
 /// [RFC 5280 Section 4.1.2.4]: https://datatracker.ietf.org/doc/html/rfc5280#section-4.1.2.4
 #[cfg_attr(feature = "arbitrary", derive(arbitrary::Arbitrary))]
-#[derive(Clone, Debug, Default, PartialEq, Eq)]
+#[derive(Clone, Debug, Default, PartialEq, Eq, Hash)]
 pub struct Name(pub(crate) RdnSequence);
 
 impl Name {
@@ -307,7 +307,7 @@ impl fmt::Display for Name {
 ///
 /// [RFC 5280 Section 4.1.2.4]: https://datatracker.ietf.org/doc/html/rfc5280#section-4.1.2.4
 #[cfg_attr(feature = "arbitrary", derive(arbitrary::Arbitrary))]
-#[derive(Clone, Debug, Default, PartialEq, Eq)]
+#[derive(Clone, Debug, Default, PartialEq, Eq, Hash)]
 pub struct RdnSequence(Vec<RelativeDistinguishedName>);
 
 impl RdnSequence {
@@ -437,7 +437,7 @@ pub type DistinguishedName = RdnSequence;
 ///
 /// [RFC 5280 Section 4.1.2.4]: https://datatracker.ietf.org/doc/html/rfc5280#section-4.1.2.4
 #[cfg_attr(feature = "arbitrary", derive(arbitrary::Arbitrary))]
-#[derive(Clone, Debug, Default, PartialEq, Eq)]
+#[derive(Clone, Debug, Default, PartialEq, Eq, Hash)]
 pub struct RelativeDistinguishedName(pub(crate) SetOfVec<AttributeTypeAndValue>);
 
 impl RelativeDistinguishedName {